[bpf-next:master 32/36] net/core/filter.c:11842:48: warning: 'struct bpf_tcp_req_attrs' declared inside parameter list will not be visible outside of this definition or declaration

[bpf-next:master 32/36] net/core/filter.c:11842:48: warning: 'struct bpf_tcp_req_attrs' declared inside parameter list will not be visible outside of this definition or declaration

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
head:   be7c19de9ecf4d93a9908003a1a3b8f1e8f8a672
commit: b9c3eca5c086eb65f20ad92fe3aa3d556f23103b [32/36] bpf: tcp: Support arbitrary SYN Cookie.
config: i386-buildonly-randconfig-003-20240117 (https://download.01.org/0day-ci/archive/20240117/202401172023.YWRhXvC2-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240117/202401172023.YWRhXvC2-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401172023.YWRhXvC2-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/core/filter.c:11842:48: warning: 'struct bpf_tcp_req_attrs' declared inside parameter list will not be visible outside of this definition or declaration
   11842 |                                         struct bpf_tcp_req_attrs *attrs, int attrs__sz)
         |                                                ^~~~~~~~~~~~~~~~~


vim +11842 net/core/filter.c

 11840	
 11841	__bpf_kfunc int bpf_sk_assign_tcp_reqsk(struct sk_buff *skb, struct sock *sk,
 11842						struct bpf_tcp_req_attrs *attrs, int attrs__sz)
 11843	{
 11844	#if IS_ENABLED(CONFIG_SYN_COOKIES)
 11845		const struct request_sock_ops *ops;
 11846		struct inet_request_sock *ireq;
 11847		struct tcp_request_sock *treq;
 11848		struct request_sock *req;
 11849		struct net *net;
 11850		__u16 min_mss;
 11851		u32 tsoff = 0;
 11852	
 11853		if (attrs__sz != sizeof(*attrs) ||
 11854		    attrs->reserved[0] || attrs->reserved[1] || attrs->reserved[2])
 11855			return -EINVAL;
 11856	
 11857		if (!skb_at_tc_ingress(skb))
 11858			return -EINVAL;
 11859	
 11860		net = dev_net(skb->dev);
 11861		if (net != sock_net(sk))
 11862			return -ENETUNREACH;
 11863	
 11864		switch (skb->protocol) {
 11865		case htons(ETH_P_IP):
 11866			ops = &tcp_request_sock_ops;
 11867			min_mss = 536;
 11868			break;
 11869	#if IS_BUILTIN(CONFIG_IPV6)
 11870		case htons(ETH_P_IPV6):
 11871			ops = &tcp6_request_sock_ops;
 11872			min_mss = IPV6_MIN_MTU - 60;
 11873			break;
 11874	#endif
 11875		default:
 11876			return -EINVAL;
 11877		}
 11878	
 11879		if (sk->sk_type != SOCK_STREAM || sk->sk_state != TCP_LISTEN ||
 11880		    sk_is_mptcp(sk))
 11881			return -EINVAL;
 11882	
 11883		if (attrs->mss < min_mss)
 11884			return -EINVAL;
 11885	
 11886		if (attrs->wscale_ok) {
 11887			if (!READ_ONCE(net->ipv4.sysctl_tcp_window_scaling))
 11888				return -EINVAL;
 11889	
 11890			if (attrs->snd_wscale > TCP_MAX_WSCALE ||
 11891			    attrs->rcv_wscale > TCP_MAX_WSCALE)
 11892				return -EINVAL;
 11893		}
 11894	
 11895		if (attrs->sack_ok && !READ_ONCE(net->ipv4.sysctl_tcp_sack))
 11896			return -EINVAL;
 11897	
 11898		if (attrs->tstamp_ok) {
 11899			if (!READ_ONCE(net->ipv4.sysctl_tcp_timestamps))
 11900				return -EINVAL;
 11901	
 11902			tsoff = attrs->rcv_tsecr - tcp_ns_to_ts(attrs->usec_ts_ok, tcp_clock_ns());
 11903		}
 11904	
 11905		req = inet_reqsk_alloc(ops, sk, false);
 11906		if (!req)
 11907			return -ENOMEM;
 11908	
 11909		ireq = inet_rsk(req);
 11910		treq = tcp_rsk(req);
 11911	
 11912		req->rsk_listener = sk;
 11913		req->syncookie = 1;
 11914		req->mss = attrs->mss;
 11915		req->ts_recent = attrs->rcv_tsval;
 11916	
 11917		ireq->snd_wscale = attrs->snd_wscale;
 11918		ireq->rcv_wscale = attrs->rcv_wscale;
 11919		ireq->tstamp_ok	= !!attrs->tstamp_ok;
 11920		ireq->sack_ok = !!attrs->sack_ok;
 11921		ireq->wscale_ok = !!attrs->wscale_ok;
 11922		ireq->ecn_ok = !!attrs->ecn_ok;
 11923	
 11924		treq->req_usec_ts = !!attrs->usec_ts_ok;
 11925		treq->ts_off = tsoff;
 11926	
 11927		skb_orphan(skb);
 11928		skb->sk = req_to_sk(req);
 11929		skb->destructor = sock_pfree;
 11930	
 11931		return 0;
 11932	#else
 11933		return -EOPNOTSUPP;
 11934	#endif
 11935	}
 11936	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki