From: Rob Herring <robh@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Andrew Davis" <afd@ti.com>,
"Frank Binns" <frank.binns@imgtec.com>,
"Matt Coster" <matt.coster@imgtec.com>,
"H . Nikolaus Schaller" <hns@goldelico.com>,
"Adam Ford" <aford173@gmail.com>,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Nishanth Menon" <nm@ti.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Tero Kristo" <kristo@kernel.org>,
"Paul Cercueil" <paul@crapouillou.net>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-omap@vger.kernel.org,
linux-mips@vger.kernel.org
Subject: Re: [PATCH 02/11] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs
Date: Fri, 19 Jan 2024 11:48:15 -0600 [thread overview]
Message-ID: <20240119174815.GA633343-robh@kernel.org> (raw)
In-Reply-To: <20240110083857.GB5185@atomide.com>
On Wed, Jan 10, 2024 at 10:38:57AM +0200, Tony Lindgren wrote:
> * Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [240109 19:53]:
> > On 09/01/2024 18:19, Andrew Davis wrote:
> > > The Imagination PowerVR Series5 "SGX" GPU is part of several SoCs from
> > > multiple vendors. Describe how the SGX GPU is integrated in these SoC,
> > > including register space and interrupts. Clocks, reset, and power domain
> > > information is SoC specific.
> > >
> > > Signed-off-by: Andrew Davis <afd@ti.com>
> > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> >
> >
> > > + clock-names:
> > > + minItems: 1
> > > + items:
> > > + - const: core
> > > + - const: mem
> > > + - const: sys
> >
> > There are no devices currently using third clock, but I assume it is
> > expected or possible.
>
> I think the third clock is typically merged with one of the two clocks but
> yeah possibly it's a separate clocke in some cases.
>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Looks good to me too.
>
> So for merging these, as many of the changes touch the omap variants, I
> could set up an immutable branch with all the changes after -rc1. Or I can
> ack the patches too if somebody has better ideas.
Just take all but patches 10 and 11. I don't think it matters if the
binding is there for them as long as it is all there in next. No one is
paying that close attention to the warnings I think.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Andrew Davis" <afd@ti.com>,
"Frank Binns" <frank.binns@imgtec.com>,
"Matt Coster" <matt.coster@imgtec.com>,
"H . Nikolaus Schaller" <hns@goldelico.com>,
"Adam Ford" <aford173@gmail.com>,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Nishanth Menon" <nm@ti.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Tero Kristo" <kristo@kernel.org>,
"Paul Cercueil" <paul@crapouillou.net>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-omap@vger.kernel.org,
linux-mips@vger.kernel.org
Subject: Re: [PATCH 02/11] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs
Date: Fri, 19 Jan 2024 11:48:15 -0600 [thread overview]
Message-ID: <20240119174815.GA633343-robh@kernel.org> (raw)
In-Reply-To: <20240110083857.GB5185@atomide.com>
On Wed, Jan 10, 2024 at 10:38:57AM +0200, Tony Lindgren wrote:
> * Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [240109 19:53]:
> > On 09/01/2024 18:19, Andrew Davis wrote:
> > > The Imagination PowerVR Series5 "SGX" GPU is part of several SoCs from
> > > multiple vendors. Describe how the SGX GPU is integrated in these SoC,
> > > including register space and interrupts. Clocks, reset, and power domain
> > > information is SoC specific.
> > >
> > > Signed-off-by: Andrew Davis <afd@ti.com>
> > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> >
> >
> > > + clock-names:
> > > + minItems: 1
> > > + items:
> > > + - const: core
> > > + - const: mem
> > > + - const: sys
> >
> > There are no devices currently using third clock, but I assume it is
> > expected or possible.
>
> I think the third clock is typically merged with one of the two clocks but
> yeah possibly it's a separate clocke in some cases.
>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Looks good to me too.
>
> So for merging these, as many of the changes touch the omap variants, I
> could set up an immutable branch with all the changes after -rc1. Or I can
> ack the patches too if somebody has better ideas.
Just take all but patches 10 and 11. I don't think it matters if the
binding is there for them as long as it is all there in next. No one is
paying that close attention to the warnings I think.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: "Nishanth Menon" <nm@ti.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"H . Nikolaus Schaller" <hns@goldelico.com>,
dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org,
"Paul Cercueil" <paul@crapouillou.net>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Chen-Yu Tsai" <wens@csie.org>,
linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org,
"Conor Dooley" <conor+dt@kernel.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Matt Coster" <matt.coster@imgtec.com>,
linux-omap@vger.kernel.org, "Adam Ford" <aford173@gmail.com>,
linux-arm-kernel@lists.infradead.org,
"Tero Kristo" <kristo@kernel.org>,
linux-kernel@vger.kernel.org, "Andrew Davis" <afd@ti.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>
Subject: Re: [PATCH 02/11] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs
Date: Fri, 19 Jan 2024 11:48:15 -0600 [thread overview]
Message-ID: <20240119174815.GA633343-robh@kernel.org> (raw)
In-Reply-To: <20240110083857.GB5185@atomide.com>
On Wed, Jan 10, 2024 at 10:38:57AM +0200, Tony Lindgren wrote:
> * Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [240109 19:53]:
> > On 09/01/2024 18:19, Andrew Davis wrote:
> > > The Imagination PowerVR Series5 "SGX" GPU is part of several SoCs from
> > > multiple vendors. Describe how the SGX GPU is integrated in these SoC,
> > > including register space and interrupts. Clocks, reset, and power domain
> > > information is SoC specific.
> > >
> > > Signed-off-by: Andrew Davis <afd@ti.com>
> > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> >
> >
> > > + clock-names:
> > > + minItems: 1
> > > + items:
> > > + - const: core
> > > + - const: mem
> > > + - const: sys
> >
> > There are no devices currently using third clock, but I assume it is
> > expected or possible.
>
> I think the third clock is typically merged with one of the two clocks but
> yeah possibly it's a separate clocke in some cases.
>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Looks good to me too.
>
> So for merging these, as many of the changes touch the omap variants, I
> could set up an immutable branch with all the changes after -rc1. Or I can
> ack the patches too if somebody has better ideas.
Just take all but patches 10 and 11. I don't think it matters if the
binding is there for them as long as it is all there in next. No one is
paying that close attention to the warnings I think.
Rob
next prev parent reply other threads:[~2024-01-19 17:48 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 17:19 [PATCH 00/11] Device tree support for Imagination Series5 GPU Andrew Davis
2024-01-09 17:19 ` Andrew Davis
2024-01-09 17:19 ` Andrew Davis
2024-01-09 17:19 ` [PATCH 01/11] dt-bindings: gpu: Rename img,powervr to img,powervr-rogue Andrew Davis
2024-01-09 17:19 ` [PATCH 01/11] dt-bindings: gpu: Rename img, powervr to img, powervr-rogue Andrew Davis
2024-01-09 17:19 ` [PATCH 01/11] dt-bindings: gpu: Rename img,powervr to img,powervr-rogue Andrew Davis
2024-01-09 18:59 ` Krzysztof Kozlowski
2024-01-09 18:59 ` Krzysztof Kozlowski
2024-01-09 18:59 ` Krzysztof Kozlowski
2024-01-09 19:04 ` Andrew Davis
2024-01-09 19:04 ` Andrew Davis
2024-01-09 19:04 ` Andrew Davis
2024-01-09 19:17 ` Krzysztof Kozlowski
2024-01-09 19:17 ` Krzysztof Kozlowski
2024-01-09 19:17 ` Krzysztof Kozlowski
2024-01-09 19:33 ` Andrew Davis
2024-01-09 19:33 ` Andrew Davis
2024-01-09 19:33 ` Andrew Davis
2024-01-09 19:52 ` Krzysztof Kozlowski
2024-01-09 19:52 ` Krzysztof Kozlowski
2024-01-09 19:52 ` Krzysztof Kozlowski
2024-01-09 19:52 ` Krzysztof Kozlowski
2024-01-09 19:52 ` Krzysztof Kozlowski
2024-01-09 17:19 ` [PATCH 02/11] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs Andrew Davis
2024-01-09 17:19 ` Andrew Davis
2024-01-09 17:19 ` Andrew Davis
2024-01-09 19:53 ` Krzysztof Kozlowski
2024-01-09 19:53 ` Krzysztof Kozlowski
2024-01-09 19:53 ` Krzysztof Kozlowski
2024-01-10 8:38 ` Tony Lindgren
2024-01-10 8:38 ` Tony Lindgren
2024-01-10 8:38 ` Tony Lindgren
2024-01-19 17:48 ` Rob Herring [this message]
2024-01-19 17:48 ` Rob Herring
2024-01-19 17:48 ` Rob Herring
2024-01-26 8:31 ` Tony Lindgren
2024-01-26 8:31 ` Tony Lindgren
2024-01-26 8:31 ` Tony Lindgren
2024-01-09 17:19 ` [PATCH 03/11] ARM: dts: omap3: Add device tree entry for SGX GPU Andrew Davis
2024-01-09 17:19 ` Andrew Davis
2024-01-09 17:19 ` Andrew Davis
2024-01-09 17:19 ` [PATCH 04/11] ARM: dts: omap4: " Andrew Davis
2024-01-09 17:19 ` Andrew Davis
2024-01-09 17:19 ` Andrew Davis
2024-01-09 17:19 ` [PATCH 05/11] ARM: dts: omap5: " Andrew Davis
2024-01-09 17:19 ` Andrew Davis
2024-01-09 17:19 ` Andrew Davis
2024-01-09 17:19 ` [PATCH 06/11] ARM: dts: AM33xx: " Andrew Davis
2024-01-09 17:19 ` Andrew Davis
2024-01-09 17:19 ` Andrew Davis
2024-01-09 17:19 ` [PATCH 07/11] ARM: dts: AM437x: " Andrew Davis
2024-01-09 17:19 ` Andrew Davis
2024-01-09 17:19 ` Andrew Davis
2024-01-09 17:19 ` [PATCH 08/11] ARM: dts: DRA7xx: " Andrew Davis
2024-01-09 17:19 ` Andrew Davis
2024-01-09 17:19 ` Andrew Davis
2024-01-10 8:29 ` Tony Lindgren
2024-01-10 8:29 ` Tony Lindgren
2024-01-10 8:29 ` Tony Lindgren
2024-01-17 15:52 ` Andrew Davis
2024-01-17 15:52 ` Andrew Davis
2024-01-17 15:52 ` Andrew Davis
2024-01-18 8:55 ` Tony Lindgren
2024-01-18 8:55 ` Tony Lindgren
2024-01-18 8:55 ` Tony Lindgren
2024-01-26 7:45 ` Tony Lindgren
2024-01-26 7:45 ` Tony Lindgren
2024-01-26 7:45 ` Tony Lindgren
2024-01-09 17:19 ` [PATCH 09/11] arm64: dts: ti: k3-am654-main: " Andrew Davis
2024-01-09 17:19 ` Andrew Davis
2024-01-09 17:19 ` Andrew Davis
2024-01-09 17:19 ` [PATCH 10/11] ARM: dts: sun6i: " Andrew Davis
2024-01-09 17:19 ` Andrew Davis
2024-01-09 17:19 ` Andrew Davis
2024-01-09 17:19 ` [PATCH 11/11] MIPS: DTS: jz4780: " Andrew Davis
2024-01-09 17:19 ` Andrew Davis
2024-01-09 17:19 ` Andrew Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240119174815.GA633343-robh@kernel.org \
--to=robh@kernel.org \
--cc=afd@ti.com \
--cc=aford173@gmail.com \
--cc=bcousson@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frank.binns@imgtec.com \
--cc=hns@goldelico.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matt.coster@imgtec.com \
--cc=mripard@kernel.org \
--cc=nm@ti.com \
--cc=paul@crapouillou.net \
--cc=samuel@sholland.org \
--cc=tony@atomide.com \
--cc=tzimmermann@suse.de \
--cc=vigneshr@ti.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.