All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] osdep/hurd/getroot: Fix 64bit build
@ 2024-01-20 18:35 Samuel Thibault
  2024-01-20 20:11 ` Samuel Thibault
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Samuel Thibault @ 2024-01-20 18:35 UTC (permalink / raw)
  To: The development of GNU GRUB; +Cc: bug-hurd

file_get_fs_options takes a mach_msg_type_number_t (32bit), not a size_t
(64bit on 64bit platforms).
---
 grub-core/osdep/hurd/getroot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/grub-core/osdep/hurd/getroot.c b/grub-core/osdep/hurd/getroot.c
index 0efefdab4..b849700e6 100644
--- a/grub-core/osdep/hurd/getroot.c
+++ b/grub-core/osdep/hurd/getroot.c
@@ -58,7 +58,7 @@ grub_util_find_hurd_root_device (const char *path)
   file_t file;
   error_t err;
   char *argz = NULL, *name = NULL, *ret;
-  size_t argz_len = 0;
+  mach_msg_type_number_t argz_len = 0;
   int i;
 
   file = file_name_lookup (path, 0, 0);
-- 
2.43.0


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] osdep/hurd/getroot: Fix 64bit build
  2024-01-20 18:35 [PATCH] osdep/hurd/getroot: Fix 64bit build Samuel Thibault
@ 2024-01-20 20:11 ` Samuel Thibault
  2024-01-20 20:14 ` John Paul Adrian Glaubitz
  2024-01-21  2:22 ` Vladimir 'phcoder' Serbinenko
  2 siblings, 0 replies; 5+ messages in thread
From: Samuel Thibault @ 2024-01-20 20:11 UTC (permalink / raw)
  To: The development of GNU GRUB, bug-hurd

Samuel Thibault, le sam. 20 janv. 2024 19:35:13 +0100, a ecrit:
> file_get_fs_options takes a mach_msg_type_number_t (32bit), not a size_t
> (64bit on 64bit platforms).

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  grub-core/osdep/hurd/getroot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/grub-core/osdep/hurd/getroot.c b/grub-core/osdep/hurd/getroot.c
> index 0efefdab4..b849700e6 100644
> --- a/grub-core/osdep/hurd/getroot.c
> +++ b/grub-core/osdep/hurd/getroot.c
> @@ -58,7 +58,7 @@ grub_util_find_hurd_root_device (const char *path)
>    file_t file;
>    error_t err;
>    char *argz = NULL, *name = NULL, *ret;
> -  size_t argz_len = 0;
> +  mach_msg_type_number_t argz_len = 0;
>    int i;
>  
>    file = file_name_lookup (path, 0, 0);
> -- 
> 2.43.0
> 

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] osdep/hurd/getroot: Fix 64bit build
  2024-01-20 18:35 [PATCH] osdep/hurd/getroot: Fix 64bit build Samuel Thibault
  2024-01-20 20:11 ` Samuel Thibault
@ 2024-01-20 20:14 ` John Paul Adrian Glaubitz
  2024-01-21  2:22 ` Vladimir 'phcoder' Serbinenko
  2 siblings, 0 replies; 5+ messages in thread
From: John Paul Adrian Glaubitz @ 2024-01-20 20:14 UTC (permalink / raw)
  To: The development of GNU GRUB; +Cc: bug-hurd

On Sat, 2024-01-20 at 19:35 +0100, Samuel Thibault wrote:
> file_get_fs_options takes a mach_msg_type_number_t (32bit), not a size_t
> (64bit on 64bit platforms).

Nitpick: I think it should be "32 bit", "64 bit" and "64-bit", the former
two referring two a word size while the latter refers to the target type.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] osdep/hurd/getroot: Fix 64bit build
  2024-01-20 18:35 [PATCH] osdep/hurd/getroot: Fix 64bit build Samuel Thibault
  2024-01-20 20:11 ` Samuel Thibault
  2024-01-20 20:14 ` John Paul Adrian Glaubitz
@ 2024-01-21  2:22 ` Vladimir 'phcoder' Serbinenko
  2024-01-23 15:04   ` Daniel Kiper
  2 siblings, 1 reply; 5+ messages in thread
From: Vladimir 'phcoder' Serbinenko @ 2024-01-21  2:22 UTC (permalink / raw)
  To: The development of GNU GRUB, bug-hurd


[-- Attachment #1.1: Type: text/plain, Size: 1025 bytes --]

LGTM
Reviewed-by: Vladimir Serbinenko<phcoder@gmail.com>

Le sam. 20 janv. 2024, 21:36, Samuel Thibault <samuel.thibault@ens-lyon.org>
a écrit :

> file_get_fs_options takes a mach_msg_type_number_t (32bit), not a size_t
> (64bit on 64bit platforms).
> ---
>  grub-core/osdep/hurd/getroot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/grub-core/osdep/hurd/getroot.c
> b/grub-core/osdep/hurd/getroot.c
> index 0efefdab4..b849700e6 100644
> --- a/grub-core/osdep/hurd/getroot.c
> +++ b/grub-core/osdep/hurd/getroot.c
> @@ -58,7 +58,7 @@ grub_util_find_hurd_root_device (const char *path)
>    file_t file;
>    error_t err;
>    char *argz = NULL, *name = NULL, *ret;
> -  size_t argz_len = 0;
> +  mach_msg_type_number_t argz_len = 0;
>    int i;
>
>    file = file_name_lookup (path, 0, 0);
> --
> 2.43.0
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>

[-- Attachment #1.2: Type: text/html, Size: 1604 bytes --]

[-- Attachment #2: Type: text/plain, Size: 141 bytes --]

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] osdep/hurd/getroot: Fix 64bit build
  2024-01-21  2:22 ` Vladimir 'phcoder' Serbinenko
@ 2024-01-23 15:04   ` Daniel Kiper
  0 siblings, 0 replies; 5+ messages in thread
From: Daniel Kiper @ 2024-01-23 15:04 UTC (permalink / raw)
  To: Samuel Thibault, Vladimir 'phcoder' Serbinenko
  Cc: grub-devel, bug-hurd

On Sun, Jan 21, 2024 at 05:22:29AM +0300, Vladimir 'phcoder' Serbinenko wrote:
> LGTM
> Reviewed-by: Vladimir Serbinenko<phcoder@gmail.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-23 15:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-20 18:35 [PATCH] osdep/hurd/getroot: Fix 64bit build Samuel Thibault
2024-01-20 20:11 ` Samuel Thibault
2024-01-20 20:14 ` John Paul Adrian Glaubitz
2024-01-21  2:22 ` Vladimir 'phcoder' Serbinenko
2024-01-23 15:04   ` Daniel Kiper

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.