All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Joe Damato <jdamato@fastly.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC 1/1] eventpoll: support busy poll per epoll instance
Date: Sun, 21 Jan 2024 22:21:10 +0800	[thread overview]
Message-ID: <202401212239.LAqIJgfm-lkp@intel.com> (raw)
In-Reply-To: <20240120004247.42036-2-jdamato@fastly.com>

Hi Joe,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on perf-tools-next/perf-tools-next]
[also build test WARNING on tip/perf/core perf-tools/perf-tools linus/master horms-ipvs/master acme/perf/core v6.7 next-20240119]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Joe-Damato/eventpoll-support-busy-poll-per-epoll-instance/20240120-084514
base:   https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git perf-tools-next
patch link:    https://lore.kernel.org/r/20240120004247.42036-2-jdamato%40fastly.com
patch subject: [RFC 1/1] eventpoll: support busy poll per epoll instance
config: i386-buildonly-randconfig-001-20240121 (https://download.01.org/0day-ci/archive/20240121/202401212239.LAqIJgfm-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240121/202401212239.LAqIJgfm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401212239.LAqIJgfm-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/eventpoll.c:398: warning: Function parameter or member 'start_time' not described in 'busy_loop_ep_timeout'
>> fs/eventpoll.c:398: warning: Function parameter or member 'ep' not described in 'busy_loop_ep_timeout'


vim +398 fs/eventpoll.c

   391	
   392	/**
   393	 * busy_loop_ep_timeout - check if busy poll has timed out. The timeout value
   394	 * from the epoll instance ep is preferred, but if it is not set fallback to
   395	 * the system-wide global via busy_loop_timeout.
   396	 */
   397	static inline bool busy_loop_ep_timeout(unsigned long start_time, struct eventpoll *ep)
 > 398	{
   399	#ifdef CONFIG_NET_RX_BUSY_POLL
   400		unsigned long bp_usec = READ_ONCE(ep->busy_poll_usecs);
   401	
   402		if (bp_usec) {
   403			unsigned long end_time = start_time + bp_usec;
   404			unsigned long now = busy_loop_current_time();
   405	
   406			return time_after(now, end_time);
   407		} else {
   408			return busy_loop_timeout(start_time);
   409		}
   410	#endif
   411		return true;
   412	}
   413	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2024-01-21 14:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-20  0:42 [RFC 0/1] RFC: Allow busy poll to be set per epoll instance Joe Damato
2024-01-20  0:42 ` [RFC 1/1] eventpoll: support busy poll " Joe Damato
2024-01-21 14:21   ` kernel test robot [this message]
2024-01-21 14:42   ` kernel test robot
2024-01-21 16:06   ` kernel test robot
2024-01-22 15:25   ` Christian Brauner
2024-01-22 21:16     ` Joe Damato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202401212239.LAqIJgfm-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=jdamato@fastly.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.