From: Joe Damato <jdamato@fastly.com>
To: Christian Brauner <brauner@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
chuck.lever@oracle.com, jlayton@kernel.org,
linux-api@vger.kernel.org, edumazet@google.com,
davem@davemloft.net, alexander.duyck@gmail.com,
sridhar.samudrala@intel.com, kuba@kernel.org
Subject: Re: [RFC 1/1] eventpoll: support busy poll per epoll instance
Date: Mon, 22 Jan 2024 13:16:16 -0800 [thread overview]
Message-ID: <20240122211616.GA1244@fastly.com> (raw)
In-Reply-To: <20240122-erwidern-erleichtern-8a04080a4db3@brauner>
On Mon, Jan 22, 2024 at 04:25:01PM +0100, Christian Brauner wrote:
> On Sat, Jan 20, 2024 at 12:42:47AM +0000, Joe Damato wrote:
> > Add F_EPOLL_{S,G}ET_BUSY_POLL_USECS to allow setting a busy poll timeout
> > per epoll instance so that individual applications can enable (or
> > disable) epoll based busy poll as needed.
> >
> > Prior to this change, epoll-based busy poll could only be enabled
> > system-wide, which limits the usefulness of busy poll.
> >
> > Signed-off-by: Joe Damato <jdamato@fastly.com>
> > ---
>
> This should be an ioctl on the epoll fd, not a fcntl(). fcntl()s
> should aim to be generic which this isn't. We've recently rejected a
> memfd addition as a fcntl() as well for the same reason.
OK, thanks for the review. An ioctl makes more sense, I agree.
I'll rewrite it as you've suggested and send another RFC.
prev parent reply other threads:[~2024-01-22 21:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-20 0:42 [RFC 0/1] RFC: Allow busy poll to be set per epoll instance Joe Damato
2024-01-20 0:42 ` [RFC 1/1] eventpoll: support busy poll " Joe Damato
2024-01-21 14:21 ` kernel test robot
2024-01-21 14:42 ` kernel test robot
2024-01-21 16:06 ` kernel test robot
2024-01-22 15:25 ` Christian Brauner
2024-01-22 21:16 ` Joe Damato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122211616.GA1244@fastly.com \
--to=jdamato@fastly.com \
--cc=alexander.duyck@gmail.com \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jlayton@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.