From: Arnd Bergmann <arnd@kernel.org>
To: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Cc: "Thomas Zimmermann" <tzimmermann@suse.de>,
"Arnd Bergmann" <arnd@arndb.de>,
"Sven Peter" <sven@svenpeter.dev>, "Janne Grunau" <j@jannau.net>,
"Hector Martin" <marcan@marcan.st>,
linux-kernel@vger.kernel.org,
"Maxime Ripard" <mripard@kernel.org>,
dri-devel@lists.freedesktop.org,
"Daniel Vetter" <daniel@ffwll.ch>,
"Martin Povišer" <povik+lin@cutebit.org>,
"David Airlie" <airlied@gmail.com>
Subject: [PATCH] drm: apple: use strscpy() in place of strlcpy()
Date: Mon, 22 Jan 2024 17:11:55 +0100 [thread overview]
Message-ID: <20240122161233.125192-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
Since commit d26270061ae6 ("string: Remove strlcpy()"), the strlcpy()
function causes a build failure.
Since the return value is ignored, changing it to the strscpy()
causes no change in behavior but fixes the build failure.
Fixes: f237c83e4302 ("drm: apple: DCP AFK/EPIC support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
The apple drm driver is not in mainline linux yet, this patch
is against https://github.com/AsahiLinux/linux/tree/bits/200-dcp
---
drivers/gpu/drm/apple/afk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/apple/afk.c b/drivers/gpu/drm/apple/afk.c
index 99d579d5ce47..9fbcd18878e8 100644
--- a/drivers/gpu/drm/apple/afk.c
+++ b/drivers/gpu/drm/apple/afk.c
@@ -236,7 +236,7 @@ static void afk_recv_handle_init(struct apple_dcp_afkep *ep, u32 channel,
return;
}
- strlcpy(name, payload, sizeof(name));
+ strscpy(name, payload, sizeof(name));
/*
* in DCP firmware 13.2 DCP reports interface-name as name which starts
--
2.39.2
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org>
To: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>, "Janne Grunau" <j@jannau.net>,
"Martin Povišer" <povik+lin@cutebit.org>,
"Hector Martin" <marcan@marcan.st>,
"Sven Peter" <sven@svenpeter.dev>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drm: apple: use strscpy() in place of strlcpy()
Date: Mon, 22 Jan 2024 17:11:55 +0100 [thread overview]
Message-ID: <20240122161233.125192-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
Since commit d26270061ae6 ("string: Remove strlcpy()"), the strlcpy()
function causes a build failure.
Since the return value is ignored, changing it to the strscpy()
causes no change in behavior but fixes the build failure.
Fixes: f237c83e4302 ("drm: apple: DCP AFK/EPIC support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
The apple drm driver is not in mainline linux yet, this patch
is against https://github.com/AsahiLinux/linux/tree/bits/200-dcp
---
drivers/gpu/drm/apple/afk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/apple/afk.c b/drivers/gpu/drm/apple/afk.c
index 99d579d5ce47..9fbcd18878e8 100644
--- a/drivers/gpu/drm/apple/afk.c
+++ b/drivers/gpu/drm/apple/afk.c
@@ -236,7 +236,7 @@ static void afk_recv_handle_init(struct apple_dcp_afkep *ep, u32 channel,
return;
}
- strlcpy(name, payload, sizeof(name));
+ strscpy(name, payload, sizeof(name));
/*
* in DCP firmware 13.2 DCP reports interface-name as name which starts
--
2.39.2
next reply other threads:[~2024-01-22 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 16:11 Arnd Bergmann [this message]
2024-01-22 16:11 ` [PATCH] drm: apple: use strscpy() in place of strlcpy() Arnd Bergmann
2024-01-22 20:51 ` Janne Grunau
2024-01-22 20:51 ` Janne Grunau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122161233.125192-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=airlied@gmail.com \
--cc=alyssa@rosenzweig.io \
--cc=arnd@arndb.de \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=j@jannau.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=mripard@kernel.org \
--cc=povik+lin@cutebit.org \
--cc=sven@svenpeter.dev \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.