From: Simon Horman <horms@kernel.org>
To: Suresh Kumar <suresh2514@gmail.com>
Cc: intel-wired-lan@lists.osuosl.org, jesse.brandeburg@intel.com,
linux-kernel@vger.kernel.org, edumazet@google.com,
anthony.l.nguyen@intel.com, netdev@vger.kernel.org,
kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH iwl v2] i40e: print correct hw max rss count in kernel ring buffer
Date: Mon, 22 Jan 2024 20:51:37 +0000 [thread overview]
Message-ID: <20240122205137.GH126470@kernel.org> (raw)
In-Reply-To: <20240120072806.8554-1-suresh2514@gmail.com>
On Sat, Jan 20, 2024 at 12:58:06PM +0530, Suresh Kumar wrote:
> pf->rss_size_max is hardcoded and always prints max rss count as 64.
>
> Eg:
> kernel: i40e 0000:af:00.1: User requested queue count/HW max RSS count: 104/64
>
> whereas ethtool reports the correct value from "vsi->num_queue_pairs"
>
> Channel parameters for eno33:
> Pre-set maximums:
> RX: n/a
> TX: n/a
> Other: 1
> Combined: 104
> Current hardware settings:
> RX: n/a
> TX: n/a
> Other: 1
> Combined: 104 <-------
>
> and is misleading.
>
> Change it to vsi->num_queue_pairs
>
> Signed-off-by: Suresh Kumar <suresh2514@gmail.com>
Hi Suresh,
following-up on our earlier emails.
I do think that if this it is a fix it should have a fixes tag.
Which should be for the commit where the bug was first visible to users.
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Suresh Kumar <suresh2514@gmail.com>
Cc: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH iwl v2] i40e: print correct hw max rss count in kernel ring buffer
Date: Mon, 22 Jan 2024 20:51:37 +0000 [thread overview]
Message-ID: <20240122205137.GH126470@kernel.org> (raw)
In-Reply-To: <20240120072806.8554-1-suresh2514@gmail.com>
On Sat, Jan 20, 2024 at 12:58:06PM +0530, Suresh Kumar wrote:
> pf->rss_size_max is hardcoded and always prints max rss count as 64.
>
> Eg:
> kernel: i40e 0000:af:00.1: User requested queue count/HW max RSS count: 104/64
>
> whereas ethtool reports the correct value from "vsi->num_queue_pairs"
>
> Channel parameters for eno33:
> Pre-set maximums:
> RX: n/a
> TX: n/a
> Other: 1
> Combined: 104
> Current hardware settings:
> RX: n/a
> TX: n/a
> Other: 1
> Combined: 104 <-------
>
> and is misleading.
>
> Change it to vsi->num_queue_pairs
>
> Signed-off-by: Suresh Kumar <suresh2514@gmail.com>
Hi Suresh,
following-up on our earlier emails.
I do think that if this it is a fix it should have a fixes tag.
Which should be for the commit where the bug was first visible to users.
next prev parent reply other threads:[~2024-01-22 20:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-20 7:28 [Intel-wired-lan] [PATCH iwl v2] i40e: print correct hw max rss count in kernel ring buffer Suresh Kumar
2024-01-20 7:28 ` Suresh Kumar
2024-01-22 20:51 ` Simon Horman [this message]
2024-01-22 20:51 ` Simon Horman
2024-01-24 2:55 ` [Intel-wired-lan] " suresh ks
[not found] ` <e524c57e-fe43-4582-bb05-c50f3e529848@intel.com>
2024-01-30 8:33 ` Loktionov, Aleksandr
2024-01-30 8:33 ` Loktionov, Aleksandr
2024-02-08 13:13 ` [Intel-wired-lan] " suresh ks
2024-02-08 13:29 ` Loktionov, Aleksandr
2024-02-08 16:16 ` suresh ks
2024-02-15 16:22 ` Maciej Fijalkowski
2024-02-15 16:22 ` Maciej Fijalkowski
2024-03-07 14:39 ` [Intel-wired-lan] " suresh ks
2024-03-07 15:24 ` Maciej Fijalkowski
2024-03-07 15:24 ` Maciej Fijalkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122205137.GH126470@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=suresh2514@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.