From: Simon Horman <horms@kernel.org>
To: Zhipeng Lu <alexious@zju.edu.cn>
Cc: Alice Michael <alice.michael@intel.com>,
intel-wired-lan@lists.osuosl.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Piotr Marczak <piotr.marczak@intel.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH] i40e: fix a memleak in i40e_init_recovery_mode
Date: Mon, 22 Jan 2024 21:10:46 +0000 [thread overview]
Message-ID: <20240122211046.GK126470@kernel.org> (raw)
In-Reply-To: <20240122173633.3843715-1-alexious@zju.edu.cn>
On Tue, Jan 23, 2024 at 01:36:33AM +0800, Zhipeng Lu wrote:
> In i40e_init_recovery_mode, pf->vsi is allocated without free, causing
> a memleak. This patch adds deallocation operations for pf->vsi in each
> and every error-handling paths after pf->vsi's.
>
> Fixes: 4ff0ee1af016 ("i40e: Introduce recovery mode support")
> Signed-off-by: Zhipeng Lu <alexious@zju.edu.cn>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Zhipeng Lu <alexious@zju.edu.cn>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Piotr Marczak <piotr.marczak@intel.com>,
Alice Michael <alice.michael@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i40e: fix a memleak in i40e_init_recovery_mode
Date: Mon, 22 Jan 2024 21:10:46 +0000 [thread overview]
Message-ID: <20240122211046.GK126470@kernel.org> (raw)
In-Reply-To: <20240122173633.3843715-1-alexious@zju.edu.cn>
On Tue, Jan 23, 2024 at 01:36:33AM +0800, Zhipeng Lu wrote:
> In i40e_init_recovery_mode, pf->vsi is allocated without free, causing
> a memleak. This patch adds deallocation operations for pf->vsi in each
> and every error-handling paths after pf->vsi's.
>
> Fixes: 4ff0ee1af016 ("i40e: Introduce recovery mode support")
> Signed-off-by: Zhipeng Lu <alexious@zju.edu.cn>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-01-22 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 17:36 [PATCH] i40e: fix a memleak in i40e_init_recovery_mode Zhipeng Lu
2024-01-22 21:10 ` Simon Horman [this message]
2024-01-22 21:10 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122211046.GK126470@kernel.org \
--to=horms@kernel.org \
--cc=alexious@zju.edu.cn \
--cc=alice.michael@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=piotr.marczak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.