pull-request: wireless-2024-01-22

pull-request: wireless-2024-01-22

[Kalle Valo]

Hi,

here's a pull request to net tree, more info below. Please let me know if there
are any problems.

Kalle

The following changes since commit ac631873c9e7a50d2a8de457cfc4b9f86666403e:

  net: ethernet: cortina: Drop TSO support (2024-01-07 16:05:00 +0000)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless.git tags/wireless-2024-01-22

for you to fetch changes up to bcbc84af1183c8cf3d1ca9b78540c2185cd85e7f:

  wifi: mac80211: fix race condition on enabling fast-xmit (2024-01-18 14:51:15 +0100)

----------------------------------------------------------------
wireless fixes for v6.8-rc2

The most visible fix here is the ath11k crash fix which was introduced
in v6.7. We also have a fix for iwlwifi memory corruption and few
smaller fixes in the stack.

----------------------------------------------------------------
Benjamin Berg (1):
      wifi: ath11k: rely on mac80211 debugfs handling for vif

Emmanuel Grumbach (1):
      wifi: iwlwifi: fix a memory corruption

Felix Fietkau (1):
      wifi: mac80211: fix race condition on enabling fast-xmit

Johannes Berg (1):
      wifi: mac80211: fix potential sta-link leak

Kalle Valo (1):
      wifi: p54: fix GCC format truncation warning with wiphy->fw_version

Lukas Bulwahn (1):
      wifi: cfg80211/mac80211: remove dependency on non-existing option

Michal Kazior (1):
      wifi: cfg80211: fix missing interfaces when dumping

 drivers/net/wireless/ath/ath11k/core.h           |  4 ----
 drivers/net/wireless/ath/ath11k/debugfs.c        | 25 ++++++++++--------------
 drivers/net/wireless/ath/ath11k/debugfs.h        | 12 ++----------
 drivers/net/wireless/ath/ath11k/mac.c            | 12 +-----------
 drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c |  4 ++--
 drivers/net/wireless/intersil/p54/fwio.c         |  2 +-
 net/mac80211/Kconfig                             |  1 -
 net/mac80211/sta_info.c                          |  7 ++++++-
 net/mac80211/tx.c                                |  2 +-
 net/wireless/Kconfig                             |  1 -
 net/wireless/nl80211.c                           |  1 +
 11 files changed, 24 insertions(+), 47 deletions(-)

Re: pull-request: wireless-2024-01-22

[Jakub Kicinski]

On Mon, 22 Jan 2024 15:34:34 +0000 (UTC) Kalle Valo wrote:
> Lukas Bulwahn (1):
>       wifi: cfg80211/mac80211: remove dependency on non-existing option

BTW we run all kernel's kunit tests on netdev periodically by doing:

./tools/testing/kunit/kunit.py run --all

and AFAICT the WiFi tests don't pop up there :(

https://netdev.bots.linux.dev/contest.html?branch=net-next-2024-01-23--15-00&executor=kunit

Is that on purpose?

Re: pull-request: wireless-2024-01-22

[Johannes Berg]

On Tue, 2024-01-23 at 08:45 -0800, Jakub Kicinski wrote:
> On Mon, 22 Jan 2024 15:34:34 +0000 (UTC) Kalle Valo wrote:
> > Lukas Bulwahn (1):
> >       wifi: cfg80211/mac80211: remove dependency on non-existing option
> 
> BTW we run all kernel's kunit tests on netdev periodically by doing:
> 
> ./tools/testing/kunit/kunit.py run --all
> 
> and AFAICT the WiFi tests don't pop up there :(
> 
> https://netdev.bots.linux.dev/contest.html?branch=net-next-2024-01-23--15-00&executor=kunit
> 
> Is that on purpose?

No, but honestly, I didn't even really know about it, which is mostly
for lack of bothering to look - because we run them in a different way
now both in upstream hostap and internally (internally we also have
another file with metadata to tie them to other bits of the whole
project that isn't interesting upstream).

Looks like that needs adjustments to the config file there, mostly? I
can see about adding that, probably not that hard, at least for
mac80211/cfg80211.

++kunit folks:

We're also adding unit tests to iwlwifi (slowly), any idea if we should
enable that here also? It _is_ now possible to build PCI stuff on kunit,
but it requires some additional config options (virt-pci etc.), not sure
that's desirable here? It doesn't need it at runtime for the tests, of
course.

johannes

Re: pull-request: wireless-2024-01-22

[Johannes Berg]

On Tue, 2024-01-23 at 19:19 +0100, Johannes Berg wrote:
> 
> We're also adding unit tests to iwlwifi (slowly), any idea if we should
> enable that here also? It _is_ now possible to build PCI stuff on kunit,
> but it requires some additional config options (virt-pci etc.), not sure
> that's desirable here? It doesn't need it at runtime for the tests, of
> course.
> 

Heh, in fact Miri just posted the first bits:

https://lore.kernel.org/r/20240123200528.a4a8af7c091f.I0fb09083317b331168b99b8db39656a126a5cc4d@changeid


Also, should enabling that in
tools/testing/kunit/configs/all_tests.config go through our tree, or
better through the kselftest tree?

johannes

Re: pull-request: wireless-2024-01-22

[David Gow]

[-- Attachment #1: Type: text/plain, Size: 1195 bytes --]

On Wed, 24 Jan 2024 at 02:22, Johannes Berg <johannes@sipsolutions.net> wrote:
>
> On Tue, 2024-01-23 at 19:19 +0100, Johannes Berg wrote:
> >
> > We're also adding unit tests to iwlwifi (slowly), any idea if we should
> > enable that here also? It _is_ now possible to build PCI stuff on kunit,
> > but it requires some additional config options (virt-pci etc.), not sure
> > that's desirable here? It doesn't need it at runtime for the tests, of
> > course.
> >
>
> Heh, in fact Miri just posted the first bits:
>
> https://lore.kernel.org/r/20240123200528.a4a8af7c091f.I0fb09083317b331168b99b8db39656a126a5cc4d@changeid
>
>
> Also, should enabling that in
> tools/testing/kunit/configs/all_tests.config go through our tree, or
> better through the kselftest tree?
>

I'd definitely like the iwlwifi tests to be enabled in all_tests.config.

The virt-pci options _should_ already be enabled for the UML configs
under kunit.py by default now (they're in
.../configs/arch_uml.config).

I don't mind which tree the changes to all_tests.config go through --
I suspect it's probably better for them to go in via your tree,
particularly if they end up depending on any new config options.

-- David

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4014 bytes --]

Re: pull-request: wireless-2024-01-22

[David Gow]

[-- Attachment #1: Type: text/plain, Size: 1195 bytes --]

On Wed, 24 Jan 2024 at 02:22, Johannes Berg <johannes@sipsolutions.net> wrote:
>
> On Tue, 2024-01-23 at 19:19 +0100, Johannes Berg wrote:
> >
> > We're also adding unit tests to iwlwifi (slowly), any idea if we should
> > enable that here also? It _is_ now possible to build PCI stuff on kunit,
> > but it requires some additional config options (virt-pci etc.), not sure
> > that's desirable here? It doesn't need it at runtime for the tests, of
> > course.
> >
>
> Heh, in fact Miri just posted the first bits:
>
> https://lore.kernel.org/r/20240123200528.a4a8af7c091f.I0fb09083317b331168b99b8db39656a126a5cc4d@changeid
>
>
> Also, should enabling that in
> tools/testing/kunit/configs/all_tests.config go through our tree, or
> better through the kselftest tree?
>

I'd definitely like the iwlwifi tests to be enabled in all_tests.config.

The virt-pci options _should_ already be enabled for the UML configs
under kunit.py by default now (they're in
.../configs/arch_uml.config).

I don't mind which tree the changes to all_tests.config go through --
I suspect it's probably better for them to go in via your tree,
particularly if they end up depending on any new config options.

-- David

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4014 bytes --]

Re: pull-request: wireless-2024-01-22

[Jakub Kicinski]

On Tue, 23 Jan 2024 19:19:35 +0100 Johannes Berg wrote:
> Looks like that needs adjustments to the config file there, mostly? I
> can see about adding that, probably not that hard, at least for
> mac80211/cfg80211.

To be clear I was mostly thinking about mac80211/cfg80211...

> We're also adding unit tests to iwlwifi (slowly), any idea if we should
> enable that here also? It _is_ now possible to build PCI stuff on kunit,
> but it requires some additional config options (virt-pci etc.), not sure
> that's desirable here? It doesn't need it at runtime for the tests, of
> course.

but curious to hear about driver testing recommendations.

Re: pull-request: wireless-2024-01-22

[Johannes Berg]

On Tue, 2024-01-23 at 13:42 -0800, Jakub Kicinski wrote:
> 
> > We're also adding unit tests to iwlwifi (slowly), any idea if we should
> > enable that here also? It _is_ now possible to build PCI stuff on kunit,
> > but it requires some additional config options (virt-pci etc.), not sure
> > that's desirable here? It doesn't need it at runtime for the tests, of
> > course.
> 
> but curious to hear about driver testing recommendations.

Not sure I have any recommendations ... The test we posted is checking
an invariant (the devinfo array is sorted in the right way); we used to
have a check for this in the internal driver variant at init time, now
it's a kunit test and we don't have to carry the delta to upstream here.

I think Miri is also working on some additional tests for some driver-
internal logic though.

So not sure, I guess it'd be just like anything else you could use unit
testing for, certain self-contained parts of the code that don't really
otherwise need a device, etc.?

johannes

Re: pull-request: wireless-2024-01-22

[patchwork-bot+netdevbpf]

Hello:

This pull request was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 22 Jan 2024 15:34:34 +0000 (UTC) you wrote:
> Hi,
> 
> here's a pull request to net tree, more info below. Please let me know if there
> are any problems.
> 
> Kalle
> 
> [...]

Here is the summary with links:
  - pull-request: wireless-2024-01-22
    https://git.kernel.org/netdev/net/c/1347775dea7f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html