From: Simon Horman <horms@kernel.org>
To: Karol Kolacinski <karol.kolacinski@intel.com>
Cc: Jacob Keller <jacob.e.keller@intel.com>,
netdev@vger.kernel.org, anthony.l.nguyen@intel.com,
intel-wired-lan@lists.osuosl.org, jesse.brandeburg@intel.com
Subject: Re: [Intel-wired-lan] [PATCH v6 iwl-next 2/7] ice: pass reset type to PTP reset functions
Date: Tue, 23 Jan 2024 16:40:03 +0000 [thread overview]
Message-ID: <20240123164003.GF254773@kernel.org> (raw)
In-Reply-To: <20240118174552.2565889-3-karol.kolacinski@intel.com>
On Thu, Jan 18, 2024 at 06:45:47PM +0100, Karol Kolacinski wrote:
> From: Jacob Keller <jacob.e.keller@intel.com>
>
> The ice_ptp_prepare_for_reset() and ice_ptp_reset() functions currently
> check the pf->flags ICE_FLAG_PFR_REQ bit to determine if the current
> reset is a PF reset or not.
>
> This is problematic, because it is possible that a PF reset and a higher
> level reset (CORE reset, GLOBAL reset, EMP reset) are requested
> simultaneously. In that case, the driver performs the highest level
> reset requested. However, the ICE_FLAG_PFR_REQ flag will still be set.
>
> The main driver reset functions take an enum ice_reset_req indicating
> which reset is actually being performed. Pass this data into the PTP
> functions and rely on this instead of relying on the driver flags.
>
> This ensures that the PTP code performs the proper level of reset that
> the driver is actually undergoing.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Karol Kolacinski <karol.kolacinski@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
anthony.l.nguyen@intel.com, jesse.brandeburg@intel.com,
Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [PATCH v6 iwl-next 2/7] ice: pass reset type to PTP reset functions
Date: Tue, 23 Jan 2024 16:40:03 +0000 [thread overview]
Message-ID: <20240123164003.GF254773@kernel.org> (raw)
In-Reply-To: <20240118174552.2565889-3-karol.kolacinski@intel.com>
On Thu, Jan 18, 2024 at 06:45:47PM +0100, Karol Kolacinski wrote:
> From: Jacob Keller <jacob.e.keller@intel.com>
>
> The ice_ptp_prepare_for_reset() and ice_ptp_reset() functions currently
> check the pf->flags ICE_FLAG_PFR_REQ bit to determine if the current
> reset is a PF reset or not.
>
> This is problematic, because it is possible that a PF reset and a higher
> level reset (CORE reset, GLOBAL reset, EMP reset) are requested
> simultaneously. In that case, the driver performs the highest level
> reset requested. However, the ICE_FLAG_PFR_REQ flag will still be set.
>
> The main driver reset functions take an enum ice_reset_req indicating
> which reset is actually being performed. Pass this data into the PTP
> functions and rely on this instead of relying on the driver flags.
>
> This ensures that the PTP code performs the proper level of reset that
> the driver is actually undergoing.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-01-23 16:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 17:45 [Intel-wired-lan] [PATCH v6 iwl-next 0/7] ice: fix timestamping in reset process Karol Kolacinski
2024-01-18 17:45 ` Karol Kolacinski
2024-01-18 17:45 ` [Intel-wired-lan] [PATCH v6 iwl-next 1/7] ice: introduce PTP state machine Karol Kolacinski
2024-01-18 17:45 ` Karol Kolacinski
2024-01-23 16:38 ` [Intel-wired-lan] " Simon Horman
2024-01-23 16:38 ` Simon Horman
2024-01-18 17:45 ` [Intel-wired-lan] [PATCH v6 iwl-next 2/7] ice: pass reset type to PTP reset functions Karol Kolacinski
2024-01-18 17:45 ` Karol Kolacinski
2024-01-23 16:40 ` Simon Horman [this message]
2024-01-23 16:40 ` Simon Horman
2024-01-18 17:45 ` [Intel-wired-lan] [PATCH v6 iwl-next 3/7] ice: rename verify_cached to has_ready_bitmap Karol Kolacinski
2024-01-18 17:45 ` Karol Kolacinski
2024-01-22 21:39 ` [Intel-wired-lan] " Tony Nguyen
2024-01-22 21:39 ` Tony Nguyen
2024-01-18 17:45 ` [Intel-wired-lan] [PATCH v6 iwl-next 4/7] ice: don't check has_ready_bitmap in E810 functions Karol Kolacinski
2024-01-18 17:45 ` Karol Kolacinski
2024-01-18 17:45 ` [Intel-wired-lan] [PATCH v6 iwl-next 5/7] ice: rename ice_ptp_tx_cfg_intr Karol Kolacinski
2024-01-18 17:45 ` Karol Kolacinski
2024-01-18 17:45 ` [Intel-wired-lan] [PATCH v6 iwl-next 6/7] ice: factor out ice_ptp_rebuild_owner() Karol Kolacinski
2024-01-18 17:45 ` Karol Kolacinski
2024-01-18 17:45 ` [Intel-wired-lan] [PATCH v6 iwl-next 7/7] ice: stop destroying and reinitalizing Tx tracker during reset Karol Kolacinski
2024-01-18 17:45 ` Karol Kolacinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240123164003.GF254773@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=karol.kolacinski@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.