From: Simon Horman <horms@kernel.org>
To: Karol Kolacinski <karol.kolacinski@intel.com>
Cc: Jacob Keller <jacob.e.keller@intel.com>,
netdev@vger.kernel.org, anthony.l.nguyen@intel.com,
intel-wired-lan@lists.osuosl.org, jesse.brandeburg@intel.com
Subject: Re: [Intel-wired-lan] [PATCH v7 iwl-next 3/7] ice: rename verify_cached to has_ready_bitmap
Date: Tue, 23 Jan 2024 16:50:40 +0000 [thread overview]
Message-ID: <20240123165040.GI254773@kernel.org> (raw)
In-Reply-To: <20240123105131.2842935-4-karol.kolacinski@intel.com>
On Tue, Jan 23, 2024 at 11:51:27AM +0100, Karol Kolacinski wrote:
> From: Jacob Keller <jacob.e.keller@intel.com>
>
> The tx->verify_cached flag is used to inform the Tx timestamp tracking
> code whether it needs to verify the cached Tx timestamp value against
> a previous captured value. This is necessary on E810 hardware which does
> not have a Tx timestamp ready bitmap.
>
> In addition, we currently rely on the fact that the
> ice_get_phy_tx_tstamp_ready() function returns all 1s for E810 hardware.
> Instead of introducing a brand new flag, rename and verify_cached to
> has_ready_bitmap, inverting the relevant checks.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Karol Kolacinski <karol.kolacinski@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
anthony.l.nguyen@intel.com, jesse.brandeburg@intel.com,
Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [PATCH v7 iwl-next 3/7] ice: rename verify_cached to has_ready_bitmap
Date: Tue, 23 Jan 2024 16:50:40 +0000 [thread overview]
Message-ID: <20240123165040.GI254773@kernel.org> (raw)
In-Reply-To: <20240123105131.2842935-4-karol.kolacinski@intel.com>
On Tue, Jan 23, 2024 at 11:51:27AM +0100, Karol Kolacinski wrote:
> From: Jacob Keller <jacob.e.keller@intel.com>
>
> The tx->verify_cached flag is used to inform the Tx timestamp tracking
> code whether it needs to verify the cached Tx timestamp value against
> a previous captured value. This is necessary on E810 hardware which does
> not have a Tx timestamp ready bitmap.
>
> In addition, we currently rely on the fact that the
> ice_get_phy_tx_tstamp_ready() function returns all 1s for E810 hardware.
> Instead of introducing a brand new flag, rename and verify_cached to
> has_ready_bitmap, inverting the relevant checks.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-01-23 16:50 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 10:51 [Intel-wired-lan] [PATCH v7 iwl-next 0/7] ice: fix timestamping in reset process Karol Kolacinski
2024-01-23 10:51 ` Karol Kolacinski
2024-01-23 10:51 ` [Intel-wired-lan] [PATCH v7 iwl-next 1/7] ice: introduce PTP state machine Karol Kolacinski
2024-01-23 10:51 ` Karol Kolacinski
2024-01-23 16:47 ` [Intel-wired-lan] " Simon Horman
2024-01-23 16:47 ` Simon Horman
2024-01-25 9:19 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-01-25 9:19 ` Pucha, HimasekharX Reddy
2024-01-23 10:51 ` [Intel-wired-lan] [PATCH v7 iwl-next 2/7] ice: pass reset type to PTP reset functions Karol Kolacinski
2024-01-23 10:51 ` Karol Kolacinski
2024-01-23 16:48 ` [Intel-wired-lan] " Simon Horman
2024-01-23 16:48 ` Simon Horman
2024-01-25 9:17 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-01-25 9:17 ` Pucha, HimasekharX Reddy
2024-01-23 10:51 ` [Intel-wired-lan] [PATCH v7 iwl-next 3/7] ice: rename verify_cached to has_ready_bitmap Karol Kolacinski
2024-01-23 10:51 ` Karol Kolacinski
2024-01-23 16:50 ` Simon Horman [this message]
2024-01-23 16:50 ` Simon Horman
2024-01-25 9:15 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-01-25 9:15 ` Pucha, HimasekharX Reddy
2024-01-23 10:51 ` [Intel-wired-lan] [PATCH v7 iwl-next 4/7] ice: don't check has_ready_bitmap in E810 functions Karol Kolacinski
2024-01-23 10:51 ` Karol Kolacinski
2024-01-23 16:52 ` [Intel-wired-lan] " Simon Horman
2024-01-23 16:52 ` Simon Horman
2024-01-25 9:10 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-01-25 9:10 ` Pucha, HimasekharX Reddy
2024-01-23 10:51 ` [Intel-wired-lan] [PATCH v7 iwl-next 5/7] ice: rename ice_ptp_tx_cfg_intr Karol Kolacinski
2024-01-23 10:51 ` Karol Kolacinski
2024-01-23 17:06 ` [Intel-wired-lan] " Simon Horman
2024-01-23 17:06 ` Simon Horman
2024-01-25 9:08 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-01-25 9:08 ` Pucha, HimasekharX Reddy
2024-01-23 10:51 ` [Intel-wired-lan] [PATCH v7 iwl-next 6/7] ice: factor out ice_ptp_rebuild_owner() Karol Kolacinski
2024-01-23 10:51 ` Karol Kolacinski
2024-01-23 17:07 ` [Intel-wired-lan] " Simon Horman
2024-01-23 17:07 ` Simon Horman
2024-01-25 9:05 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-01-25 9:05 ` Pucha, HimasekharX Reddy
2024-01-23 10:51 ` [Intel-wired-lan] [PATCH v7 iwl-next 7/7] ice: stop destroying and reinitalizing Tx tracker during reset Karol Kolacinski
2024-01-23 10:51 ` Karol Kolacinski
2024-01-23 17:07 ` [Intel-wired-lan] " Simon Horman
2024-01-23 17:07 ` Simon Horman
2024-01-25 9:03 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-01-25 9:03 ` Pucha, HimasekharX Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240123165040.GI254773@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=karol.kolacinski@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.