* [Buildroot] [PATCH] package/environment-setup: replace variable KERNELDIR with KERNEL_DIR
@ 2024-01-24 5:32 Nayab Sayed via buildroot
2024-01-30 20:02 ` Arnout Vandecappelle via buildroot
0 siblings, 1 reply; 4+ messages in thread
From: Nayab Sayed via buildroot @ 2024-01-24 5:32 UTC (permalink / raw)
To: buildroot; +Cc: Nayab Sayed
This commit updates the host environment setup helper script to use the more
conventional variable name KERNEL_DIR instead of KERNELDIR. The change is made
for consistency and to align with established conventions in the project (like
KERNEL_HOST, HOST_DIR etc.). No functional changes are introduced by this
commit.
Signed-off-by: Nayab Sayed <nayabbasha.sayed@microchip.com>
---
package/environment-setup/environment-setup | 2 +-
package/environment-setup/environment-setup.mk | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/environment-setup/environment-setup b/package/environment-setup/environment-setup
index 84a9843c24..8504a89743 100644
--- a/package/environment-setup/environment-setup
+++ b/package/environment-setup/environment-setup
@@ -10,7 +10,7 @@ cat <<'EOF'
Some tips:
* PATH now contains the SDK utilities
* Standard autotools variables (CC, LD, CFLAGS) are exported
-* Kernel compilation variables (ARCH, CROSS_COMPILE, KERNELDIR) are exported
+* Kernel compilation variables (ARCH, CROSS_COMPILE, KERNEL_DIR) are exported
* To configure do "./configure $CONFIGURE_FLAGS" or use
the "configure" alias
* To build CMake-based projects, use the "cmake" alias
diff --git a/package/environment-setup/environment-setup.mk b/package/environment-setup/environment-setup.mk
index 29ec5a9a95..cc058a5799 100644
--- a/package/environment-setup/environment-setup.mk
+++ b/package/environment-setup/environment-setup.mk
@@ -34,7 +34,7 @@ define HOST_ENVIRONMENT_SETUP_INSTALL_CMDS
>> $(ENVIRONMENT_SETUP_FILE)
$(if $(BR2_LINUX_KERNEL),\
- printf "export \"KERNELDIR=$(LINUX_BUILDDIR)\"\n" \
+ printf "export \"KERNEL_DIR=$(LINUX_BUILDDIR)\"\n" \
>> $(ENVIRONMENT_SETUP_FILE),)
endef
---
base-commit: 04dfeff6242516a1061973fc7af2cc9c5e3dd4e2
change-id: 20240124-kernel_dir-41a48fd97b75
Best regards,
--
Nayab Sayed <nayabbasha.sayed@microchip.com>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/environment-setup: replace variable KERNELDIR with KERNEL_DIR
2024-01-24 5:32 [Buildroot] [PATCH] package/environment-setup: replace variable KERNELDIR with KERNEL_DIR Nayab Sayed via buildroot
@ 2024-01-30 20:02 ` Arnout Vandecappelle via buildroot
2024-01-30 20:12 ` Angelo Compagnucci
0 siblings, 1 reply; 4+ messages in thread
From: Arnout Vandecappelle via buildroot @ 2024-01-30 20:02 UTC (permalink / raw)
To: Nayab Sayed, buildroot; +Cc: Angelo Compagnucci
On 24/01/2024 06:32, Nayab Sayed via buildroot wrote:
> This commit updates the host environment setup helper script to use the more
> conventional variable name KERNEL_DIR instead of KERNELDIR. The change is made
> for consistency and to align with established conventions in the project (like
> KERNEL_HOST, HOST_DIR etc.). No functional changes are introduced by this
> commit.
Do you have some evidence of this established convention?
We currently have three external module packages that use KERNELDIR
(falcosecurity-libs, ti-gfx and ti-sgx-km) and two that use KERNEL_DIR
(kernel-module-imx-gpu-viv and gcnano-binaries).
It has been KERNELDIR in Buildroot for more than 3 years now. If we change it
now, in all likelihood we will break a number of scripts that rely on that
environment variable. So I think we need quite overwhelming evidence that
KERNEL_DIR is better before we introduce such breakage.
Angelo, you originally introduced KERNELDIR, anything to add to this discussion?
Regards,
Arnout
>
> Signed-off-by: Nayab Sayed <nayabbasha.sayed@microchip.com>
> ---
> package/environment-setup/environment-setup | 2 +-
> package/environment-setup/environment-setup.mk | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/environment-setup/environment-setup b/package/environment-setup/environment-setup
> index 84a9843c24..8504a89743 100644
> --- a/package/environment-setup/environment-setup
> +++ b/package/environment-setup/environment-setup
> @@ -10,7 +10,7 @@ cat <<'EOF'
> Some tips:
> * PATH now contains the SDK utilities
> * Standard autotools variables (CC, LD, CFLAGS) are exported
> -* Kernel compilation variables (ARCH, CROSS_COMPILE, KERNELDIR) are exported
> +* Kernel compilation variables (ARCH, CROSS_COMPILE, KERNEL_DIR) are exported
> * To configure do "./configure $CONFIGURE_FLAGS" or use
> the "configure" alias
> * To build CMake-based projects, use the "cmake" alias
> diff --git a/package/environment-setup/environment-setup.mk b/package/environment-setup/environment-setup.mk
> index 29ec5a9a95..cc058a5799 100644
> --- a/package/environment-setup/environment-setup.mk
> +++ b/package/environment-setup/environment-setup.mk
> @@ -34,7 +34,7 @@ define HOST_ENVIRONMENT_SETUP_INSTALL_CMDS
> >> $(ENVIRONMENT_SETUP_FILE)
>
> $(if $(BR2_LINUX_KERNEL),\
> - printf "export \"KERNELDIR=$(LINUX_BUILDDIR)\"\n" \
> + printf "export \"KERNEL_DIR=$(LINUX_BUILDDIR)\"\n" \
> >> $(ENVIRONMENT_SETUP_FILE),)
> endef
>
>
> ---
> base-commit: 04dfeff6242516a1061973fc7af2cc9c5e3dd4e2
> change-id: 20240124-kernel_dir-41a48fd97b75
>
> Best regards,
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/environment-setup: replace variable KERNELDIR with KERNEL_DIR
2024-01-30 20:02 ` Arnout Vandecappelle via buildroot
@ 2024-01-30 20:12 ` Angelo Compagnucci
2024-01-31 10:40 ` Nayab Sayed via buildroot
0 siblings, 1 reply; 4+ messages in thread
From: Angelo Compagnucci @ 2024-01-30 20:12 UTC (permalink / raw)
To: Arnout Vandecappelle; +Cc: Nayab Sayed, Angelo Compagnucci, buildroot
[-- Attachment #1.1: Type: text/plain, Size: 3281 bytes --]
Il mar 30 gen 2024, 21:03 Arnout Vandecappelle via buildroot <
buildroot@buildroot.org> ha scritto:
>
>
> On 24/01/2024 06:32, Nayab Sayed via buildroot wrote:
> > This commit updates the host environment setup helper script to use the
> more
> > conventional variable name KERNEL_DIR instead of KERNELDIR. The change
> is made
> > for consistency and to align with established conventions in the project
> (like
> > KERNEL_HOST, HOST_DIR etc.). No functional changes are introduced by this
> > commit.
>
> Do you have some evidence of this established convention?
>
> We currently have three external module packages that use KERNELDIR
> (falcosecurity-libs, ti-gfx and ti-sgx-km) and two that use KERNEL_DIR
> (kernel-module-imx-gpu-viv and gcnano-binaries).
>
>
> It has been KERNELDIR in Buildroot for more than 3 years now. If we
> change it
> now, in all likelihood we will break a number of scripts that rely on that
> environment variable. So I think we need quite overwhelming evidence that
> KERNEL_DIR is better before we introduce such breakage.
>
> Angelo, you originally introduced KERNELDIR, anything to add to this
> discussion?
>
I took it straight from the LDD3 kernel module makefile example.
Googling around, I cannot see a definitive answer, probably exporting both
could be a nice idea.
> Regards,
> Arnout
>
> >
> > Signed-off-by: Nayab Sayed <nayabbasha.sayed@microchip.com>
> > ---
> > package/environment-setup/environment-setup | 2 +-
> > package/environment-setup/environment-setup.mk | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/package/environment-setup/environment-setup
> b/package/environment-setup/environment-setup
> > index 84a9843c24..8504a89743 100644
> > --- a/package/environment-setup/environment-setup
> > +++ b/package/environment-setup/environment-setup
> > @@ -10,7 +10,7 @@ cat <<'EOF'
> > Some tips:
> > * PATH now contains the SDK utilities
> > * Standard autotools variables (CC, LD, CFLAGS) are exported
> > -* Kernel compilation variables (ARCH, CROSS_COMPILE, KERNELDIR) are
> exported
> > +* Kernel compilation variables (ARCH, CROSS_COMPILE, KERNEL_DIR) are
> exported
> > * To configure do "./configure $CONFIGURE_FLAGS" or use
> > the "configure" alias
> > * To build CMake-based projects, use the "cmake" alias
> > diff --git a/package/environment-setup/environment-setup.mk
> b/package/environment-setup/environment-setup.mk
> > index 29ec5a9a95..cc058a5799 100644
> > --- a/package/environment-setup/environment-setup.mk
> > +++ b/package/environment-setup/environment-setup.mk
> > @@ -34,7 +34,7 @@ define HOST_ENVIRONMENT_SETUP_INSTALL_CMDS
> > >> $(ENVIRONMENT_SETUP_FILE)
> >
> > $(if $(BR2_LINUX_KERNEL),\
> > - printf "export \"KERNELDIR=$(LINUX_BUILDDIR)\"\n" \
> > + printf "export \"KERNEL_DIR=$(LINUX_BUILDDIR)\"\n" \
> > >> $(ENVIRONMENT_SETUP_FILE),)
> > endef
> >
> >
> > ---
> > base-commit: 04dfeff6242516a1061973fc7af2cc9c5e3dd4e2
> > change-id: 20240124-kernel_dir-41a48fd97b75
> >
> > Best regards,
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
>
[-- Attachment #1.2: Type: text/html, Size: 5069 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/environment-setup: replace variable KERNELDIR with KERNEL_DIR
2024-01-30 20:12 ` Angelo Compagnucci
@ 2024-01-31 10:40 ` Nayab Sayed via buildroot
0 siblings, 0 replies; 4+ messages in thread
From: Nayab Sayed via buildroot @ 2024-01-31 10:40 UTC (permalink / raw)
To: angelo.compagnucci, arnout; +Cc: angelo, buildroot
On 31/01/24 01:42, Angelo Compagnucci wrote:
>
>
> You don't often get email from angelo.compagnucci@gmail.com. Learn why
> this is important <https://aka.ms/LearnAboutSenderIdentification>
>
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know
> the content is safe
>
>
> Il mar 30 gen 2024, 21:03 Arnout Vandecappelle via buildroot
> <buildroot@buildroot.org> ha scritto:
>
>
>
> On 24/01/2024 06:32, Nayab Sayed via buildroot wrote:
> > This commit updates the host environment setup helper script to
> use the more
> > conventional variable name KERNEL_DIR instead of KERNELDIR. The
> change is made
> > for consistency and to align with established conventions in the
> project (like
> > KERNEL_HOST, HOST_DIR etc.). No functional changes are
> introduced by this
> > commit.
>
> Do you have some evidence of this established convention?
>
> We currently have three external module packages that use KERNELDIR
> (falcosecurity-libs, ti-gfx and ti-sgx-km) and two that use
> KERNEL_DIR
> (kernel-module-imx-gpu-viv and gcnano-binaries).
>
>
> It has been KERNELDIR in Buildroot for more than 3 years now. If
> we change it
> now, in all likelihood we will break a number of scripts that rely
> on that
> environment variable. So I think we need quite overwhelming
> evidence that
> KERNEL_DIR is better before we introduce such breakage.
>
> Angelo, you originally introduced KERNELDIR, anything to add to
> this discussion?
>
>
> I took it straight from the LDD3 kernel module makefile example.
>
> Googling around, I cannot see a definitive answer, probably exporting
> both could be a nice idea.
I agree keeping both would be a nice idea. I will submit patch v2
accordingly.
>
>
> Regards,
> Arnout
>
> >
> > Signed-off-by: Nayab Sayed <nayabbasha.sayed@microchip.com>
> > ---
> > package/environment-setup/environment-setup | 2 +-
> > package/environment-setup/environment-setup.mk
> <http://environment-setup.mk> | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/package/environment-setup/environment-setup
> b/package/environment-setup/environment-setup
> > index 84a9843c24..8504a89743 100644
> > --- a/package/environment-setup/environment-setup
> > +++ b/package/environment-setup/environment-setup
> > @@ -10,7 +10,7 @@ cat <<'EOF'
> > Some tips:
> > * PATH now contains the SDK utilities
> > * Standard autotools variables (CC, LD, CFLAGS) are exported
> > -* Kernel compilation variables (ARCH, CROSS_COMPILE, KERNELDIR)
> are exported
> > +* Kernel compilation variables (ARCH, CROSS_COMPILE,
> KERNEL_DIR) are exported
> > * To configure do "./configure $CONFIGURE_FLAGS" or use
> > the "configure" alias
> > * To build CMake-based projects, use the "cmake" alias
> > diff --git a/package/environment-setup/environment-setup.mk
> <http://environment-setup.mk>
> b/package/environment-setup/environment-setup.mk
> <http://environment-setup.mk>
> > index 29ec5a9a95..cc058a5799 100644
> > --- a/package/environment-setup/environment-setup.mk
> <http://environment-setup.mk>
> > +++ b/package/environment-setup/environment-setup.mk
> <http://environment-setup.mk>
> > @@ -34,7 +34,7 @@ define HOST_ENVIRONMENT_SETUP_INSTALL_CMDS
> > >> $(ENVIRONMENT_SETUP_FILE)
> >
> > $(if $(BR2_LINUX_KERNEL),\
> > - printf "export \"KERNELDIR=$(LINUX_BUILDDIR)\"\n" \
> > + printf "export \"KERNEL_DIR=$(LINUX_BUILDDIR)\"\n" \
> > >> $(ENVIRONMENT_SETUP_FILE),)
> > endef
> >
> >
> > ---
> > base-commit: 04dfeff6242516a1061973fc7af2cc9c5e3dd4e2
> > change-id: 20240124-kernel_dir-41a48fd97b75
> >
> > Best regards,
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
>
--
Thanks,
Nayab
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-31 10:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-24 5:32 [Buildroot] [PATCH] package/environment-setup: replace variable KERNELDIR with KERNEL_DIR Nayab Sayed via buildroot
2024-01-30 20:02 ` Arnout Vandecappelle via buildroot
2024-01-30 20:12 ` Angelo Compagnucci
2024-01-31 10:40 ` Nayab Sayed via buildroot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.