From: Jakub Kicinski <kuba@kernel.org>
To: heng guo <heng.guo@windriver.com>
Cc: David Ahern <dsahern@gmail.com>,
Vitezslav Samel <vitezslav@samel.cz>,
netdev@vger.kernel.org
Subject: Re: [6.6.x REGRESSION][BISECTED] dev_snmp6: broken Ip6OutOctets accounting for forwarded IPv6 packets
Date: Wed, 24 Jan 2024 17:46:52 -0800 [thread overview]
Message-ID: <20240124174652.670af8d9@kernel.org> (raw)
In-Reply-To: <493d90b0-53f8-487e-8e0f-49f1dce65d58@windriver.com>
On Thu, 25 Jan 2024 08:37:11 +0800 heng guo wrote:
> >> Heng Guo, David, any thoughts on this? Revert?
> > Revert is best; Heng Guo can revisit the math and try again.
> >
> > The patch in question basically negated IPSTATS_MIB_OUTOCTETS; I see it
> > shown in proc but never bumped in the datapath.
> [HG]: Yes please revert it. I verified the patch on ipv4, seems I should
> not touch the codes to ipv6. Sorry for it.
Would you mind sending a patch with a revert, explaining the situation,
the right Fixes tag and a link to Vitezslav's report?
next prev parent reply other threads:[~2024-01-25 1:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-20 9:23 [6.6.x REGRESSION][BISECTED] dev_snmp6: broken Ip6OutOctets accounting for forwarded IPv6 packets Vitezslav Samel
2024-01-24 20:30 ` Jakub Kicinski
2024-01-24 21:55 ` David Ahern
2024-01-25 0:37 ` heng guo
2024-01-25 1:46 ` Jakub Kicinski [this message]
2024-01-25 6:47 ` Vitezslav Samel
2024-01-25 15:08 ` Vitezslav Samel
2024-01-25 18:20 ` David Ahern
2024-03-05 14:38 ` fix IPSTATS_MIB_OUTOCTETS for IPv6 in stable-6.6.x Vitezslav Samel
2024-03-27 14:37 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240124174652.670af8d9@kernel.org \
--to=kuba@kernel.org \
--cc=dsahern@gmail.com \
--cc=heng.guo@windriver.com \
--cc=netdev@vger.kernel.org \
--cc=vitezslav@samel.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.