From: Simon Horman <horms@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: remove duplicate comment
Date: Wed, 24 Jan 2024 21:26:54 +0000 [thread overview]
Message-ID: <20240124212654.GA348897@kernel.org> (raw)
In-Reply-To: <20240122182419.889727-1-anthony.l.nguyen@intel.com>
On Mon, Jan 22, 2024 at 10:24:17AM -0800, Tony Nguyen wrote:
> From: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
>
> Remove a comment that was not correct; this structure has nothing
> to do with FW alignment.
>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Sure, but the subject doesn't seem to match the patch description.
And, Tony, your Sob seems to be missing.
> ---
> drivers/net/ethernet/intel/ice/ice_debugfs.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_debugfs.c b/drivers/net/ethernet/intel/ice/ice_debugfs.c
> index c2bfba6b9ead..85aa31dd86b1 100644
> --- a/drivers/net/ethernet/intel/ice/ice_debugfs.c
> +++ b/drivers/net/ethernet/intel/ice/ice_debugfs.c
> @@ -64,9 +64,6 @@ static const char * const ice_fwlog_level_string[] = {
> "verbose",
> };
>
> -/* the order in this array is important. it matches the ordering of the
> - * values in the FW so the index is the same value as in ice_fwlog_level
> - */
> static const char * const ice_fwlog_log_size[] = {
> "128K",
> "256K",
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: intel-wired-lan@lists.osuosl.org,
Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>,
netdev@vger.kernel.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH iwl-next] ice: remove duplicate comment
Date: Wed, 24 Jan 2024 21:26:54 +0000 [thread overview]
Message-ID: <20240124212654.GA348897@kernel.org> (raw)
In-Reply-To: <20240122182419.889727-1-anthony.l.nguyen@intel.com>
On Mon, Jan 22, 2024 at 10:24:17AM -0800, Tony Nguyen wrote:
> From: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
>
> Remove a comment that was not correct; this structure has nothing
> to do with FW alignment.
>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Sure, but the subject doesn't seem to match the patch description.
And, Tony, your Sob seems to be missing.
> ---
> drivers/net/ethernet/intel/ice/ice_debugfs.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_debugfs.c b/drivers/net/ethernet/intel/ice/ice_debugfs.c
> index c2bfba6b9ead..85aa31dd86b1 100644
> --- a/drivers/net/ethernet/intel/ice/ice_debugfs.c
> +++ b/drivers/net/ethernet/intel/ice/ice_debugfs.c
> @@ -64,9 +64,6 @@ static const char * const ice_fwlog_level_string[] = {
> "verbose",
> };
>
> -/* the order in this array is important. it matches the ordering of the
> - * values in the FW so the index is the same value as in ice_fwlog_level
> - */
> static const char * const ice_fwlog_log_size[] = {
> "128K",
> "256K",
next prev parent reply other threads:[~2024-01-24 21:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 18:24 [Intel-wired-lan] [PATCH iwl-next] ice: remove duplicate comment Tony Nguyen
2024-01-22 18:24 ` Tony Nguyen
2024-01-24 21:26 ` Simon Horman [this message]
2024-01-24 21:26 ` Simon Horman
2024-01-25 17:26 ` [Intel-wired-lan] " Tony Nguyen
2024-01-25 17:26 ` Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240124212654.GA348897@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=paul.m.stillwell.jr@intel.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.