All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Emil Velikov <emil.velikov@collabora.com>
Subject: [PATCH BlueZ v3 4/8] bluetoothd: convert external sixaxis plugin to builtin
Date: Thu, 25 Jan 2024 00:07:29 +0000	[thread overview]
Message-ID: <20240125-rm-ext-plugins-v3-4-d141f7870bb6@gmail.com> (raw)
In-Reply-To: <20240125-rm-ext-plugins-v3-0-d141f7870bb6@gmail.com>

From: Emil Velikov <emil.velikov@collabora.com>

Convert the only known external plugin to built-in. It's a tiny 20K
binary that distros ship a separate package for.

Make it a builtin, which allows distros to drop the separate package, it
also enables us to compile out support for external modules - both in
terms of extra code and hide the internal bluetoothd API.

This means that libudev.so is pulled in, which is fine since its ABI has
been stable for over a decade.
---
 Makefile.plugins | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/Makefile.plugins b/Makefile.plugins
index 5880ed0df..7cf66fd59 100644
--- a/Makefile.plugins
+++ b/Makefile.plugins
@@ -110,11 +110,9 @@ builtin_modules += battery
 builtin_sources += profiles/battery/battery.c
 
 if SIXAXIS
-plugin_LTLIBRARIES += plugins/sixaxis.la
-plugins_sixaxis_la_SOURCES = plugins/sixaxis.c
-plugins_sixaxis_la_LDFLAGS = $(AM_LDFLAGS) -module -avoid-version
-plugins_sixaxis_la_LIBADD = $(UDEV_LIBS)
-plugins_sixaxis_la_CFLAGS = $(AM_CFLAGS) -fvisibility=hidden
+builtin_modules += sixaxis
+builtin_sources += plugins/sixaxis.c
+builtin_ldadd += $(UDEV_LIBS)
 endif
 
 if BAP

-- 
2.43.0


WARNING: multiple messages have this Message-ID (diff)
From: Emil Velikov via B4 Relay <devnull+emil.l.velikov.gmail.com@kernel.org>
To: linux-bluetooth@vger.kernel.org
Cc: Emil Velikov <emil.velikov@collabora.com>
Subject: [PATCH BlueZ v3 4/8] bluetoothd: convert external sixaxis plugin to builtin
Date: Thu, 25 Jan 2024 00:07:29 +0000	[thread overview]
Message-ID: <20240125-rm-ext-plugins-v3-4-d141f7870bb6@gmail.com> (raw)
In-Reply-To: <20240125-rm-ext-plugins-v3-0-d141f7870bb6@gmail.com>

From: Emil Velikov <emil.velikov@collabora.com>

Convert the only known external plugin to built-in. It's a tiny 20K
binary that distros ship a separate package for.

Make it a builtin, which allows distros to drop the separate package, it
also enables us to compile out support for external modules - both in
terms of extra code and hide the internal bluetoothd API.

This means that libudev.so is pulled in, which is fine since its ABI has
been stable for over a decade.
---
 Makefile.plugins | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/Makefile.plugins b/Makefile.plugins
index 5880ed0df..7cf66fd59 100644
--- a/Makefile.plugins
+++ b/Makefile.plugins
@@ -110,11 +110,9 @@ builtin_modules += battery
 builtin_sources += profiles/battery/battery.c
 
 if SIXAXIS
-plugin_LTLIBRARIES += plugins/sixaxis.la
-plugins_sixaxis_la_SOURCES = plugins/sixaxis.c
-plugins_sixaxis_la_LDFLAGS = $(AM_LDFLAGS) -module -avoid-version
-plugins_sixaxis_la_LIBADD = $(UDEV_LIBS)
-plugins_sixaxis_la_CFLAGS = $(AM_CFLAGS) -fvisibility=hidden
+builtin_modules += sixaxis
+builtin_sources += plugins/sixaxis.c
+builtin_ldadd += $(UDEV_LIBS)
 endif
 
 if BAP

-- 
2.43.0


  parent reply	other threads:[~2024-01-25  0:07 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25  0:07 [PATCH BlueZ v3 0/8] Remove support for external plugins Emil Velikov
2024-01-25  0:07 ` Emil Velikov via B4 Relay
2024-01-25  0:07 ` [PATCH BlueZ v3 1/8] configure, README: introduce --enable-external-plugins Emil Velikov
2024-01-25  0:07   ` Emil Velikov via B4 Relay
2024-01-25  3:15   ` Remove support for external plugins bluez.test.bot
2024-01-25  0:07 ` [PATCH BlueZ v3 2/8] obexd: factor out external plugin support Emil Velikov
2024-01-25  0:07   ` Emil Velikov via B4 Relay
2024-01-26 18:50   ` Luiz Augusto von Dentz
2024-01-29 14:48     ` Emil Velikov
2024-01-25  0:07 ` [PATCH BlueZ v3 3/8] bluetoothd: remove external-dummy plugin Emil Velikov
2024-01-25  0:07   ` Emil Velikov via B4 Relay
2024-01-25  0:07 ` Emil Velikov [this message]
2024-01-25  0:07   ` [PATCH BlueZ v3 4/8] bluetoothd: convert external sixaxis plugin to builtin Emil Velikov via B4 Relay
2024-01-25  0:07 ` [PATCH BlueZ v3 5/8] bluetoothd: factor out external plugin support Emil Velikov
2024-01-25  0:07   ` Emil Velikov via B4 Relay
2024-01-25  0:07 ` [PATCH BlueZ v3 6/8] bluetoothd: don't export internal API Emil Velikov
2024-01-25  0:07   ` Emil Velikov via B4 Relay
2024-01-25  0:07 ` [PATCH BlueZ v3 7/8] bluetoothd: change plugin loading alike obexd Emil Velikov
2024-01-25  0:07   ` Emil Velikov via B4 Relay
2024-01-25  0:07 ` [PATCH BlueZ v3 8/8] android: export only (android) entrypoint from the modules Emil Velikov
2024-01-25  0:07   ` Emil Velikov via B4 Relay
2024-01-25 13:02 ` [PATCH BlueZ v3 0/8] Remove support for external plugins Szymon Janc
2024-01-25 13:48   ` Emil Velikov
2024-01-25 18:30     ` Luiz Augusto von Dentz
2024-01-26 15:43       ` Emil Velikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240125-rm-ext-plugins-v3-4-d141f7870bb6@gmail.com \
    --to=emil.l.velikov@gmail.com \
    --cc=emil.velikov@collabora.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.