* Re: [PATCH v2 3/8] power: reset: Introduce PSCR Recording Framework for Non-Volatile Storage
@ 2024-01-27 23:31 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2024-01-27 23:31 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp
::::::
:::::: Manual check reason: "low confidence static check warning: drivers/power/reset/pscrr.c:132:9: sparse: sparse: statement expected after case label"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20240124122204.730370-4-o.rempel@pengutronix.de>
References: <20240124122204.730370-4-o.rempel@pengutronix.de>
TO: Oleksij Rempel <o.rempel@pengutronix.de>
TO: Sebastian Reichel <sre@kernel.org>
TO: Rob Herring <robh+dt@kernel.org>
TO: Krzysztof Kozlowski <krzk@kernel.org>
TO: Conor Dooley <conor+dt@kernel.org>
TO: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
CC: Oleksij Rempel <o.rempel@pengutronix.de>
CC: kernel@pengutronix.de
CC: linux-kernel@vger.kernel.org
CC: Liam Girdwood <lgirdwood@gmail.com>
CC: Mark Brown <broonie@kernel.org>
CC: "Rafael J. Wysocki" <rafael@kernel.org>
CC: Daniel Lezcano <daniel.lezcano@linaro.org>
CC: Zhang Rui <rui.zhang@intel.com>
CC: Lukasz Luba <lukasz.luba@arm.com>
CC: linux-pm@vger.kernel.org
CC: devicetree@vger.kernel.org
CC: "Søren Andersen" <san@skov.dk>
Hi Oleksij,
kernel test robot noticed the following build warnings:
[auto build test WARNING on robh/for-next]
[also build test WARNING on broonie-regulator/for-next rafael-pm/thermal linus/master v6.8-rc1 next-20240125]
[cannot apply to sre-power-supply/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Oleksij-Rempel/power-Extend-power_on_reason-h-for-upcoming-PSCRR-framework/20240124-202833
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20240124122204.730370-4-o.rempel%40pengutronix.de
patch subject: [PATCH v2 3/8] power: reset: Introduce PSCR Recording Framework for Non-Volatile Storage
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: i386-randconfig-062-20240128 (https://download.01.org/0day-ci/archive/20240128/202401280712.O6FEvsAC-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240128/202401280712.O6FEvsAC-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202401280712.O6FEvsAC-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> drivers/power/reset/pscrr.c:132:9: sparse: sparse: statement expected after case label
>> drivers/power/reset/pscrr.c:20:11: sparse: sparse: symbol 'system_pscr' was not declared. Should it be static?
>> drivers/power/reset/pscrr.c:57:17: sparse: sparse: symbol 'pscr_map_table' was not declared. Should it be static?
drivers/power/reset/pscrr.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/xarray.h, ...):
include/linux/page-flags.h:242:46: sparse: sparse: self-comparison always evaluates to false
vim +132 drivers/power/reset/pscrr.c
3f484eec6730bd Oleksij Rempel 2024-01-24 19
3f484eec6730bd Oleksij Rempel 2024-01-24 @20 enum pscr system_pscr;
3f484eec6730bd Oleksij Rempel 2024-01-24 21
3f484eec6730bd Oleksij Rempel 2024-01-24 22 /*
3f484eec6730bd Oleksij Rempel 2024-01-24 23 * struct pscr_to_magic_entry - Entry for mapping PSCR to magic values.
3f484eec6730bd Oleksij Rempel 2024-01-24 24 *
3f484eec6730bd Oleksij Rempel 2024-01-24 25 * This structure represents a single entry in a list that maps Power State
3f484eec6730bd Oleksij Rempel 2024-01-24 26 * Change Reason (PSCR) values to corresponding magic values. Each entry
3f484eec6730bd Oleksij Rempel 2024-01-24 27 * associates a specific PSCR with a unique magic value, facilitating easy
3f484eec6730bd Oleksij Rempel 2024-01-24 28 * translation between the two.
3f484eec6730bd Oleksij Rempel 2024-01-24 29 *
3f484eec6730bd Oleksij Rempel 2024-01-24 30 * @pscr: The PSCR value.
3f484eec6730bd Oleksij Rempel 2024-01-24 31 * @magic: The corresponding magic value.
3f484eec6730bd Oleksij Rempel 2024-01-24 32 * @list: List head for chaining multiple such entries.
3f484eec6730bd Oleksij Rempel 2024-01-24 33 */
3f484eec6730bd Oleksij Rempel 2024-01-24 34 struct pscr_to_magic_entry {
3f484eec6730bd Oleksij Rempel 2024-01-24 35 enum pscr pscr;
3f484eec6730bd Oleksij Rempel 2024-01-24 36 u32 magic;
3f484eec6730bd Oleksij Rempel 2024-01-24 37 struct list_head list;
3f484eec6730bd Oleksij Rempel 2024-01-24 38 };
3f484eec6730bd Oleksij Rempel 2024-01-24 39
3f484eec6730bd Oleksij Rempel 2024-01-24 40 /*
3f484eec6730bd Oleksij Rempel 2024-01-24 41 * struct pscr_map - Maps device tree property names to PSCR values.
3f484eec6730bd Oleksij Rempel 2024-01-24 42 *
3f484eec6730bd Oleksij Rempel 2024-01-24 43 * @dt_prop_name: Device tree property name without the "pscr-" prefix.
3f484eec6730bd Oleksij Rempel 2024-01-24 44 * @pscr: The corresponding PSCR enum value for the given property name.
3f484eec6730bd Oleksij Rempel 2024-01-24 45 */
3f484eec6730bd Oleksij Rempel 2024-01-24 46 struct pscr_map {
3f484eec6730bd Oleksij Rempel 2024-01-24 47 const char *dt_prop_name;
3f484eec6730bd Oleksij Rempel 2024-01-24 48 enum pscr pscr;
3f484eec6730bd Oleksij Rempel 2024-01-24 49 };
3f484eec6730bd Oleksij Rempel 2024-01-24 50
3f484eec6730bd Oleksij Rempel 2024-01-24 51 /*
3f484eec6730bd Oleksij Rempel 2024-01-24 52 * struct pscr_map - Maps shortened DT property names to PSCR values.
3f484eec6730bd Oleksij Rempel 2024-01-24 53 *
3f484eec6730bd Oleksij Rempel 2024-01-24 54 * This structure maps device tree property names, with the "pscr-" prefix
3f484eec6730bd Oleksij Rempel 2024-01-24 55 * omitted, to their corresponding Power State Change Reason (PSCR) values.
3f484eec6730bd Oleksij Rempel 2024-01-24 56 */
3f484eec6730bd Oleksij Rempel 2024-01-24 @57 struct pscr_map pscr_map_table[] = {
3f484eec6730bd Oleksij Rempel 2024-01-24 58 { "under-voltage", PSCR_UNDER_VOLTAGE },
3f484eec6730bd Oleksij Rempel 2024-01-24 59 { "over-current", PSCR_OVER_CURRENT },
3f484eec6730bd Oleksij Rempel 2024-01-24 60 { "regulator-failure", PSCR_REGULATOR_FAILURE },
3f484eec6730bd Oleksij Rempel 2024-01-24 61 { "over-temperature", PSCR_OVERTEMPERATURE },
3f484eec6730bd Oleksij Rempel 2024-01-24 62 };
3f484eec6730bd Oleksij Rempel 2024-01-24 63
3f484eec6730bd Oleksij Rempel 2024-01-24 64 /*
3f484eec6730bd Oleksij Rempel 2024-01-24 65 * pscr_find_from_dt_name - Finds the PSCR value for a given DT property name.
3f484eec6730bd Oleksij Rempel 2024-01-24 66 *
3f484eec6730bd Oleksij Rempel 2024-01-24 67 * @dt_prop_name: The device tree property name, without the "pscr-" prefix, to
3f484eec6730bd Oleksij Rempel 2024-01-24 68 * look up.
3f484eec6730bd Oleksij Rempel 2024-01-24 69 * Returns the corresponding PSCR value or -ENOENT if not found.
3f484eec6730bd Oleksij Rempel 2024-01-24 70 */
3f484eec6730bd Oleksij Rempel 2024-01-24 71 static int find_pscr_by_string(const char *dt_prop_name)
3f484eec6730bd Oleksij Rempel 2024-01-24 72 {
3f484eec6730bd Oleksij Rempel 2024-01-24 73 int i;
3f484eec6730bd Oleksij Rempel 2024-01-24 74
3f484eec6730bd Oleksij Rempel 2024-01-24 75 for (i = 0; i < ARRAY_SIZE(pscr_map_table); i++) {
3f484eec6730bd Oleksij Rempel 2024-01-24 76 if (!strcmp(dt_prop_name, pscr_map_table[i].dt_prop_name))
3f484eec6730bd Oleksij Rempel 2024-01-24 77 return pscr_map_table[i].pscr;
3f484eec6730bd Oleksij Rempel 2024-01-24 78 }
3f484eec6730bd Oleksij Rempel 2024-01-24 79
3f484eec6730bd Oleksij Rempel 2024-01-24 80 return -ENOENT;
3f484eec6730bd Oleksij Rempel 2024-01-24 81 }
3f484eec6730bd Oleksij Rempel 2024-01-24 82
3f484eec6730bd Oleksij Rempel 2024-01-24 83 static enum pscr get_pscr_by_magic(struct pscrr_device *pscrr_dev, u32 magic)
3f484eec6730bd Oleksij Rempel 2024-01-24 84 {
3f484eec6730bd Oleksij Rempel 2024-01-24 85 struct pscr_to_magic_entry *map_entry;
3f484eec6730bd Oleksij Rempel 2024-01-24 86
3f484eec6730bd Oleksij Rempel 2024-01-24 87 list_for_each_entry(map_entry, &pscrr_dev->pscr_map_list, list) {
3f484eec6730bd Oleksij Rempel 2024-01-24 88 if (map_entry->magic == magic)
3f484eec6730bd Oleksij Rempel 2024-01-24 89 return map_entry->pscr;
3f484eec6730bd Oleksij Rempel 2024-01-24 90 }
3f484eec6730bd Oleksij Rempel 2024-01-24 91
3f484eec6730bd Oleksij Rempel 2024-01-24 92 return 0;
3f484eec6730bd Oleksij Rempel 2024-01-24 93 }
3f484eec6730bd Oleksij Rempel 2024-01-24 94
3f484eec6730bd Oleksij Rempel 2024-01-24 95 static u32 get_magic_by_pscr(struct pscrr_device *pscrr_dev, enum pscr pscr)
3f484eec6730bd Oleksij Rempel 2024-01-24 96 {
3f484eec6730bd Oleksij Rempel 2024-01-24 97 struct pscr_to_magic_entry *map_entry;
3f484eec6730bd Oleksij Rempel 2024-01-24 98
3f484eec6730bd Oleksij Rempel 2024-01-24 99 list_for_each_entry(map_entry, &pscrr_dev->pscr_map_list, list) {
3f484eec6730bd Oleksij Rempel 2024-01-24 100 if (map_entry->pscr == pscr)
3f484eec6730bd Oleksij Rempel 2024-01-24 101 return map_entry->magic;
3f484eec6730bd Oleksij Rempel 2024-01-24 102 }
3f484eec6730bd Oleksij Rempel 2024-01-24 103
3f484eec6730bd Oleksij Rempel 2024-01-24 104 return 0;
3f484eec6730bd Oleksij Rempel 2024-01-24 105 }
3f484eec6730bd Oleksij Rempel 2024-01-24 106
3f484eec6730bd Oleksij Rempel 2024-01-24 107 /**
3f484eec6730bd Oleksij Rempel 2024-01-24 108 * set_power_state_change_reason() - Set the system's power state change reason
3f484eec6730bd Oleksij Rempel 2024-01-24 109 * @pscr: The enum value representing the power state change reason
3f484eec6730bd Oleksij Rempel 2024-01-24 110 *
3f484eec6730bd Oleksij Rempel 2024-01-24 111 * This function sets the system's power state change reason based on the
3f484eec6730bd Oleksij Rempel 2024-01-24 112 * provided enum value.
3f484eec6730bd Oleksij Rempel 2024-01-24 113 */
3f484eec6730bd Oleksij Rempel 2024-01-24 114 void set_power_state_change_reason(enum pscr pscr)
3f484eec6730bd Oleksij Rempel 2024-01-24 115 {
3f484eec6730bd Oleksij Rempel 2024-01-24 116 system_pscr = pscr;
3f484eec6730bd Oleksij Rempel 2024-01-24 117 }
3f484eec6730bd Oleksij Rempel 2024-01-24 118 EXPORT_SYMBOL_GPL(set_power_state_change_reason);
3f484eec6730bd Oleksij Rempel 2024-01-24 119
3f484eec6730bd Oleksij Rempel 2024-01-24 120 static const char *pscr_to_por_string(enum pscr pscr)
3f484eec6730bd Oleksij Rempel 2024-01-24 121 {
3f484eec6730bd Oleksij Rempel 2024-01-24 122 switch (pscr) {
3f484eec6730bd Oleksij Rempel 2024-01-24 123 case PSCR_UNDER_VOLTAGE:
3f484eec6730bd Oleksij Rempel 2024-01-24 124 return POWER_ON_REASON_BROWN_OUT;
3f484eec6730bd Oleksij Rempel 2024-01-24 125 case PSCR_OVER_CURRENT:
3f484eec6730bd Oleksij Rempel 2024-01-24 126 return POWER_ON_REASON_OVER_CURRENT;
3f484eec6730bd Oleksij Rempel 2024-01-24 127 case PSCR_REGULATOR_FAILURE:
3f484eec6730bd Oleksij Rempel 2024-01-24 128 return POWER_ON_REASON_REGULATOR_FAILURE;
3f484eec6730bd Oleksij Rempel 2024-01-24 129 case PSCR_OVERTEMPERATURE:
3f484eec6730bd Oleksij Rempel 2024-01-24 130 return POWER_ON_REASON_OVERTEMPERATURE;
3f484eec6730bd Oleksij Rempel 2024-01-24 131 default:
3f484eec6730bd Oleksij Rempel 2024-01-24 @132 }
3f484eec6730bd Oleksij Rempel 2024-01-24 133
3f484eec6730bd Oleksij Rempel 2024-01-24 134 return POWER_ON_REASON_UNKNOWN;
3f484eec6730bd Oleksij Rempel 2024-01-24 135 }
3f484eec6730bd Oleksij Rempel 2024-01-24 136
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread* [RFC PATCH v1 0/8] Introduction of PSCR Framework and Related Components
@ 2024-01-24 12:21 Oleksij Rempel
2024-01-24 12:21 ` [PATCH v2 3/8] power: reset: Introduce PSCR Recording Framework for Non-Volatile Storage Oleksij Rempel
0 siblings, 1 reply; 3+ messages in thread
From: Oleksij Rempel @ 2024-01-24 12:21 UTC (permalink / raw)
To: Sebastian Reichel, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla
Cc: Oleksij Rempel, kernel, linux-kernel, Liam Girdwood, Mark Brown,
Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
linux-pm, devicetree, Søren Andersen
changes v2:
- rename the framework from PSCR to PSCRR (last R is for Recorder)
- extend power on reason header and use it to show detected reason on
system start and in sysfs.
- remove "unknow" reason
- rebase on top of v6.8-rc1
- yaml fixes
- zero reason state on boot
Hello all,
This patch series introduces the Power State Change Reasons (PSCR)
tracking framework and its related components into the kernel. The PSCR
framework is designed for systems where traditional methods of storing
power state change reasons, like PMICs or watchdogs, are inadequate. It
provides a structured way to store reasons for system shutdowns and
reboots, such as under-voltage or software-triggered events, in
non-volatile hardware storage.
These changes are critical for systems requiring detailed postmortem
analysis and where immediate power-down scenarios limit traditional
storage options. The framework also assists bootloaders and early-stage
system components in making informed recovery decisions.
Oleksij Rempel (8):
power: Extend power_on_reason.h for upcoming PSCRR framework
dt-bindings: power: reset: add generic PSCRR binding trackers
power: reset: Introduce PSCR Recording Framework for Non-Volatile
Storage
dt-bindings: power: reset: add bindings for NVMEM hardware storing
PSCR Data
nvmem: provide consumer access to cell size metrics
power: reset: add PSCR NVMEM Driver for Recording Power State Change
Reasons
regulator: set Power State Change Reason before
hw_protection_shutdown()
thermal: core: Record PSCR before hw_protection_shutdown()
.../bindings/power/reset/pscrr-nvmem.yaml | 53 +++
.../bindings/power/reset/pscrr.yaml | 44 +++
drivers/nvmem/core.c | 25 ++
drivers/power/reset/Kconfig | 30 ++
drivers/power/reset/Makefile | 2 +
drivers/power/reset/pscrr-nvmem.c | 121 ++++++
drivers/power/reset/pscrr.c | 353 ++++++++++++++++++
drivers/regulator/core.c | 6 +
drivers/thermal/thermal_core.c | 3 +
include/linux/nvmem-consumer.h | 7 +
include/linux/power/power_on_reason.h | 3 +
include/linux/pscrr.h | 73 ++++
12 files changed, 720 insertions(+)
create mode 100644 Documentation/devicetree/bindings/power/reset/pscrr-nvmem.yaml
create mode 100644 Documentation/devicetree/bindings/power/reset/pscrr.yaml
create mode 100644 drivers/power/reset/pscrr-nvmem.c
create mode 100644 drivers/power/reset/pscrr.c
create mode 100644 include/linux/pscrr.h
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v2 3/8] power: reset: Introduce PSCR Recording Framework for Non-Volatile Storage 2024-01-24 12:21 [RFC PATCH v1 0/8] Introduction of PSCR Framework and Related Components Oleksij Rempel @ 2024-01-24 12:21 ` Oleksij Rempel 2024-01-28 9:05 ` kernel test robot 0 siblings, 1 reply; 3+ messages in thread From: Oleksij Rempel @ 2024-01-24 12:21 UTC (permalink / raw) To: Sebastian Reichel, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla Cc: Oleksij Rempel, kernel, linux-kernel, Liam Girdwood, Mark Brown, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, linux-pm, devicetree, Søren Andersen This commit introduces the Power State Change Reasons Recording (PSCRR) framework into the kernel. The framework is vital for systems where PMICs or watchdogs cannot provide information on power state changes. It stores reasons for system shutdowns and reboots, like under-voltage or software-triggered events, in non-volatile hardware storage. This approach is essential for postmortem analysis in scenarios where traditional storage methods (block devices, RAM) are not feasible. The framework aids bootloaders and early-stage system components in recovery decision-making, although it does not cover resets caused by hardware issues like system freezes or watchdog timeouts. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- drivers/power/reset/Kconfig | 19 ++ drivers/power/reset/Makefile | 1 + drivers/power/reset/pscrr.c | 353 +++++++++++++++++++++++++++++++++++ include/linux/pscrr.h | 73 ++++++++ 4 files changed, 446 insertions(+) create mode 100644 drivers/power/reset/pscrr.c create mode 100644 include/linux/pscrr.h diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig index fece990af4a7..c6ce7e647048 100644 --- a/drivers/power/reset/Kconfig +++ b/drivers/power/reset/Kconfig @@ -305,3 +305,22 @@ config POWER_MLXBF This driver supports reset or low power mode handling for Mellanox BlueField. endif + +menuconfig PSCRR + bool "Power State Change Reasons (PSCR) Recording Framework" + help + Enables the Power State Change Reasons (PSCR) Recording framework. + + This framework is designed to store reasons for system shutdowns or + reboots, like under voltage or software-triggered events, in non-volatile + hardware storage. It is particularly useful for postmortem analysis, where + traditional storage methods (like block devices or RAM) are not feasible + due to immediate power-down requirements or insufficient power to retain + data. + + This is useful for bootloaders or other early-stage system components to + make recovery decisions based on the last known system state. Note that it + does not cover hardware-induced resets like system freezes or watchdog + timeouts. + + If unsure, say N. diff --git a/drivers/power/reset/Makefile b/drivers/power/reset/Makefile index a95d1bd275d1..e618c34a30f9 100644 --- a/drivers/power/reset/Makefile +++ b/drivers/power/reset/Makefile @@ -31,6 +31,7 @@ obj-$(CONFIG_POWER_RESET_KEYSTONE) += keystone-reset.o obj-$(CONFIG_POWER_RESET_SYSCON) += syscon-reboot.o obj-$(CONFIG_POWER_RESET_SYSCON_POWEROFF) += syscon-poweroff.o obj-$(CONFIG_POWER_RESET_RMOBILE) += rmobile-reset.o +obj-$(CONFIG_PSCRR) += pscrr.o obj-$(CONFIG_REBOOT_MODE) += reboot-mode.o obj-$(CONFIG_SYSCON_REBOOT_MODE) += syscon-reboot-mode.o obj-$(CONFIG_POWER_RESET_SC27XX) += sc27xx-poweroff.o diff --git a/drivers/power/reset/pscrr.c b/drivers/power/reset/pscrr.c new file mode 100644 index 000000000000..651fc210878d --- /dev/null +++ b/drivers/power/reset/pscrr.c @@ -0,0 +1,353 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (C) 2016, Fuzhou Rockchip Electronics Co., Ltd +// Copyright (c) 2024 Pengutronix, Oleksij Rempel <kernel@pengutronix.de> +/* + * Based on drivers/power/reset/reboot-mode.c + * Copyright (c) 2016, Fuzhou Rockchip Electronics Co., Ltd + */ + +#include <linux/device.h> +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/power/power_on_reason.h> +#include <linux/pscrr.h> +#include <linux/reboot.h> + +#define PREFIX "pscr-" + +enum pscr system_pscr; + +/* + * struct pscr_to_magic_entry - Entry for mapping PSCR to magic values. + * + * This structure represents a single entry in a list that maps Power State + * Change Reason (PSCR) values to corresponding magic values. Each entry + * associates a specific PSCR with a unique magic value, facilitating easy + * translation between the two. + * + * @pscr: The PSCR value. + * @magic: The corresponding magic value. + * @list: List head for chaining multiple such entries. + */ +struct pscr_to_magic_entry { + enum pscr pscr; + u32 magic; + struct list_head list; +}; + +/* + * struct pscr_map - Maps device tree property names to PSCR values. + * + * @dt_prop_name: Device tree property name without the "pscr-" prefix. + * @pscr: The corresponding PSCR enum value for the given property name. + */ +struct pscr_map { + const char *dt_prop_name; + enum pscr pscr; +}; + +/* + * struct pscr_map - Maps shortened DT property names to PSCR values. + * + * This structure maps device tree property names, with the "pscr-" prefix + * omitted, to their corresponding Power State Change Reason (PSCR) values. + */ +struct pscr_map pscr_map_table[] = { + { "under-voltage", PSCR_UNDER_VOLTAGE }, + { "over-current", PSCR_OVER_CURRENT }, + { "regulator-failure", PSCR_REGULATOR_FAILURE }, + { "over-temperature", PSCR_OVERTEMPERATURE }, +}; + +/* + * pscr_find_from_dt_name - Finds the PSCR value for a given DT property name. + * + * @dt_prop_name: The device tree property name, without the "pscr-" prefix, to + * look up. + * Returns the corresponding PSCR value or -ENOENT if not found. + */ +static int find_pscr_by_string(const char *dt_prop_name) +{ + int i; + + for (i = 0; i < ARRAY_SIZE(pscr_map_table); i++) { + if (!strcmp(dt_prop_name, pscr_map_table[i].dt_prop_name)) + return pscr_map_table[i].pscr; + } + + return -ENOENT; +} + +static enum pscr get_pscr_by_magic(struct pscrr_device *pscrr_dev, u32 magic) +{ + struct pscr_to_magic_entry *map_entry; + + list_for_each_entry(map_entry, &pscrr_dev->pscr_map_list, list) { + if (map_entry->magic == magic) + return map_entry->pscr; + } + + return 0; +} + +static u32 get_magic_by_pscr(struct pscrr_device *pscrr_dev, enum pscr pscr) +{ + struct pscr_to_magic_entry *map_entry; + + list_for_each_entry(map_entry, &pscrr_dev->pscr_map_list, list) { + if (map_entry->pscr == pscr) + return map_entry->magic; + } + + return 0; +} + +/** + * set_power_state_change_reason() - Set the system's power state change reason + * @pscr: The enum value representing the power state change reason + * + * This function sets the system's power state change reason based on the + * provided enum value. + */ +void set_power_state_change_reason(enum pscr pscr) +{ + system_pscr = pscr; +} +EXPORT_SYMBOL_GPL(set_power_state_change_reason); + +static const char *pscr_to_por_string(enum pscr pscr) +{ + switch (pscr) { + case PSCR_UNDER_VOLTAGE: + return POWER_ON_REASON_BROWN_OUT; + case PSCR_OVER_CURRENT: + return POWER_ON_REASON_OVER_CURRENT; + case PSCR_REGULATOR_FAILURE: + return POWER_ON_REASON_REGULATOR_FAILURE; + case PSCR_OVERTEMPERATURE: + return POWER_ON_REASON_OVERTEMPERATURE; + default: + } + + return POWER_ON_REASON_UNKNOWN; +} + +static ssize_t power_state_change_reason_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct pscrr_device *pscrr_dev = dev_get_drvdata(dev); + + return sprintf(buf, "%s\n", pscr_to_por_string(pscrr_dev->last_pscr)); +} +static DEVICE_ATTR_RO(power_state_change_reason); + +int handle_last_pscr(struct pscrr_device *pscrr_dev) +{ + u32 magic; + int ret; + + ret = pscrr_dev->read(pscrr_dev, &magic); + if (ret) + return ret; + + pscrr_dev->last_pscr = get_pscr_by_magic(pscrr_dev, magic); + + dev_info(pscrr_dev->dev, "Last recorded power state change reason: %s\n", + pscr_to_por_string(pscrr_dev->last_pscr)); + + ret = pscrr_dev->write(pscrr_dev, 0); + if (ret) + dev_err(pscrr_dev->dev, "Failed to clear power state change reason\n"); + + return ret; +} + +static int pscrr_notify(struct notifier_block *this, unsigned long x, void *c) +{ + struct pscrr_device *pscrr_dev = container_of(this, struct pscrr_device, + reboot_notifier); + u32 magic; + + magic = get_magic_by_pscr(pscrr_dev, system_pscr); + pscrr_dev->write(pscrr_dev, magic); + + return NOTIFY_DONE; +} + +/** + * pscrr_process_property() - Process a power state change reason property + * @pscrr_dev: Pointer to the pscrr_device structure + * @prop: Pointer to the property structure to be processed + * + * This function processes a device tree property representing a power state + * change reason and initializes the relevant data structures. + * + * Returns: 0 on success, -ENOMEM on memory allocation failure. + */ +static int pscrr_process_property(struct pscrr_device *pscrr_dev, + struct property *prop) +{ + struct pscr_to_magic_entry *map_entry; + struct device *dev = pscrr_dev->dev; + size_t len = strlen(PREFIX); + int ret; + + if (strncmp(prop->name, PREFIX, len)) + return 0; + + map_entry = devm_kzalloc(dev, sizeof(*map_entry), GFP_KERNEL); + if (!map_entry) + return -ENOMEM; + + ret = of_property_read_u32(dev->of_node, prop->name, &map_entry->magic); + if (ret) { + dev_err(dev, "Can't read magic number for %s: %pe\n", + prop->name, ERR_PTR(ret)); + devm_kfree(dev, map_entry); + return 0; + } + + if (!map_entry->magic) { + dev_err(dev, "%s with magic number == 0\n", prop->name); + devm_kfree(dev, map_entry); + return 0; + } + + map_entry->pscr = find_pscr_by_string(prop->name + len); + if (map_entry->pscr < 0) { + dev_err(dev, "unsupported reason name(%s): %pe\n", + prop->name, ERR_PTR(map_entry->pscr)); + devm_kfree(dev, map_entry); + return 0; + } + + if (map_entry->magic > pscrr_dev->max_magic_val) + pscrr_dev->max_magic_val = map_entry->magic; + + dev_dbg(dev, "registering reason = %s, magic = %d, pscr = %d\n", + prop->name, map_entry->magic, map_entry->pscr); + list_add_tail(&map_entry->list, &pscrr_dev->pscr_map_list); + + return 0; +} + +/* + * pscrr_register() - Register the pscr driver and initialize power state change + * reasons + * @pscrr_dev: Pointer to the pscrr_device structure + * + * This function registers the pscr driver and initializes power state change + * reasons based on device tree properties. + * + * Returns: 0 on success, -ENOMEM on memory allocation failure + */ +int pscrr_register(struct pscrr_device *pscrr_dev) +{ + struct device_node *np = pscrr_dev->dev->of_node; + struct property *prop; + int ret; + + INIT_LIST_HEAD(&pscrr_dev->pscr_map_list); + + for_each_property_of_node(np, prop) { + ret = pscrr_process_property(pscrr_dev, prop); + if (ret) + return ret; + } + + pscrr_dev->reboot_notifier.notifier_call = pscrr_notify; + register_reboot_notifier(&pscrr_dev->reboot_notifier); + + dev_set_drvdata(pscrr_dev->dev, pscrr_dev); + + ret = device_create_file(pscrr_dev->dev, &dev_attr_power_state_change_reason); + if (ret) + dev_err(pscrr_dev->dev, "Could not create sysfs entry\n"); + + return ret; +} +EXPORT_SYMBOL_GPL(pscrr_register); + +/* + * pscrr_unregister() - Unregister the pscr driver's reboot notifier + * @pscrr_dev: Pointer to the pscrr_device structure + * + * This function unregisters the reboot notifier for the pscr driver. + */ +void pscrr_unregister(struct pscrr_device *pscrr_dev) +{ + unregister_reboot_notifier(&pscrr_dev->reboot_notifier); +} +EXPORT_SYMBOL_GPL(pscrr_unregister); + +static void devm_pscrr_release(struct device *dev, void *res) +{ + pscrr_unregister(*(struct pscrr_device **)res); +} + +/** + * devm_pscrr_register - Register a device-managed PSCR driver + * @dev: Device to associate the PSCR driver with + * @pscrr_dev: Pointer to the PSCR driver to be registered + * + * Registers a Power State Change Reason (PSCR) driver as a device-managed + * resource. + * + * Returns: 0 on successful registration or a negative error code on failure. + */ +int devm_pscrr_register(struct device *dev, struct pscrr_device *pscrr_dev) +{ + struct pscrr_device **dr; + int rc; + + dr = devres_alloc(devm_pscrr_release, sizeof(*dr), GFP_KERNEL); + if (!dr) + return -ENOMEM; + + rc = pscrr_register(pscrr_dev); + if (rc) { + devres_free(dr); + return rc; + } + + *dr = pscrr_dev; + devres_add(dev, dr); + + return 0; +} +EXPORT_SYMBOL_GPL(devm_pscrr_register); + +static int devm_pscrr_match(struct device *dev, void *res, void *data) +{ + struct pscrr_device **p = res; + + if (WARN_ON(!p || !*p)) + return 0; + + return *p == data; +} + +/** + * devm_pscrr_unregister - Unregister a managed PSCR driver + * @dev: Device associated with the PSCR driver + * @pscrr_dev: Pointer to the PSCR driver to unregister + * + * Unregisters a device-managed Power State Change Reason (PSCR) driver. + * It handles the cleanup and release of resources associated with the PSCR + * driver which was previously registered. + */ +void devm_pscrr_unregister(struct device *dev, + struct pscrr_device *pscrr_dev) +{ + WARN_ON(devres_release(dev, + devm_pscrr_release, + devm_pscrr_match, pscrr_dev)); +} +EXPORT_SYMBOL_GPL(devm_pscrr_unregister); + +MODULE_AUTHOR("Oleksij Rempel <o.rempel@pengutronix.de>"); +MODULE_DESCRIPTION("Power State Change Reason (PSCR) Recording framework"); +MODULE_LICENSE("GPL"); diff --git a/include/linux/pscrr.h b/include/linux/pscrr.h new file mode 100644 index 000000000000..2de9d9bc9aeb --- /dev/null +++ b/include/linux/pscrr.h @@ -0,0 +1,73 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __PSCRR_H__ +#define __PSCRR_H__ + +/* + * enum pscr - Enumerates reasons for power state changes. + * + * This enum lists the various reasons why a power state change might + * occur in a system. Each value represents a specific condition that + * could trigger a change in power state, such as shutdown or reboot. + * + * PSCR_UNKNOWN: Represents an unknown or unspecified reason. + * PSCR_UNDER_VOLTAGE: Indicates a power state change due to under-voltage. + * PSCR_OVER_CURRENT: Indicates a power state change due to over-current. + * PSCR_REGULATOR_FAILURE: Indicates a failure in a voltage regulator. + * PSCR_OVERTEMPERATURE: Indicates an over-temperature condition. + */ +enum pscr { + PSCR_UNKNOWN, + PSCR_UNDER_VOLTAGE, + PSCR_OVER_CURRENT, + PSCR_REGULATOR_FAILURE, + PSCR_OVERTEMPERATURE, +}; + +/* + * struct pscrr_device - Manages a Power State Change Reason Recorder device. + * + * This structure is utilized for controlling a device responsible for + * recording reasons for power state changes (PSCR). It includes mechanisms + * for mapping PSCR values to specific magic codes, storing these mappings, + * and recovering the last PSCR value from storage during system start-up. + * + * @dev: Device structure pointer. + * @pscr_map_list: List head for structs holding PSCR to magic code mappings. + * @write: Function pointer to write a new mapped PSCR value. + * @read: Function pointer to read the current mapped PSCR value. + * @reboot_notifier: Notifier block for recording PSCR at reboot. + * @max_magic_val: Maximum permissible magic code, used for verifying storage + * capacity and mapping integrity. + * @last_pscr: Last PSCR value recovered from storage at system start, + * representing the reason for the last system power cycle. + */ +struct pscrr_device { + struct device *dev; + struct list_head pscr_map_list; + int (*write)(struct pscrr_device *pscrr_dev, u32 magic); + int (*read)(struct pscrr_device *pscrr_dev, u32 *magic); + struct notifier_block reboot_notifier; + u32 max_magic_val; + enum pscr last_pscr; +}; + +int pscrr_register(struct pscrr_device *pscrr_dev); +void pscrr_unregister(struct pscrr_device *pscrr_dev); +int devm_pscrr_register(struct device *dev, + struct pscrr_device *pscrr_dev); +void devm_pscrr_unregister(struct device *dev, + struct pscrr_device *pscrr_dev); +int handle_last_pscr(struct pscrr_device *pscrr_dev); + +#if IS_ENABLED(CONFIG_PSCRR) + +void set_power_state_change_reason(enum pscr pscr); + +#else + +static inline void set_power_state_change_reason(enum pscr pscr) +{ +} +#endif + +#endif -- 2.39.2 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 3/8] power: reset: Introduce PSCR Recording Framework for Non-Volatile Storage 2024-01-24 12:21 ` [PATCH v2 3/8] power: reset: Introduce PSCR Recording Framework for Non-Volatile Storage Oleksij Rempel @ 2024-01-28 9:05 ` kernel test robot 0 siblings, 0 replies; 3+ messages in thread From: kernel test robot @ 2024-01-28 9:05 UTC (permalink / raw) To: Oleksij Rempel, Sebastian Reichel, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla Cc: llvm, oe-kbuild-all, Oleksij Rempel, kernel, linux-kernel, Liam Girdwood, Mark Brown, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, linux-pm, devicetree, Søren Andersen Hi Oleksij, kernel test robot noticed the following build warnings: [auto build test WARNING on robh/for-next] [also build test WARNING on broonie-regulator/for-next rafael-pm/thermal linus/master v6.8-rc1 next-20240125] [cannot apply to sre-power-supply/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Oleksij-Rempel/power-Extend-power_on_reason-h-for-upcoming-PSCRR-framework/20240124-202833 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20240124122204.730370-4-o.rempel%40pengutronix.de patch subject: [PATCH v2 3/8] power: reset: Introduce PSCR Recording Framework for Non-Volatile Storage config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240128/202401281628.Z3E5872D-lkp@intel.com/config) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240128/202401281628.Z3E5872D-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401281628.Z3E5872D-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/power/reset/pscrr.c:132:2: warning: label at end of compound statement is a C2x extension [-Wc2x-extensions] 132 | } | ^ 1 warning generated. vim +132 drivers/power/reset/pscrr.c 119 120 static const char *pscr_to_por_string(enum pscr pscr) 121 { 122 switch (pscr) { 123 case PSCR_UNDER_VOLTAGE: 124 return POWER_ON_REASON_BROWN_OUT; 125 case PSCR_OVER_CURRENT: 126 return POWER_ON_REASON_OVER_CURRENT; 127 case PSCR_REGULATOR_FAILURE: 128 return POWER_ON_REASON_REGULATOR_FAILURE; 129 case PSCR_OVERTEMPERATURE: 130 return POWER_ON_REASON_OVERTEMPERATURE; 131 default: > 132 } 133 134 return POWER_ON_REASON_UNKNOWN; 135 } 136 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-28 9:06 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-01-27 23:31 [PATCH v2 3/8] power: reset: Introduce PSCR Recording Framework for Non-Volatile Storage kernel test robot -- strict thread matches above, loose matches on Subject: below -- 2024-01-24 12:21 [RFC PATCH v1 0/8] Introduction of PSCR Framework and Related Components Oleksij Rempel 2024-01-24 12:21 ` [PATCH v2 3/8] power: reset: Introduce PSCR Recording Framework for Non-Volatile Storage Oleksij Rempel 2024-01-28 9:05 ` kernel test robot
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.