All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
Cc: anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org,
	Dan Carpenter <dan.carpenter@linaro.org>,
	netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 3/3] ixgbe: Clarify the values of the returning status
Date: Tue, 30 Jan 2024 13:11:37 +0000	[thread overview]
Message-ID: <20240130131137.GH351311@kernel.org> (raw)
In-Reply-To: <20240126130503.14197-3-jedrzej.jagielski@intel.com>

On Fri, Jan 26, 2024 at 02:05:03PM +0100, Jedrzej Jagielski wrote:
> Converting s32 functions to regular int in the previous patch of the series
> caused triggering smatch warnings about missing error code.
> 
> New smatch warnings:
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2884 ixgbe_get_lcd_t_x550em() warn: missing error code? 'status'
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:3130 ixgbe_enter_lplu_t_x550em() warn: missing error code? 'status'
> 
> Old smatch warnings:
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2890 ixgbe_get_lcd_t_x550em() warn: missing error code? 'status'
> 
> Fix it by clearly stating returning error code as 0.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/202401041701.6QKTsZmx-lkp@intel.com/
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>

Thanks, nice to see this cleaned up.

Reviewed-by: Simon Horman <horms@kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
	netdev@vger.kernel.org, kernel test robot <lkp@intel.com>,
	Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH iwl-next v4 3/3] ixgbe: Clarify the values of the returning status
Date: Tue, 30 Jan 2024 13:11:37 +0000	[thread overview]
Message-ID: <20240130131137.GH351311@kernel.org> (raw)
In-Reply-To: <20240126130503.14197-3-jedrzej.jagielski@intel.com>

On Fri, Jan 26, 2024 at 02:05:03PM +0100, Jedrzej Jagielski wrote:
> Converting s32 functions to regular int in the previous patch of the series
> caused triggering smatch warnings about missing error code.
> 
> New smatch warnings:
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2884 ixgbe_get_lcd_t_x550em() warn: missing error code? 'status'
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:3130 ixgbe_enter_lplu_t_x550em() warn: missing error code? 'status'
> 
> Old smatch warnings:
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2890 ixgbe_get_lcd_t_x550em() warn: missing error code? 'status'
> 
> Fix it by clearly stating returning error code as 0.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/202401041701.6QKTsZmx-lkp@intel.com/
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>

Thanks, nice to see this cleaned up.

Reviewed-by: Simon Horman <horms@kernel.org>

  reply	other threads:[~2024-01-30 13:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-26 13:05 [Intel-wired-lan] [PATCH iwl-next v4 1/3] ixgbe: Convert ret val type from s32 to int Jedrzej Jagielski
2024-01-26 13:05 ` Jedrzej Jagielski
2024-01-26 13:05 ` [Intel-wired-lan] [PATCH iwl-next v4 2/3] ixgbe: Rearrange args to fix reverse Christmas tree Jedrzej Jagielski
2024-01-26 13:05   ` Jedrzej Jagielski
2024-01-30 13:12   ` [Intel-wired-lan] " Simon Horman
2024-01-30 13:12     ` Simon Horman
2024-01-26 13:05 ` [Intel-wired-lan] [PATCH iwl-next v4 3/3] ixgbe: Clarify the values of the returning status Jedrzej Jagielski
2024-01-26 13:05   ` Jedrzej Jagielski
2024-01-30 13:11   ` Simon Horman [this message]
2024-01-30 13:11     ` Simon Horman
2024-01-30 13:13 ` [Intel-wired-lan] [PATCH iwl-next v4 1/3] ixgbe: Convert ret val type from s32 to int Simon Horman
2024-01-30 13:13   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240130131137.GH351311@kernel.org \
    --to=horms@kernel.org \
    --cc=anthony.l.nguyen@intel.com \
    --cc=dan.carpenter@linaro.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jedrzej.jagielski@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.