All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: linux-kernel@vger.kernel.org,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
	Jessica Zhang <quic_jesszhan@quicinc.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [drm-drm-misc:drm-misc-next] dt-bindings: nt35510: document 'port' property
Date: Tue, 30 Jan 2024 09:14:28 -0600	[thread overview]
Message-ID: <20240130151428.GA1629184-robh@kernel.org> (raw)
In-Reply-To: <20240127152821.65744-1-dario.binacchi@amarulasolutions.com>

On Sat, Jan 27, 2024 at 04:28:08PM +0100, Dario Binacchi wrote:
> Allow 'port' property (coming from panel-common.yaml) to be used in DTS:
> 
>   st/stm32f769-disco-mb1166-reva09.dtb: panel@0: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> 
> ---
> 
>  .../display/panel/novatek,nt35510.yaml        | 34 +++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
> index a4afaff483b7..72913719df23 100644
> --- a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
> @@ -31,6 +31,22 @@ properties:
>    vddi-supply:
>      description: regulator that supplies the vddi voltage
>    backlight: true
> +  port:
> +    $ref: /schemas/graph.yaml#/properties/port

Just 'port: true'

> +
> +if:
> +  properties:
> +    compatible:
> +      contains:
> +        enum:
> +          - frida,frd400b25025
> +then:
> +  required:
> +    - port
> +
> +else:
> +  properties:
> +    port: false

No need for this. 'port' should be allowed for everyone.

>  
>  required:
>    - compatible
> @@ -54,5 +70,23 @@ examples:
>              backlight = <&gpio_bl>;
>          };
>      };
> +  - |
> +    dsi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        panel@0 {
> +            compatible = "frida,frd400b25025", "novatek,nt35510";
> +            vddi-supply = <&vcc_3v3>;
> +            vdd-supply = <&vcc_3v3>;
> +            reg = <0>; /* dsi virtual channel (0..3) */
> +            reset-gpios = <&gpioj 15 GPIO_ACTIVE_LOW>;
>  
> +            port {
> +                dsi_panel_in: endpoint {
> +                    remote-endpoint = <&dsi_out>;
> +                };
> +            };
> +        };
> +    };
>  ...
> -- 
> 2.43.0
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	devicetree@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
	linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
	Jessica Zhang <quic_jesszhan@quicinc.com>,
	David Airlie <airlied@gmail.com>
Subject: Re: [drm-drm-misc:drm-misc-next] dt-bindings: nt35510: document 'port' property
Date: Tue, 30 Jan 2024 09:14:28 -0600	[thread overview]
Message-ID: <20240130151428.GA1629184-robh@kernel.org> (raw)
In-Reply-To: <20240127152821.65744-1-dario.binacchi@amarulasolutions.com>

On Sat, Jan 27, 2024 at 04:28:08PM +0100, Dario Binacchi wrote:
> Allow 'port' property (coming from panel-common.yaml) to be used in DTS:
> 
>   st/stm32f769-disco-mb1166-reva09.dtb: panel@0: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> 
> ---
> 
>  .../display/panel/novatek,nt35510.yaml        | 34 +++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
> index a4afaff483b7..72913719df23 100644
> --- a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
> @@ -31,6 +31,22 @@ properties:
>    vddi-supply:
>      description: regulator that supplies the vddi voltage
>    backlight: true
> +  port:
> +    $ref: /schemas/graph.yaml#/properties/port

Just 'port: true'

> +
> +if:
> +  properties:
> +    compatible:
> +      contains:
> +        enum:
> +          - frida,frd400b25025
> +then:
> +  required:
> +    - port
> +
> +else:
> +  properties:
> +    port: false

No need for this. 'port' should be allowed for everyone.

>  
>  required:
>    - compatible
> @@ -54,5 +70,23 @@ examples:
>              backlight = <&gpio_bl>;
>          };
>      };
> +  - |
> +    dsi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        panel@0 {
> +            compatible = "frida,frd400b25025", "novatek,nt35510";
> +            vddi-supply = <&vcc_3v3>;
> +            vdd-supply = <&vcc_3v3>;
> +            reg = <0>; /* dsi virtual channel (0..3) */
> +            reset-gpios = <&gpioj 15 GPIO_ACTIVE_LOW>;
>  
> +            port {
> +                dsi_panel_in: endpoint {
> +                    remote-endpoint = <&dsi_out>;
> +                };
> +            };
> +        };
> +    };
>  ...
> -- 
> 2.43.0
> 

  parent reply	other threads:[~2024-01-30 15:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-27 15:28 [drm-drm-misc:drm-misc-next] dt-bindings: nt35510: document 'port' property Dario Binacchi
2024-01-27 15:28 ` Dario Binacchi
2024-01-27 16:28 ` Rob Herring
2024-01-27 16:28   ` Rob Herring
2024-01-27 16:40   ` Linus Walleij
2024-01-27 16:40     ` Linus Walleij
2024-01-30 15:14 ` Rob Herring [this message]
2024-01-30 15:14   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240130151428.GA1629184-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=airlied@gmail.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_jesszhan@quicinc.com \
    --cc=sam@ravnborg.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.