* [PATCH] misc: eeprom/idt_89hpesx: Convert data structures to LE explicitly
@ 2024-01-30 4:06 Dawei Li
2024-01-30 9:54 ` Serge Semin
2024-01-30 14:04 ` Greg KH
0 siblings, 2 replies; 6+ messages in thread
From: Dawei Li @ 2024-01-30 4:06 UTC (permalink / raw)
To: arnd, gregkh
Cc: fancer.lancer, lkp, linux-kernel, set_pte_at, Dawei Li, stable
For data structures needs cpu_to_le* conversion, its prototype needs to
be declared with __le* explicitly.
Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202401261250.b07Yt30Z-lkp@intel.com/
Signed-off-by: Dawei Li <dawei.li@shingroup.cn>
Cc: <stable@vger.kernel.org>
---
drivers/misc/eeprom/idt_89hpesx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
index d807d08e2614..327afb866b21 100644
--- a/drivers/misc/eeprom/idt_89hpesx.c
+++ b/drivers/misc/eeprom/idt_89hpesx.c
@@ -129,7 +129,7 @@ struct idt_smb_seq {
struct idt_eeprom_seq {
u8 cmd;
u8 eeaddr;
- u16 memaddr;
+ __le16 memaddr;
u8 data;
} __packed;
@@ -141,8 +141,8 @@ struct idt_eeprom_seq {
*/
struct idt_csr_seq {
u8 cmd;
- u16 csraddr;
- u32 data;
+ __le16 csraddr;
+ __le32 data;
} __packed;
/*
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] misc: eeprom/idt_89hpesx: Convert data structures to LE explicitly 2024-01-30 4:06 [PATCH] misc: eeprom/idt_89hpesx: Convert data structures to LE explicitly Dawei Li @ 2024-01-30 9:54 ` Serge Semin 2024-01-30 14:04 ` Greg KH 1 sibling, 0 replies; 6+ messages in thread From: Serge Semin @ 2024-01-30 9:54 UTC (permalink / raw) To: Dawei Li; +Cc: arnd, gregkh, lkp, linux-kernel, set_pte_at, stable On Tue, Jan 30, 2024 at 12:06:32PM +0800, Dawei Li wrote: > For data structures needs cpu_to_le* conversion, its prototype needs to > be declared with __le* explicitly. > > Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202401261250.b07Yt30Z-lkp@intel.com/ > Signed-off-by: Dawei Li <dawei.li@shingroup.cn> > Cc: <stable@vger.kernel.org> Awesome! Thanks for the patch. Definitely Reviewed-by: Serge Semin <fancer.lancer@gmail.com> -Serge(y) > --- > drivers/misc/eeprom/idt_89hpesx.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c > index d807d08e2614..327afb866b21 100644 > --- a/drivers/misc/eeprom/idt_89hpesx.c > +++ b/drivers/misc/eeprom/idt_89hpesx.c > @@ -129,7 +129,7 @@ struct idt_smb_seq { > struct idt_eeprom_seq { > u8 cmd; > u8 eeaddr; > - u16 memaddr; > + __le16 memaddr; > u8 data; > } __packed; > > @@ -141,8 +141,8 @@ struct idt_eeprom_seq { > */ > struct idt_csr_seq { > u8 cmd; > - u16 csraddr; > - u32 data; > + __le16 csraddr; > + __le32 data; > } __packed; > > /* > -- > 2.27.0 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] misc: eeprom/idt_89hpesx: Convert data structures to LE explicitly 2024-01-30 4:06 [PATCH] misc: eeprom/idt_89hpesx: Convert data structures to LE explicitly Dawei Li 2024-01-30 9:54 ` Serge Semin @ 2024-01-30 14:04 ` Greg KH 2024-01-31 1:34 ` Dawei Li 1 sibling, 1 reply; 6+ messages in thread From: Greg KH @ 2024-01-30 14:04 UTC (permalink / raw) To: Dawei Li; +Cc: arnd, fancer.lancer, lkp, linux-kernel, set_pte_at, stable On Tue, Jan 30, 2024 at 12:06:32PM +0800, Dawei Li wrote: > For data structures needs cpu_to_le* conversion, its prototype needs to > be declared with __le* explicitly. > > Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202401261250.b07Yt30Z-lkp@intel.com/ > Signed-off-by: Dawei Li <dawei.li@shingroup.cn> > Cc: <stable@vger.kernel.org> > --- > drivers/misc/eeprom/idt_89hpesx.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c > index d807d08e2614..327afb866b21 100644 > --- a/drivers/misc/eeprom/idt_89hpesx.c > +++ b/drivers/misc/eeprom/idt_89hpesx.c > @@ -129,7 +129,7 @@ struct idt_smb_seq { > struct idt_eeprom_seq { > u8 cmd; > u8 eeaddr; > - u16 memaddr; > + __le16 memaddr; > u8 data; > } __packed; > > @@ -141,8 +141,8 @@ struct idt_eeprom_seq { > */ > struct idt_csr_seq { > u8 cmd; > - u16 csraddr; > - u32 data; > + __le16 csraddr; > + __le32 data; > } __packed; > > /* Declaring them this way is nice, but this doesn't actually "fix" anything at all as no code is actually changed. So how is ths a bugfix? How does this patch do anything? confused, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] misc: eeprom/idt_89hpesx: Convert data structures to LE explicitly 2024-01-30 14:04 ` Greg KH @ 2024-01-31 1:34 ` Dawei Li 2024-01-31 2:07 ` Greg KH 0 siblings, 1 reply; 6+ messages in thread From: Dawei Li @ 2024-01-31 1:34 UTC (permalink / raw) To: Greg KH; +Cc: arnd, fancer.lancer, lkp, linux-kernel, set_pte_at, stable Hi Greg, Thanks for reviewing. On Tue, Jan 30, 2024 at 06:04:17AM -0800, Greg KH wrote: > On Tue, Jan 30, 2024 at 12:06:32PM +0800, Dawei Li wrote: > > For data structures needs cpu_to_le* conversion, its prototype needs to > > be declared with __le* explicitly. > > > > Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver") > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: https://lore.kernel.org/oe-kbuild-all/202401261250.b07Yt30Z-lkp@intel.com/ > > Signed-off-by: Dawei Li <dawei.li@shingroup.cn> > > Cc: <stable@vger.kernel.org> > > --- > > drivers/misc/eeprom/idt_89hpesx.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c > > index d807d08e2614..327afb866b21 100644 > > --- a/drivers/misc/eeprom/idt_89hpesx.c > > +++ b/drivers/misc/eeprom/idt_89hpesx.c > > @@ -129,7 +129,7 @@ struct idt_smb_seq { > > struct idt_eeprom_seq { > > u8 cmd; > > u8 eeaddr; > > - u16 memaddr; > > + __le16 memaddr; > > u8 data; > > } __packed; > > > > @@ -141,8 +141,8 @@ struct idt_eeprom_seq { > > */ > > struct idt_csr_seq { > > u8 cmd; > > - u16 csraddr; > > - u32 data; > > + __le16 csraddr; > > + __le32 data; > > } __packed; > > > > /* > > Declaring them this way is nice, but this doesn't actually "fix" > anything at all as no code is actually changed. > > So how is ths a bugfix? How does this patch do anything? > > confused, Sorry for the confuson. This commit is to address the issue reported by kernel test rebot[1]. Partially quoted from it: sparse warnings: (new ones prefixed by >>) >> drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [addressable] [assigned] [usertype] memaddr @@ got restricted __le16 [usertype] @@ drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse: expected unsigned short [addressable] [assigned] [usertype] memaddr drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse: got restricted __le16 [usertype] drivers/misc/eeprom/idt_89hpesx.c:671:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [addressable] [assigned] [usertype] memaddr @@ got restricted __le16 [usertype] @@ drivers/misc/eeprom/idt_89hpesx.c:671:31: sparse: expected unsigned short [addressable] [assigned] [usertype] memaddr drivers/misc/eeprom/idt_89hpesx.c:671:31: sparse: got restricted __le16 [usertype] >> drivers/misc/eeprom/idt_89hpesx.c:769:24: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [addressable] [assigned] [usertype] csraddr @@ got restricted __le16 [usertype] @@ drivers/misc/eeprom/idt_89hpesx.c:769:24: sparse: expected unsigned short [addressable] [assigned] [usertype] csraddr drivers/misc/eeprom/idt_89hpesx.c:769:24: sparse: got restricted __le16 [usertype] >> drivers/misc/eeprom/idt_89hpesx.c:770:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [addressable] [assigned] [usertype] data @@ got restricted __le32 [usertype] @@ drivers/misc/eeprom/idt_89hpesx.c:770:21: sparse: expected unsigned int [addressable] [assigned] [usertype] data drivers/misc/eeprom/idt_89hpesx.c:770:21: sparse: got restricted __le32 [usertype] drivers/misc/eeprom/idt_89hpesx.c:834:24: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [addressable] [assigned] [usertype] csraddr @@ got restricted __le16 [usertype] @@ drivers/misc/eeprom/idt_89hpesx.c:834:24: sparse: expected unsigned short [addressable] [assigned] [usertype] csraddr drivers/misc/eeprom/idt_89hpesx.c:834:24: sparse: got restricted __le16 [usertype] >> drivers/misc/eeprom/idt_89hpesx.c:859:17: sparse: sparse: cast to restricted __le32 >> drivers/misc/eeprom/idt_89hpesx.c:859:17: sparse: sparse: cast to restricted __le32 >> drivers/misc/eeprom/idt_89hpesx.c:859:17: sparse: sparse: cast to restricted __le32 >> drivers/misc/eeprom/idt_89hpesx.c:859:17: sparse: sparse: cast to restricted __le32 >> drivers/misc/eeprom/idt_89hpesx.c:859:17: sparse: sparse: cast to restricted __le32 >> drivers/misc/eeprom/idt_89hpesx.c:859:17: sparse: sparse: cast to restricted __le32 [1] https://lore.kernel.org/oe-kbuild-all/202401261250.b07Yt30Z-lkp@intel.com/ Thanks, Dawei > > greg k-h > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] misc: eeprom/idt_89hpesx: Convert data structures to LE explicitly 2024-01-31 1:34 ` Dawei Li @ 2024-01-31 2:07 ` Greg KH 2024-01-31 2:19 ` Dawei Li 0 siblings, 1 reply; 6+ messages in thread From: Greg KH @ 2024-01-31 2:07 UTC (permalink / raw) To: Dawei Li; +Cc: arnd, fancer.lancer, lkp, linux-kernel, set_pte_at, stable On Wed, Jan 31, 2024 at 09:34:52AM +0800, Dawei Li wrote: > Hi Greg, > > Thanks for reviewing. > > On Tue, Jan 30, 2024 at 06:04:17AM -0800, Greg KH wrote: > > On Tue, Jan 30, 2024 at 12:06:32PM +0800, Dawei Li wrote: > > > For data structures needs cpu_to_le* conversion, its prototype needs to > > > be declared with __le* explicitly. > > > > > > Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver") > > > Reported-by: kernel test robot <lkp@intel.com> > > > Closes: https://lore.kernel.org/oe-kbuild-all/202401261250.b07Yt30Z-lkp@intel.com/ > > > Signed-off-by: Dawei Li <dawei.li@shingroup.cn> > > > Cc: <stable@vger.kernel.org> > > > --- > > > drivers/misc/eeprom/idt_89hpesx.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c > > > index d807d08e2614..327afb866b21 100644 > > > --- a/drivers/misc/eeprom/idt_89hpesx.c > > > +++ b/drivers/misc/eeprom/idt_89hpesx.c > > > @@ -129,7 +129,7 @@ struct idt_smb_seq { > > > struct idt_eeprom_seq { > > > u8 cmd; > > > u8 eeaddr; > > > - u16 memaddr; > > > + __le16 memaddr; > > > u8 data; > > > } __packed; > > > > > > @@ -141,8 +141,8 @@ struct idt_eeprom_seq { > > > */ > > > struct idt_csr_seq { > > > u8 cmd; > > > - u16 csraddr; > > > - u32 data; > > > + __le16 csraddr; > > > + __le32 data; > > > } __packed; > > > > > > /* > > > > Declaring them this way is nice, but this doesn't actually "fix" > > anything at all as no code is actually changed. > > > > So how is ths a bugfix? How does this patch do anything? > > > > confused, > > Sorry for the confuson. > > This commit is to address the issue reported by kernel test rebot[1]. > > Partially quoted from it: > > sparse warnings: (new ones prefixed by >>) > >> drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [addressable] [assigned] [usertype] memaddr @@ got restricted __le16 [usertype] @@ > drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse: expected unsigned short [addressable] [assigned] [usertype] memaddr > drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse: got restricted __le16 [usertype] > drivers/misc/eeprom/idt_89hpesx.c:671:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [addressable] [assigned] [usertype] memaddr @@ got restricted __le16 [usertype] @@ > drivers/misc/eeprom/idt_89hpesx.c:671:31: sparse: expected unsigned short [addressable] [assigned] [usertype] memaddr > drivers/misc/eeprom/idt_89hpesx.c:671:31: sparse: got restricted __le16 [usertype] > >> drivers/misc/eeprom/idt_89hpesx.c:769:24: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [addressable] [assigned] [usertype] csraddr @@ got restricted __le16 [usertype] @@ > drivers/misc/eeprom/idt_89hpesx.c:769:24: sparse: expected unsigned short [addressable] [assigned] [usertype] csraddr > drivers/misc/eeprom/idt_89hpesx.c:769:24: sparse: got restricted __le16 [usertype] > >> drivers/misc/eeprom/idt_89hpesx.c:770:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [addressable] [assigned] [usertype] data @@ got restricted __le32 [usertype] @@ > drivers/misc/eeprom/idt_89hpesx.c:770:21: sparse: expected unsigned int [addressable] [assigned] [usertype] data > drivers/misc/eeprom/idt_89hpesx.c:770:21: sparse: got restricted __le32 [usertype] > drivers/misc/eeprom/idt_89hpesx.c:834:24: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [addressable] [assigned] [usertype] csraddr @@ got restricted __le16 [usertype] @@ > drivers/misc/eeprom/idt_89hpesx.c:834:24: sparse: expected unsigned short [addressable] [assigned] [usertype] csraddr > drivers/misc/eeprom/idt_89hpesx.c:834:24: sparse: got restricted __le16 [usertype] > >> drivers/misc/eeprom/idt_89hpesx.c:859:17: sparse: sparse: cast to restricted __le32 > >> drivers/misc/eeprom/idt_89hpesx.c:859:17: sparse: sparse: cast to restricted __le32 > >> drivers/misc/eeprom/idt_89hpesx.c:859:17: sparse: sparse: cast to restricted __le32 > >> drivers/misc/eeprom/idt_89hpesx.c:859:17: sparse: sparse: cast to restricted __le32 > >> drivers/misc/eeprom/idt_89hpesx.c:859:17: sparse: sparse: cast to restricted __le32 > >> drivers/misc/eeprom/idt_89hpesx.c:859:17: sparse: sparse: cast to restricted __le32 > > [1] https://lore.kernel.org/oe-kbuild-all/202401261250.b07Yt30Z-lkp@intel.com/ Ok, so this fixes a sparse issue, how is that needed for stable kernels? Please be more explicit about what you are "fixing" in the changelog please, as-is this didn't make any sense to me. Please fix up and send a v2. thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] misc: eeprom/idt_89hpesx: Convert data structures to LE explicitly 2024-01-31 2:07 ` Greg KH @ 2024-01-31 2:19 ` Dawei Li 0 siblings, 0 replies; 6+ messages in thread From: Dawei Li @ 2024-01-31 2:19 UTC (permalink / raw) To: Greg KH; +Cc: arnd, fancer.lancer, lkp, linux-kernel, set_pte_at, stable Hi Greg, On Tue, Jan 30, 2024 at 06:07:18PM -0800, Greg KH wrote: > On Wed, Jan 31, 2024 at 09:34:52AM +0800, Dawei Li wrote: > > Hi Greg, > > > > Thanks for reviewing. > > > > On Tue, Jan 30, 2024 at 06:04:17AM -0800, Greg KH wrote: > > > On Tue, Jan 30, 2024 at 12:06:32PM +0800, Dawei Li wrote: > > > > For data structures needs cpu_to_le* conversion, its prototype needs to > > > > be declared with __le* explicitly. > > > > > > > > Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver") > > > > Reported-by: kernel test robot <lkp@intel.com> > > > > Closes: https://lore.kernel.org/oe-kbuild-all/202401261250.b07Yt30Z-lkp@intel.com/ > > > > Signed-off-by: Dawei Li <dawei.li@shingroup.cn> > > > > Cc: <stable@vger.kernel.org> > > > > --- > > > > drivers/misc/eeprom/idt_89hpesx.c | 6 +++--- > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c > > > > index d807d08e2614..327afb866b21 100644 > > > > --- a/drivers/misc/eeprom/idt_89hpesx.c > > > > +++ b/drivers/misc/eeprom/idt_89hpesx.c > > > > @@ -129,7 +129,7 @@ struct idt_smb_seq { > > > > struct idt_eeprom_seq { > > > > u8 cmd; > > > > u8 eeaddr; > > > > - u16 memaddr; > > > > + __le16 memaddr; > > > > u8 data; > > > > } __packed; > > > > > > > > @@ -141,8 +141,8 @@ struct idt_eeprom_seq { > > > > */ > > > > struct idt_csr_seq { > > > > u8 cmd; > > > > - u16 csraddr; > > > > - u32 data; > > > > + __le16 csraddr; > > > > + __le32 data; > > > > } __packed; > > > > > > > > /* > > > > > > Declaring them this way is nice, but this doesn't actually "fix" > > > anything at all as no code is actually changed. > > > > > > So how is ths a bugfix? How does this patch do anything? > > > > > > confused, > > > > Sorry for the confuson. > > > > This commit is to address the issue reported by kernel test rebot[1]. > > > > Partially quoted from it: > > > > sparse warnings: (new ones prefixed by >>) > > >> drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [addressable] [assigned] [usertype] memaddr @@ got restricted __le16 [usertype] @@ > > drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse: expected unsigned short [addressable] [assigned] [usertype] memaddr > > drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse: got restricted __le16 [usertype] > > drivers/misc/eeprom/idt_89hpesx.c:671:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [addressable] [assigned] [usertype] memaddr @@ got restricted __le16 [usertype] @@ > > drivers/misc/eeprom/idt_89hpesx.c:671:31: sparse: expected unsigned short [addressable] [assigned] [usertype] memaddr > > drivers/misc/eeprom/idt_89hpesx.c:671:31: sparse: got restricted __le16 [usertype] > > >> drivers/misc/eeprom/idt_89hpesx.c:769:24: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [addressable] [assigned] [usertype] csraddr @@ got restricted __le16 [usertype] @@ > > drivers/misc/eeprom/idt_89hpesx.c:769:24: sparse: expected unsigned short [addressable] [assigned] [usertype] csraddr > > drivers/misc/eeprom/idt_89hpesx.c:769:24: sparse: got restricted __le16 [usertype] > > >> drivers/misc/eeprom/idt_89hpesx.c:770:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [addressable] [assigned] [usertype] data @@ got restricted __le32 [usertype] @@ > > drivers/misc/eeprom/idt_89hpesx.c:770:21: sparse: expected unsigned int [addressable] [assigned] [usertype] data > > drivers/misc/eeprom/idt_89hpesx.c:770:21: sparse: got restricted __le32 [usertype] > > drivers/misc/eeprom/idt_89hpesx.c:834:24: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [addressable] [assigned] [usertype] csraddr @@ got restricted __le16 [usertype] @@ > > drivers/misc/eeprom/idt_89hpesx.c:834:24: sparse: expected unsigned short [addressable] [assigned] [usertype] csraddr > > drivers/misc/eeprom/idt_89hpesx.c:834:24: sparse: got restricted __le16 [usertype] > > >> drivers/misc/eeprom/idt_89hpesx.c:859:17: sparse: sparse: cast to restricted __le32 > > >> drivers/misc/eeprom/idt_89hpesx.c:859:17: sparse: sparse: cast to restricted __le32 > > >> drivers/misc/eeprom/idt_89hpesx.c:859:17: sparse: sparse: cast to restricted __le32 > > >> drivers/misc/eeprom/idt_89hpesx.c:859:17: sparse: sparse: cast to restricted __le32 > > >> drivers/misc/eeprom/idt_89hpesx.c:859:17: sparse: sparse: cast to restricted __le32 > > >> drivers/misc/eeprom/idt_89hpesx.c:859:17: sparse: sparse: cast to restricted __le32 > > > > [1] https://lore.kernel.org/oe-kbuild-all/202401261250.b07Yt30Z-lkp@intel.com/ > > Ok, so this fixes a sparse issue, how is that needed for stable kernels? > > Please be more explicit about what you are "fixing" in the changelog > please, as-is this didn't make any sense to me. Yes, it's my fault not making it clear in commit message. Sorry for that. > > Please fix up and send a v2. Will do that. > > thanks, > > greg k-h > Thanks, Dawei ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-01-31 2:19 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-01-30 4:06 [PATCH] misc: eeprom/idt_89hpesx: Convert data structures to LE explicitly Dawei Li 2024-01-30 9:54 ` Serge Semin 2024-01-30 14:04 ` Greg KH 2024-01-31 1:34 ` Dawei Li 2024-01-31 2:07 ` Greg KH 2024-01-31 2:19 ` Dawei Li
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.