From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Xu Yilun <yilun.xu@linux.intel.com>
Cc: Markus Elfring <Markus.Elfring@web.de>,
linux-fpga@vger.kernel.org, kernel-janitors@vger.kernel.org,
Luwei Kang <luwei.kang@intel.com>,
Moritz Fischer <mdf@kernel.org>, Tom Rix <trix@redhat.com>,
Wu Hao <hao.wu@intel.com>, Xu Yilun <yilun.xu@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Kunwu Chan <chentao@kylinos.cn>
Subject: Re: [PATCH] fpga: dfl: fme: Return directly after a failed devm_kasprintf() call in fme_perf_pmu_register()
Date: Tue, 30 Jan 2024 06:11:17 -0800 [thread overview]
Message-ID: <2024013044-proved-ligament-9555@gregkh> (raw)
In-Reply-To: <ZbjPDX1y2I9Heanq@yilunxu-OptiPlex-7050>
On Tue, Jan 30, 2024 at 06:27:25PM +0800, Xu Yilun wrote:
> On Tue, Jan 30, 2024 at 06:03:12PM +0800, Xu Yilun wrote:
> > On Sat, Jan 27, 2024 at 03:55:19PM +0100, Markus Elfring wrote:
> > > From: Markus Elfring <elfring@users.sourceforge.net>
> > > Date: Sat, 27 Jan 2024 15:43:42 +0100
>
> Sorry, something to fix.
>
> Please shorten your shortlog to less than 75 chars.
> Please refer to Documentation/process/submitting-patches.rst
>
> > >
> > > The result from a call of the function “devm_kasprintf” was passed to
> > > a subsequent function call without checking for a null pointer before
> > > (according to a memory allocation failure).
> > > This issue was detected by using the Coccinelle software.
> > >
> > > Thus return directly after a failed devm_kasprintf() call.
> > >
> > > Fixes: 724142f8c42a7 ("fpga: dfl: fme: add performance reporting support")
>
> One more char of sha.
>
> Please use checkpatch to verify.
>
> Thanks,
> Yilun
Hi,
This is the semi-friendly patch-bot of Greg Kroah-Hartman.
Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.
Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.
thanks,
greg k-h's patch email bot
next prev parent reply other threads:[~2024-01-30 16:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-27 14:55 [PATCH] fpga: dfl: fme: Return directly after a failed devm_kasprintf() call in fme_perf_pmu_register() Markus Elfring
2024-01-30 10:03 ` Xu Yilun
2024-01-30 10:27 ` Xu Yilun
2024-01-30 10:48 ` Markus Elfring
2024-01-30 13:59 ` Xu Yilun
2024-01-31 7:42 ` Markus Elfring
2024-01-30 14:11 ` Greg Kroah-Hartman [this message]
2024-01-30 15:49 ` [PATCH] " Dan Carpenter
2024-01-30 17:09 ` Markus Elfring
2024-01-30 17:13 ` Greg Kroah-Hartman
2024-01-31 5:43 ` Dan Carpenter
2024-01-31 7:51 ` Markus Elfring
2024-02-02 7:57 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024013044-proved-ligament-9555@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Markus.Elfring@web.de \
--cc=chentao@kylinos.cn \
--cc=hao.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luwei.kang@intel.com \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
--cc=yilun.xu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.