From: Markus Elfring <Markus.Elfring@web.de>
To: Dan Carpenter <dan.carpenter@linaro.org>,
linux-fpga@vger.kernel.org, kernel-janitors@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Moritz Fischer <mdf@kernel.org>, Tom Rix <trix@redhat.com>,
Wu Hao <hao.wu@intel.com>, Xu Yilun <yilun.xu@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Kunwu Chan <chentao@kylinos.cn>
Subject: Re: fpga: dfl: fme: Return directly after a failed devm_kasprintf() call in fme_perf_pmu_register()
Date: Tue, 30 Jan 2024 18:09:14 +0100 [thread overview]
Message-ID: <e760bd1b-30bf-489f-b745-128d05397feb@web.de> (raw)
In-Reply-To: <b7e2e9d1-5e3e-44b2-a4b7-327d334b776d@moroto.mountain>
>> Thus return directly after a failed devm_kasprintf() call.
>>
>> Fixes: 724142f8c42a7 ("fpga: dfl: fme: add performance reporting support")
>
> This basically doesn't affect runtime because perf_pmu_register() checks
> for NULL so no need for a Fixes tag.
I suggest to clarify this view a bit more also according to statements
like the following.
1. https://elixir.bootlin.com/linux/v6.8-rc2/source/kernel/events/core.c#L11532
perf_pmu_register:
…
pmu->name = name;
…
2. https://elixir.bootlin.com/linux/v6.8-rc2/source/kernel/events/core.c#L11472
pmu_dev_alloc:
…
ret = dev_set_name(pmu->dev, "%s", pmu->name);
…
Regards,
Markus
next prev parent reply other threads:[~2024-01-30 17:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-27 14:55 [PATCH] fpga: dfl: fme: Return directly after a failed devm_kasprintf() call in fme_perf_pmu_register() Markus Elfring
2024-01-30 10:03 ` Xu Yilun
2024-01-30 10:27 ` Xu Yilun
2024-01-30 10:48 ` Markus Elfring
2024-01-30 13:59 ` Xu Yilun
2024-01-31 7:42 ` Markus Elfring
2024-01-30 14:11 ` [PATCH] " Greg Kroah-Hartman
2024-01-30 15:49 ` Dan Carpenter
2024-01-30 17:09 ` Markus Elfring [this message]
2024-01-30 17:13 ` Greg Kroah-Hartman
2024-01-31 5:43 ` Dan Carpenter
2024-01-31 7:51 ` Markus Elfring
2024-02-02 7:57 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e760bd1b-30bf-489f-b745-128d05397feb@web.de \
--to=markus.elfring@web.de \
--cc=chentao@kylinos.cn \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.