From: Tony Lindgren <tony@atomide.com>
To: Michael Walle <mwalle@kernel.org>
Cc: dmitry.baryshkov@linaro.org, Laurent.pinchart@ideasonboard.com,
andrzej.hajda@intel.com, conor+dt@kernel.org,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
ivo.g.dimitrov.75@gmail.com, jernej.skrabec@gmail.com,
jonas@kwiboo.se, krzysztof.kozlowski+dt@linaro.org,
merlijn@wizzup.org, mripard@kernel.org,
neil.armstrong@linaro.org, pavel@ucw.cz, philipp@uvos.xyz,
rfoss@kernel.org, robh+dt@kernel.org, sam@ravnborg.org,
simhavcs@gmail.com, sre@kernel.org, tzimmermann@suse.de
Subject: Re: [PATCH v2 09/10] drm/bridge: tc358775: Add support for tc358765
Date: Wed, 31 Jan 2024 08:20:21 +0200 [thread overview]
Message-ID: <20240131062021.GV31612@atomide.com> (raw)
In-Reply-To: <20231204095213.2573620-1-mwalle@kernel.org>
* Michael Walle <mwalle@kernel.org> [231204 09:52]:
> >> @@ -643,6 +658,7 @@ static int tc_probe(struct i2c_client *client)
> >>
> >> tc->dev = dev;
> >> tc->i2c = client;
> >> + tc->type = (enum tc3587x5_type)of_device_get_match_data(dev);
> >
> > Would it make sense to use i2c_get_match_data() instead?
>
> FWIW, I' planning to add a dsi binding for this driver. So I'd
> suggest either the of_ or the device_ variant. Not sure though,
> if the new device supports the DSI commands.
Yeah good point as some hardware may not have i2c wired at all. Let's keep
this as of_device_get_match_data() for now as the driver is currently
completely dependant on devicetree.
I'll update the enumeration to use the hardware id numbering like Dmitry
suggested though.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Michael Walle <mwalle@kernel.org>
Cc: mripard@kernel.org, devicetree@vger.kernel.org,
conor+dt@kernel.org, ivo.g.dimitrov.75@gmail.com,
rfoss@kernel.org, krzysztof.kozlowski+dt@linaro.org,
tzimmermann@suse.de, jonas@kwiboo.se, pavel@ucw.cz,
sam@ravnborg.org, merlijn@wizzup.org, neil.armstrong@linaro.org,
sre@kernel.org, dri-devel@lists.freedesktop.org,
robh+dt@kernel.org, Laurent.pinchart@ideasonboard.com,
andrzej.hajda@intel.com, simhavcs@gmail.com,
dmitry.baryshkov@linaro.org, philipp@uvos.xyz,
jernej.skrabec@gmail.com
Subject: Re: [PATCH v2 09/10] drm/bridge: tc358775: Add support for tc358765
Date: Wed, 31 Jan 2024 08:20:21 +0200 [thread overview]
Message-ID: <20240131062021.GV31612@atomide.com> (raw)
In-Reply-To: <20231204095213.2573620-1-mwalle@kernel.org>
* Michael Walle <mwalle@kernel.org> [231204 09:52]:
> >> @@ -643,6 +658,7 @@ static int tc_probe(struct i2c_client *client)
> >>
> >> tc->dev = dev;
> >> tc->i2c = client;
> >> + tc->type = (enum tc3587x5_type)of_device_get_match_data(dev);
> >
> > Would it make sense to use i2c_get_match_data() instead?
>
> FWIW, I' planning to add a dsi binding for this driver. So I'd
> suggest either the of_ or the device_ variant. Not sure though,
> if the new device supports the DSI commands.
Yeah good point as some hardware may not have i2c wired at all. Let's keep
this as of_device_get_match_data() for now as the driver is currently
completely dependant on devicetree.
I'll update the enumeration to use the hardware id numbering like Dmitry
suggested though.
Regards,
Tony
next prev parent reply other threads:[~2024-01-31 6:21 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-02 7:54 [PATCH v2 00/10] Improvments for tc358775 with support for tc358765 Tony Lindgren
2023-12-02 7:54 ` Tony Lindgren
2023-12-02 7:54 ` [PATCH v2 01/10] dt-bindings: display: bridge: tc358775: make stby gpio and vdd supplies optional Tony Lindgren
2023-12-02 7:54 ` Tony Lindgren
2023-12-03 16:49 ` Krzysztof Kozlowski
2023-12-03 16:49 ` Krzysztof Kozlowski
2023-12-04 9:33 ` Michael Walle
2023-12-04 9:33 ` Michael Walle
2023-12-02 7:54 ` [PATCH v2 02/10] dt-bindings: display: bridge: tc358775: Add data-lanes Tony Lindgren
2023-12-02 7:54 ` Tony Lindgren
2023-12-03 16:51 ` Krzysztof Kozlowski
2023-12-03 16:51 ` Krzysztof Kozlowski
2023-12-02 7:54 ` [PATCH v2 03/10] dt-bindings: display: bridge: tc358775: Add support for tc358765 Tony Lindgren
2023-12-02 7:54 ` Tony Lindgren
2023-12-03 16:52 ` Krzysztof Kozlowski
2023-12-03 16:52 ` Krzysztof Kozlowski
2023-12-02 7:54 ` [PATCH v2 04/10] drm/bridge: tc358775: fix support for jeida-18 and jeida-24 Tony Lindgren
2023-12-02 7:54 ` Tony Lindgren
2023-12-02 7:54 ` [PATCH v2 05/10] drm/bridge: tc358775: make standby GPIO optional Tony Lindgren
2023-12-02 7:54 ` Tony Lindgren
2023-12-03 23:37 ` Dmitry Baryshkov
2023-12-03 23:37 ` Dmitry Baryshkov
2023-12-04 9:29 ` Michael Walle
2023-12-04 9:29 ` Michael Walle
2023-12-02 7:54 ` [PATCH v2 06/10] drm/bridge: tc358775: Get bridge data lanes instead of the DSI host lanes Tony Lindgren
2023-12-02 7:54 ` Tony Lindgren
2023-12-03 23:47 ` Dmitry Baryshkov
2023-12-03 23:47 ` Dmitry Baryshkov
2023-12-07 15:14 ` Michael Walle
2023-12-07 15:14 ` Michael Walle
2023-12-02 7:54 ` [PATCH v2 07/10] drm/bridge: tc358775: Add burst and low-power modes Tony Lindgren
2023-12-02 7:54 ` Tony Lindgren
2023-12-07 15:01 ` Michael Walle
2023-12-07 15:01 ` Michael Walle
2023-12-02 7:54 ` [PATCH v2 08/10] drm/bridge: tc358775: Enable pre_enable_prev_first flag Tony Lindgren
2023-12-02 7:54 ` Tony Lindgren
2023-12-03 23:48 ` Dmitry Baryshkov
2023-12-03 23:48 ` Dmitry Baryshkov
2023-12-07 15:03 ` Michael Walle
2023-12-07 15:03 ` Michael Walle
2023-12-02 7:54 ` [PATCH v2 09/10] drm/bridge: tc358775: Add support for tc358765 Tony Lindgren
2023-12-02 7:54 ` Tony Lindgren
2023-12-03 23:52 ` Dmitry Baryshkov
2023-12-03 23:52 ` Dmitry Baryshkov
2023-12-04 9:52 ` Michael Walle
2023-12-04 9:52 ` Michael Walle
2024-01-31 6:20 ` Tony Lindgren [this message]
2024-01-31 6:20 ` Tony Lindgren
2023-12-05 20:19 ` kernel test robot
2023-12-05 20:19 ` kernel test robot
2023-12-02 7:54 ` [PATCH v2 10/10] drm/bridge: tc358775: Configure hs_rate and lp_rate Tony Lindgren
2023-12-02 7:54 ` Tony Lindgren
2023-12-03 23:48 ` Dmitry Baryshkov
2023-12-03 23:48 ` Dmitry Baryshkov
2023-12-07 16:13 ` Michael Walle
2023-12-07 16:13 ` Michael Walle
2024-01-31 6:14 ` Tony Lindgren
2024-01-31 6:14 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240131062021.GV31612@atomide.com \
--to=tony@atomide.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=andrzej.hajda@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=merlijn@wizzup.org \
--cc=mripard@kernel.org \
--cc=mwalle@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=pavel@ucw.cz \
--cc=philipp@uvos.xyz \
--cc=rfoss@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=simhavcs@gmail.com \
--cc=sre@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.