* [PATCH] nvme-common: add module description
@ 2024-01-31 5:43 Chaitanya Kulkarni
2024-01-31 6:30 ` Christoph Hellwig
2024-01-31 21:01 ` Sagi Grimberg
0 siblings, 2 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2024-01-31 5:43 UTC (permalink / raw)
To: hare; +Cc: kbusch, hch, sagi, linux-nvme, Chaitanya Kulkarni
Add MODULE_DESCRIPTION() in order to remove warnings & get clean build:-
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/common/nvme-auth.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/common/nvme-keyring.o
Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
---
drivers/nvme/common/auth.c | 1 +
drivers/nvme/common/keyring.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/nvme/common/auth.c b/drivers/nvme/common/auth.c
index a23ab5c968b9..b707e6b7d263 100644
--- a/drivers/nvme/common/auth.c
+++ b/drivers/nvme/common/auth.c
@@ -471,4 +471,5 @@ int nvme_auth_generate_key(u8 *secret, struct nvme_dhchap_key **ret_key)
}
EXPORT_SYMBOL_GPL(nvme_auth_generate_key);
+MODULE_DESCRIPTION("NVMe Authentication framework");
MODULE_LICENSE("GPL v2");
diff --git a/drivers/nvme/common/keyring.c b/drivers/nvme/common/keyring.c
index a5c0431c101c..394c3948e339 100644
--- a/drivers/nvme/common/keyring.c
+++ b/drivers/nvme/common/keyring.c
@@ -181,5 +181,6 @@ static void __exit nvme_keyring_exit(void)
MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("Hannes Reinecke <hare@suse.de>");
+MODULE_DESCRIPTION("NVMe TLS Keyring implementation");
module_init(nvme_keyring_init);
module_exit(nvme_keyring_exit);
--
2.40.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] nvme-common: add module description
2024-01-31 5:43 [PATCH] nvme-common: add module description Chaitanya Kulkarni
@ 2024-01-31 6:30 ` Christoph Hellwig
2024-01-31 21:01 ` Sagi Grimberg
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2024-01-31 6:30 UTC (permalink / raw)
To: Chaitanya Kulkarni; +Cc: hare, kbusch, hch, sagi, linux-nvme
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-common: add module description
2024-01-31 5:43 [PATCH] nvme-common: add module description Chaitanya Kulkarni
2024-01-31 6:30 ` Christoph Hellwig
@ 2024-01-31 21:01 ` Sagi Grimberg
1 sibling, 0 replies; 3+ messages in thread
From: Sagi Grimberg @ 2024-01-31 21:01 UTC (permalink / raw)
To: Chaitanya Kulkarni, hare; +Cc: kbusch, hch, linux-nvme
> Add MODULE_DESCRIPTION() in order to remove warnings & get clean build:-
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/common/nvme-auth.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/common/nvme-keyring.o
>
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
> ---
> drivers/nvme/common/auth.c | 1 +
> drivers/nvme/common/keyring.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/nvme/common/auth.c b/drivers/nvme/common/auth.c
> index a23ab5c968b9..b707e6b7d263 100644
> --- a/drivers/nvme/common/auth.c
> +++ b/drivers/nvme/common/auth.c
> @@ -471,4 +471,5 @@ int nvme_auth_generate_key(u8 *secret, struct nvme_dhchap_key **ret_key)
> }
> EXPORT_SYMBOL_GPL(nvme_auth_generate_key);
>
> +MODULE_DESCRIPTION("NVMe Authentication framework");
> MODULE_LICENSE("GPL v2");
> diff --git a/drivers/nvme/common/keyring.c b/drivers/nvme/common/keyring.c
> index a5c0431c101c..394c3948e339 100644
> --- a/drivers/nvme/common/keyring.c
> +++ b/drivers/nvme/common/keyring.c
> @@ -181,5 +181,6 @@ static void __exit nvme_keyring_exit(void)
>
> MODULE_LICENSE("GPL v2");
> MODULE_AUTHOR("Hannes Reinecke <hare@suse.de>");
> +MODULE_DESCRIPTION("NVMe TLS Keyring implementation");
iirc, I think Hannes had an intention to make the inband auth
implementation to use nvme keyring as well. So I'd omit TLS from
the description.
Other than that,
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-31 21:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-31 5:43 [PATCH] nvme-common: add module description Chaitanya Kulkarni
2024-01-31 6:30 ` Christoph Hellwig
2024-01-31 21:01 ` Sagi Grimberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.