All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jens Wiklander <jens.wiklander@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
	op-tee@lists.trustedfirmware.org,
	"Shyam Saini" <shyamsaini@linux.microsoft.com>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Jerome Forissier" <jerome.forissier@linaro.org>,
	"Sumit Garg" <sumit.garg@linaro.org>,
	"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
	"Bart Van Assche" <bvanassche@acm.org>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Tomas Winkler" <tomas.winkler@intel.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v2 1/3] rpmb: add Replay Protected Memory Block (RPMB) subsystem
Date: Wed, 31 Jan 2024 13:13:01 -0800	[thread overview]
Message-ID: <2024013108-hamster-audacious-9e3a@gregkh> (raw)
In-Reply-To: <20240131174347.510961-2-jens.wiklander@linaro.org>

On Wed, Jan 31, 2024 at 06:43:45PM +0100, Jens Wiklander wrote:
> +struct class rpmb_class = {

This structure should be marked as 'const', right?

> +	.name = "rpmb",
> +	.dev_release = rpmb_dev_release,
> +};
> +EXPORT_SYMBOL(rpmb_class);

EXPORT_SYMBOL_GPL() to match all the other exports in this file please.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: op-tee@lists.trustedfirmware.org
Subject: Re: [PATCH v2 1/3] rpmb: add Replay Protected Memory Block (RPMB) subsystem
Date: Wed, 31 Jan 2024 13:13:01 -0800	[thread overview]
Message-ID: <2024013108-hamster-audacious-9e3a@gregkh> (raw)
In-Reply-To: <20240131174347.510961-2-jens.wiklander@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

On Wed, Jan 31, 2024 at 06:43:45PM +0100, Jens Wiklander wrote:
> +struct class rpmb_class = {

This structure should be marked as 'const', right?

> +	.name = "rpmb",
> +	.dev_release = rpmb_dev_release,
> +};
> +EXPORT_SYMBOL(rpmb_class);

EXPORT_SYMBOL_GPL() to match all the other exports in this file please.

thanks,

greg k-h

  reply	other threads:[~2024-01-31 21:13 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 17:43 [PATCH v2 0/3] Replay Protected Memory Block (RPMB) subsystem Jens Wiklander
2024-01-31 17:43 ` Jens Wiklander
2024-01-31 17:43 ` [PATCH v2 1/3] rpmb: add " Jens Wiklander
2024-01-31 17:43   ` Jens Wiklander
2024-01-31 21:13   ` Greg Kroah-Hartman [this message]
2024-01-31 21:13     ` Greg Kroah-Hartman
2024-02-01 11:26     ` Jens Wiklander
2024-02-01 11:26       ` Jens Wiklander
2024-02-01  6:04   ` Randy Dunlap
2024-02-01  6:04     ` Randy Dunlap
2024-02-01 11:39     ` Jens Wiklander
2024-02-01 11:39       ` Jens Wiklander
2024-02-06 12:33   ` Ulf Hansson
2024-02-06 12:33     ` Ulf Hansson
2024-02-06 15:10     ` Ilias Apalodimas
2024-02-06 15:10       ` Ilias Apalodimas
2024-02-07  6:11       ` Sumit Garg
2024-02-07  6:11         ` Sumit Garg
2024-02-07  7:25         ` Jens Wiklander
2024-02-07  7:25           ` Jens Wiklander
2024-02-07  7:49           ` Sumit Garg
2024-02-07  7:49             ` Sumit Garg
2024-02-07  8:11             ` Jens Wiklander
2024-02-07  8:11               ` Jens Wiklander
2024-02-07  7:34         ` Ilias Apalodimas
2024-02-07  7:34           ` Ilias Apalodimas
2024-02-07  8:06     ` Jens Wiklander
2024-02-07  8:06       ` Jens Wiklander
2024-02-13 23:16       ` Ulf Hansson
2024-02-13 23:16         ` Ulf Hansson
2024-01-31 17:43 ` [PATCH v2 2/3] mmc: block: register RPMB partition with the RPMB subsystem Jens Wiklander
2024-01-31 17:43   ` Jens Wiklander
2024-02-01  9:18   ` Jorge Ramirez-Ortiz, Foundries
2024-02-01  9:18     ` Jorge Ramirez-Ortiz, Foundries
2024-02-01 11:40     ` Jens Wiklander
2024-02-01 11:40       ` Jens Wiklander
2024-01-31 17:43 ` [PATCH v2 3/3] optee: probe RPMB device using " Jens Wiklander
2024-01-31 17:43   ` Jens Wiklander
2024-02-06 11:12   ` Sumit Garg
2024-02-06 11:12     ` Sumit Garg
2024-02-02  9:59 ` [PATCH v2 0/3] Replay Protected Memory Block (RPMB) subsystem Sumit Garg
2024-02-02  9:59   ` Sumit Garg
2024-02-02 10:46   ` Jens Wiklander
2024-02-02 10:46     ` Jens Wiklander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024013108-hamster-audacious-9e3a@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=alex.bennee@linaro.org \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bvanassche@acm.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jens.wiklander@linaro.org \
    --cc=jerome.forissier@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=op-tee@lists.trustedfirmware.org \
    --cc=rdunlap@infradead.org \
    --cc=shyamsaini@linux.microsoft.com \
    --cc=sumit.garg@linaro.org \
    --cc=tomas.winkler@intel.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.