From: Jakub Kicinski <kuba@kernel.org>
To: Takeru Hayasaka <hayatake396@gmail.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
laforge@gnumonks.org, linux-kernel@vger.kernel.org,
Eric Dumazet <edumazet@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
vladimir.oltean@nxp.com, intel-wired-lan@lists.osuosl.org,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
mailhol.vincent@wanadoo.fr
Subject: Re: [Intel-wired-lan] [PATCH net-next v6] ethtool: ice: Support for RSS settings to GTP from ethtool
Date: Wed, 31 Jan 2024 13:12:58 -0800 [thread overview]
Message-ID: <20240131131258.47c05b7e@kernel.org> (raw)
In-Reply-To: <20240131134621.1017530-1-hayatake396@gmail.com>
On Wed, 31 Jan 2024 13:46:22 +0000 Takeru Hayasaka wrote:
> .../device_drivers/ethernet/intel/ice.rst | 21 ++++-
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 82 +++++++++++++++++++
> drivers/net/ethernet/intel/ice/ice_flow.h | 31 +++++--
> drivers/net/ethernet/intel/ice/ice_lib.c | 37 +++++++++
> include/uapi/linux/ethtool.h | 48 +++++++++++
Could you split the uAPI changes and the driver changes to two separate
commits? You should post them as a patch series, but combining them
into a single commit makes the uAPI addition to easy to miss.
--
pw-bot: cr
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Takeru Hayasaka <hayatake396@gmail.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
mailhol.vincent@wanadoo.fr, vladimir.oltean@nxp.com,
laforge@gnumonks.org
Subject: Re: [PATCH net-next v6] ethtool: ice: Support for RSS settings to GTP from ethtool
Date: Wed, 31 Jan 2024 13:12:58 -0800 [thread overview]
Message-ID: <20240131131258.47c05b7e@kernel.org> (raw)
In-Reply-To: <20240131134621.1017530-1-hayatake396@gmail.com>
On Wed, 31 Jan 2024 13:46:22 +0000 Takeru Hayasaka wrote:
> .../device_drivers/ethernet/intel/ice.rst | 21 ++++-
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 82 +++++++++++++++++++
> drivers/net/ethernet/intel/ice/ice_flow.h | 31 +++++--
> drivers/net/ethernet/intel/ice/ice_lib.c | 37 +++++++++
> include/uapi/linux/ethtool.h | 48 +++++++++++
Could you split the uAPI changes and the driver changes to two separate
commits? You should post them as a patch series, but combining them
into a single commit makes the uAPI addition to easy to miss.
--
pw-bot: cr
next prev parent reply other threads:[~2024-01-31 21:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 13:46 [Intel-wired-lan] [PATCH net-next v6] ethtool: ice: Support for RSS settings to GTP from ethtool Takeru Hayasaka
2024-01-31 13:46 ` Takeru Hayasaka
2024-01-31 21:12 ` Jakub Kicinski [this message]
2024-01-31 21:12 ` Jakub Kicinski
2024-02-01 0:59 ` [Intel-wired-lan] " takeru hayasaka
2024-02-01 0:59 ` takeru hayasaka
2024-02-08 7:34 ` [Intel-wired-lan] " Takeru Hayasaka
2024-02-08 7:34 ` Takeru Hayasaka
2024-02-08 15:23 ` [Intel-wired-lan] " Jakub Kicinski
2024-02-08 15:23 ` Jakub Kicinski
2024-02-08 17:25 ` [Intel-wired-lan] " Takeru Hayasaka
2024-02-08 17:25 ` Takeru Hayasaka
2024-02-09 17:38 ` [Intel-wired-lan] " Simon Horman
2024-02-09 17:38 ` Simon Horman
2024-02-12 2:10 ` [Intel-wired-lan] " Takeru Hayasaka
2024-02-12 2:10 ` Takeru Hayasaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240131131258.47c05b7e@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hayatake396@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=laforge@gnumonks.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.