All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Johan Jonker <jbx6244@gmail.com>
Cc: hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	airlied@gmail.com, daniel@ffwll.ch,
	maarten.lankhorst@linux.intel.com, tzimmermann@suse.de,
	mripard@kernel.org, markyao0591@gmail.com,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/6] dt-bindings: display: rockchip,dw-hdmi: add power-domains property
Date: Wed, 31 Jan 2024 07:59:55 -0600	[thread overview]
Message-ID: <20240131135955.GA966672-robh@kernel.org> (raw)
In-Reply-To: <1ba8b40d-005a-4665-afd9-a4eacf3e3031@gmail.com>

On Tue, Jan 30, 2024 at 03:57:23PM +0100, Johan Jonker wrote:
> Most Rockchip hdmi nodes are part of a power domain.
> Add a power-domains property. Fix example.
> 
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
>  .../bindings/display/rockchip/rockchip,dw-hdmi.yaml   | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> index cd0a42f35f24..6f421740b613 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> @@ -94,6 +94,9 @@ properties:
>        - const: default
>        - const: unwedge
> 
> +  power-domains:
> +    maxItems: 1
> +
>    ports:
>      $ref: /schemas/graph.yaml#/properties/ports
> 
> @@ -141,16 +144,18 @@ examples:
>      #include <dt-bindings/clock/rk3288-cru.h>
>      #include <dt-bindings/interrupt-controller/arm-gic.h>
>      #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/power/rk3288-power.h>
> 
>      hdmi: hdmi@ff980000 {
>          compatible = "rockchip,rk3288-dw-hdmi";
>          reg = <0xff980000 0x20000>;
> -        reg-io-width = <4>;

It makes more sense to keep reg-io-width together with reg.

> -        ddc-i2c-bus = <&i2c5>;
> -        rockchip,grf = <&grf>;
>          interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
>          clocks = <&cru  PCLK_HDMI_CTRL>, <&cru SCLK_HDMI_HDCP>;
>          clock-names = "iahb", "isfr";
> +        ddc-i2c-bus = <&i2c5>;
> +        power-domains = <&power RK3288_PD_VIO>;
> +        reg-io-width = <4>;
> +        rockchip,grf = <&grf>;
> 
>          ports {
>              #address-cells = <1>;
> --
> 2.39.2
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Johan Jonker <jbx6244@gmail.com>
Cc: hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	airlied@gmail.com, daniel@ffwll.ch,
	maarten.lankhorst@linux.intel.com, tzimmermann@suse.de,
	mripard@kernel.org, markyao0591@gmail.com,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/6] dt-bindings: display: rockchip,dw-hdmi: add power-domains property
Date: Wed, 31 Jan 2024 07:59:55 -0600	[thread overview]
Message-ID: <20240131135955.GA966672-robh@kernel.org> (raw)
In-Reply-To: <1ba8b40d-005a-4665-afd9-a4eacf3e3031@gmail.com>

On Tue, Jan 30, 2024 at 03:57:23PM +0100, Johan Jonker wrote:
> Most Rockchip hdmi nodes are part of a power domain.
> Add a power-domains property. Fix example.
> 
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
>  .../bindings/display/rockchip/rockchip,dw-hdmi.yaml   | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> index cd0a42f35f24..6f421740b613 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> @@ -94,6 +94,9 @@ properties:
>        - const: default
>        - const: unwedge
> 
> +  power-domains:
> +    maxItems: 1
> +
>    ports:
>      $ref: /schemas/graph.yaml#/properties/ports
> 
> @@ -141,16 +144,18 @@ examples:
>      #include <dt-bindings/clock/rk3288-cru.h>
>      #include <dt-bindings/interrupt-controller/arm-gic.h>
>      #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/power/rk3288-power.h>
> 
>      hdmi: hdmi@ff980000 {
>          compatible = "rockchip,rk3288-dw-hdmi";
>          reg = <0xff980000 0x20000>;
> -        reg-io-width = <4>;

It makes more sense to keep reg-io-width together with reg.

> -        ddc-i2c-bus = <&i2c5>;
> -        rockchip,grf = <&grf>;
>          interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
>          clocks = <&cru  PCLK_HDMI_CTRL>, <&cru SCLK_HDMI_HDCP>;
>          clock-names = "iahb", "isfr";
> +        ddc-i2c-bus = <&i2c5>;
> +        power-domains = <&power RK3288_PD_VIO>;
> +        reg-io-width = <4>;
> +        rockchip,grf = <&grf>;
> 
>          ports {
>              #address-cells = <1>;
> --
> 2.39.2
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Johan Jonker <jbx6244@gmail.com>
Cc: daniel@ffwll.ch, conor+dt@kernel.org, devicetree@vger.kernel.org,
	tzimmermann@suse.de, hjc@rock-chips.com, mripard@kernel.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	krzysztof.kozlowski+dt@linaro.org, andy.yan@rock-chips.com,
	markyao0591@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 2/6] dt-bindings: display: rockchip,dw-hdmi: add power-domains property
Date: Wed, 31 Jan 2024 07:59:55 -0600	[thread overview]
Message-ID: <20240131135955.GA966672-robh@kernel.org> (raw)
In-Reply-To: <1ba8b40d-005a-4665-afd9-a4eacf3e3031@gmail.com>

On Tue, Jan 30, 2024 at 03:57:23PM +0100, Johan Jonker wrote:
> Most Rockchip hdmi nodes are part of a power domain.
> Add a power-domains property. Fix example.
> 
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
>  .../bindings/display/rockchip/rockchip,dw-hdmi.yaml   | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> index cd0a42f35f24..6f421740b613 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> @@ -94,6 +94,9 @@ properties:
>        - const: default
>        - const: unwedge
> 
> +  power-domains:
> +    maxItems: 1
> +
>    ports:
>      $ref: /schemas/graph.yaml#/properties/ports
> 
> @@ -141,16 +144,18 @@ examples:
>      #include <dt-bindings/clock/rk3288-cru.h>
>      #include <dt-bindings/interrupt-controller/arm-gic.h>
>      #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/power/rk3288-power.h>
> 
>      hdmi: hdmi@ff980000 {
>          compatible = "rockchip,rk3288-dw-hdmi";
>          reg = <0xff980000 0x20000>;
> -        reg-io-width = <4>;

It makes more sense to keep reg-io-width together with reg.

> -        ddc-i2c-bus = <&i2c5>;
> -        rockchip,grf = <&grf>;
>          interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
>          clocks = <&cru  PCLK_HDMI_CTRL>, <&cru SCLK_HDMI_HDCP>;
>          clock-names = "iahb", "isfr";
> +        ddc-i2c-bus = <&i2c5>;
> +        power-domains = <&power RK3288_PD_VIO>;
> +        reg-io-width = <4>;
> +        rockchip,grf = <&grf>;
> 
>          ports {
>              #address-cells = <1>;
> --
> 2.39.2
> 

  parent reply	other threads:[~2024-01-31 14:00 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-30 14:55 [PATCH v1 1/6] dt-bindings: display: rockchip: rockchip,dw-hdmi: deprecate port property Johan Jonker
2024-01-30 14:55 ` Johan Jonker
2024-01-30 14:55 ` Johan Jonker
2024-01-30 14:57 ` [PATCH v1 2/6] dt-bindings: display: rockchip,dw-hdmi: add power-domains property Johan Jonker
2024-01-30 14:57   ` Johan Jonker
2024-01-30 14:57   ` Johan Jonker
2024-01-30 18:05   ` Conor Dooley
2024-01-30 18:05     ` Conor Dooley
2024-01-30 18:05     ` Conor Dooley
2024-01-31 13:59   ` Rob Herring [this message]
2024-01-31 13:59     ` Rob Herring
2024-01-31 13:59     ` Rob Herring
2024-01-30 14:57 ` [PATCH v1 3/6] ARM: dts: rockchip: fix rk3288 hdmi ports node Johan Jonker
2024-01-30 14:57   ` Johan Jonker
2024-01-30 14:57   ` Johan Jonker
2024-01-30 14:57 ` [PATCH v1 4/6] ARM: dts: rockchip: fix rk322x " Johan Jonker
2024-01-30 14:57   ` Johan Jonker
2024-01-30 14:57   ` Johan Jonker
2024-01-30 14:58 ` [PATCH v1 5/6] arm64: dts: rockchip: fix rk3328 " Johan Jonker
2024-01-30 14:58   ` Johan Jonker
2024-01-30 14:58   ` Johan Jonker
2024-01-30 14:58 ` [PATCH v1 6/6] arm64: dts: rockchip: fix rk3399 " Johan Jonker
2024-01-30 14:58   ` Johan Jonker
2024-01-30 14:58   ` Johan Jonker
2024-01-30 18:18 ` [PATCH v1 1/6] dt-bindings: display: rockchip: rockchip,dw-hdmi: deprecate port property Conor Dooley
2024-01-30 18:18   ` [PATCH v1 1/6] dt-bindings: display: rockchip: rockchip, dw-hdmi: " Conor Dooley
2024-01-30 18:18   ` [PATCH v1 1/6] dt-bindings: display: rockchip: rockchip,dw-hdmi: " Conor Dooley
2024-01-31 14:15   ` Rob Herring
2024-01-31 14:15     ` [PATCH v1 1/6] dt-bindings: display: rockchip: rockchip, dw-hdmi: " Rob Herring
2024-01-31 14:15     ` [PATCH v1 1/6] dt-bindings: display: rockchip: rockchip,dw-hdmi: " Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240131135955.GA966672-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=airlied@gmail.com \
    --cc=andy.yan@rock-chips.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=jbx6244@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=markyao0591@gmail.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.