Re: [PATCH v3 1/2] dt-bindings: arm: coresight: Remove pattern match of ETE node name

From: Rob Herring <robh@kernel.org>
To: Mao Jinlong <quic_jinlmao@quicinc.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@linaro.org>,
	James Clark <james.clark@arm.com>, Leo Yan <leo.yan@linaro.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	Tingwei Zhang <quic_tingweiz@quicinc.com>,
	Yuanfang Zhang <quic_yuanfang@quicinc.com>,
	Tao Zhang <quic_taozha@quicinc.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: coresight: Remove pattern match of ETE node name
Date: Wed, 31 Jan 2024 08:55:01 -0600	[thread overview]
Message-ID: <20240131145501.GA1254056-robh@kernel.org> (raw)
In-Reply-To: <20240119092500.7154-2-quic_jinlmao@quicinc.com>

On Fri, Jan 19, 2024 at 01:24:57AM -0800, Mao Jinlong wrote:
> Remove pattern match of ETE node name. Use ete as the name for ete nodes.
> 
> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
> ---
>  .../bindings/arm/arm,embedded-trace-extension.yaml          | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
> index f725e6940993..a10a570bd9bc 100644
> --- a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
> +++ b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
> @@ -22,8 +22,6 @@ description: |
>    with any optional connection graph as per the coresight bindings.
>  
>  properties:
> -  $nodename:
> -    pattern: "^ete([0-9a-f]+)$"

I prefer we keep something here. '^ete-' or '^ete-[0-9]+$'.

>    compatible:
>      items:
>        - const: arm,embedded-trace-extension
> @@ -55,13 +53,13 @@ examples:
>  
>  # An ETE node without legacy CoreSight connections
>    - |
> -    ete0 {
> +    ete {
>        compatible = "arm,embedded-trace-extension";
>        cpu = <&cpu_0>;
>      };
>  # An ETE node with legacy CoreSight connections
>    - |
> -   ete1 {
> +   ete {
>        compatible = "arm,embedded-trace-extension";
>        cpu = <&cpu_1>;
>  
> -- 
> 2.41.0
> 