From: Simon Horman <horms@kernel.org>
To: Steven Zou <steven.zou@intel.com>
Cc: jan.sokolowski@intel.com, netdev@vger.kernel.org,
andrii.staikov@intel.com, aleksander.lobakin@intel.com,
intel-wired-lan@lists.osuosl.org, przemyslaw.kitszel@intel.com,
andriy.shevchenko@linux.intel.com
Subject: Re: [Intel-wired-lan] [PATCH RESEND iwl-next 2/2] ice: Add switch recipe reusing feature
Date: Thu, 1 Feb 2024 10:39:52 +0100 [thread overview]
Message-ID: <20240201093952.GC514352@kernel.org> (raw)
In-Reply-To: <20240130025146.30265-3-steven.zou@intel.com>
On Tue, Jan 30, 2024 at 10:51:46AM +0800, Steven Zou wrote:
> New E810 firmware supports the corresponding functionality, so the driver
> allows PFs to subscribe the same switch recipes. Then when the PF is done
> with a switch recipes, the PF can ask firmware to free that switch recipe.
>
> When users configure a rule to PFn into E810 switch component, if there is
> no existing recipe matching this rule's pattern, the driver will request
> firmware to allocate and return a new recipe resource for the rule by
> calling ice_add_sw_recipe() and ice_alloc_recipe(). If there is an existing
> recipe matching this rule's pattern with different key value, or this is a
> same second rule to PFm into switch component, the driver checks out this
> recipe by calling ice_find_recp(), the driver will tell firmware to share
> using this same recipe resource by calling ice_subscribable_recp_shared()
> and ice_subscribe_recipe().
>
> When firmware detects that all subscribing PFs have freed the switch
> recipe, firmware will free the switch recipe so that it can be reused.
>
> This feature also fixes a problem where all switch recipes would eventually
> be exhausted because switch recipes could not be freed, as freeing a shared
> recipe could potentially break other PFs that were using it.
>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Reviewed-by: Andrii Staikov <andrii.staikov@intel.com>
> Signed-off-by: Steven Zou <steven.zou@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Steven Zou <steven.zou@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
przemyslaw.kitszel@intel.com, andriy.shevchenko@linux.intel.com,
aleksander.lobakin@intel.com, andrii.staikov@intel.com,
jan.sokolowski@intel.com
Subject: Re: [PATCH RESEND iwl-next 2/2] ice: Add switch recipe reusing feature
Date: Thu, 1 Feb 2024 10:39:52 +0100 [thread overview]
Message-ID: <20240201093952.GC514352@kernel.org> (raw)
In-Reply-To: <20240130025146.30265-3-steven.zou@intel.com>
On Tue, Jan 30, 2024 at 10:51:46AM +0800, Steven Zou wrote:
> New E810 firmware supports the corresponding functionality, so the driver
> allows PFs to subscribe the same switch recipes. Then when the PF is done
> with a switch recipes, the PF can ask firmware to free that switch recipe.
>
> When users configure a rule to PFn into E810 switch component, if there is
> no existing recipe matching this rule's pattern, the driver will request
> firmware to allocate and return a new recipe resource for the rule by
> calling ice_add_sw_recipe() and ice_alloc_recipe(). If there is an existing
> recipe matching this rule's pattern with different key value, or this is a
> same second rule to PFm into switch component, the driver checks out this
> recipe by calling ice_find_recp(), the driver will tell firmware to share
> using this same recipe resource by calling ice_subscribable_recp_shared()
> and ice_subscribe_recipe().
>
> When firmware detects that all subscribing PFs have freed the switch
> recipe, firmware will free the switch recipe so that it can be reused.
>
> This feature also fixes a problem where all switch recipes would eventually
> be exhausted because switch recipes could not be freed, as freeing a shared
> recipe could potentially break other PFs that were using it.
>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Reviewed-by: Andrii Staikov <andrii.staikov@intel.com>
> Signed-off-by: Steven Zou <steven.zou@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-02-01 9:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 2:51 [Intel-wired-lan] [PATCH RESEND iwl-next 0/2] ice: Introduce switch recipe reusing Steven Zou
2024-01-30 2:51 ` Steven Zou
2024-01-30 2:51 ` [Intel-wired-lan] [PATCH RESEND iwl-next 1/2] ice: Refactor FW data type and fix bitmap casting issue Steven Zou
2024-01-30 2:51 ` Steven Zou
2024-01-30 2:51 ` [Intel-wired-lan] [PATCH RESEND iwl-next 2/2] ice: Add switch recipe reusing feature Steven Zou
2024-01-30 2:51 ` Steven Zou
2024-02-01 9:39 ` Simon Horman [this message]
2024-02-01 9:39 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201093952.GC514352@kernel.org \
--to=horms@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrii.staikov@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jan.sokolowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=steven.zou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.