From: Nicholas Piggin <npiggin@gmail.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Nicholas Piggin <npiggin@gmail.com>,
kvm@vger.kernel.org, Laurent Vivier <lvivier@redhat.com>,
"Shaoqin Huang" <shahuang@redhat.com>,
Andrew Jones <andrew.jones@linux.dev>,
Nico Boehr <nrb@linux.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Eric Auger <eric.auger@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Marc Hartmayer <mhartmay@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
kvmarm@lists.linux.dev
Subject: [kvm-unit-tests PATCH v2 7/9] migration: Add quiet migration support
Date: Fri, 2 Feb 2024 16:57:38 +1000 [thread overview]
Message-ID: <20240202065740.68643-8-npiggin@gmail.com> (raw)
In-Reply-To: <20240202065740.68643-1-npiggin@gmail.com>
Console output required to support migration becomes quite noisy
when doing lots of migrations. Provide a migrate_quiet() call that
suppresses console output and doesn't log a message.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
lib/migrate.c | 12 ++++++++++++
lib/migrate.h | 1 +
scripts/arch-run.bash | 4 ++--
3 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/lib/migrate.c b/lib/migrate.c
index b7721659..4e0ab516 100644
--- a/lib/migrate.c
+++ b/lib/migrate.c
@@ -18,6 +18,18 @@ void migrate(void)
report_info("Migration complete");
}
+/*
+ * Like migrate() but supporess output and logs, useful for intensive
+ * migration stress testing without polluting logs. Test cases should
+ * provide relevant information about migration in failure reports.
+ */
+void migrate_quiet(void)
+{
+ puts("Now migrate the VM (quiet)\n");
+ (void)getchar();
+}
+
+
/*
* Initiate migration and wait for it to complete.
* If this function is called more than once, it is a no-op.
diff --git a/lib/migrate.h b/lib/migrate.h
index 2af06a72..95b9102b 100644
--- a/lib/migrate.h
+++ b/lib/migrate.h
@@ -7,4 +7,5 @@
*/
void migrate(void);
+void migrate_quiet(void);
void migrate_once(void);
diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash
index 0feaa190..5810f9a1 100644
--- a/scripts/arch-run.bash
+++ b/scripts/arch-run.bash
@@ -154,7 +154,7 @@ run_migration ()
-chardev socket,id=mon,path=${src_qmp},server=on,wait=off \
-mon chardev=mon,mode=control > ${src_outfifo} &
live_pid=$!
- cat ${src_outfifo} | tee ${src_out} &
+ cat ${src_outfifo} | tee ${src_out} | grep -v "Now migrate the VM (quiet)" &
# The test must prompt the user to migrate, so wait for the "migrate"
# keyword
@@ -202,7 +202,7 @@ do_migration ()
-mon chardev=mon,mode=control -incoming unix:${dst_incoming} \
< <(cat ${dst_infifo}) > ${dst_outfifo} &
incoming_pid=$!
- cat ${dst_outfifo} | tee ${dst_out} &
+ cat ${dst_outfifo} | tee ${dst_out} | grep -v "Now migrate the VM (quiet)" &
# The test must prompt the user to migrate, so wait for the "migrate" keyword
while ! grep -q -i "Now migrate the VM" < ${src_out} ; do
--
2.42.0
WARNING: multiple messages have this Message-ID (diff)
From: Nicholas Piggin <npiggin@gmail.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
linux-s390@vger.kernel.org, Nico Boehr <nrb@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
kvm@vger.kernel.org, David Hildenbrand <david@redhat.com>,
linuxppc-dev@lists.ozlabs.org,
Shaoqin Huang <shahuang@redhat.com>,
Nicholas Piggin <npiggin@gmail.com>,
Andrew Jones <andrew.jones@linux.dev>,
Eric Auger <eric.auger@redhat.com>,
Marc Hartmayer <mhartmay@linux.ibm.com>,
kvmarm@lists.linux.dev, Paolo Bonzini <pbonzini@redhat.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>
Subject: [kvm-unit-tests PATCH v2 7/9] migration: Add quiet migration support
Date: Fri, 2 Feb 2024 16:57:38 +1000 [thread overview]
Message-ID: <20240202065740.68643-8-npiggin@gmail.com> (raw)
In-Reply-To: <20240202065740.68643-1-npiggin@gmail.com>
Console output required to support migration becomes quite noisy
when doing lots of migrations. Provide a migrate_quiet() call that
suppresses console output and doesn't log a message.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
lib/migrate.c | 12 ++++++++++++
lib/migrate.h | 1 +
scripts/arch-run.bash | 4 ++--
3 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/lib/migrate.c b/lib/migrate.c
index b7721659..4e0ab516 100644
--- a/lib/migrate.c
+++ b/lib/migrate.c
@@ -18,6 +18,18 @@ void migrate(void)
report_info("Migration complete");
}
+/*
+ * Like migrate() but supporess output and logs, useful for intensive
+ * migration stress testing without polluting logs. Test cases should
+ * provide relevant information about migration in failure reports.
+ */
+void migrate_quiet(void)
+{
+ puts("Now migrate the VM (quiet)\n");
+ (void)getchar();
+}
+
+
/*
* Initiate migration and wait for it to complete.
* If this function is called more than once, it is a no-op.
diff --git a/lib/migrate.h b/lib/migrate.h
index 2af06a72..95b9102b 100644
--- a/lib/migrate.h
+++ b/lib/migrate.h
@@ -7,4 +7,5 @@
*/
void migrate(void);
+void migrate_quiet(void);
void migrate_once(void);
diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash
index 0feaa190..5810f9a1 100644
--- a/scripts/arch-run.bash
+++ b/scripts/arch-run.bash
@@ -154,7 +154,7 @@ run_migration ()
-chardev socket,id=mon,path=${src_qmp},server=on,wait=off \
-mon chardev=mon,mode=control > ${src_outfifo} &
live_pid=$!
- cat ${src_outfifo} | tee ${src_out} &
+ cat ${src_outfifo} | tee ${src_out} | grep -v "Now migrate the VM (quiet)" &
# The test must prompt the user to migrate, so wait for the "migrate"
# keyword
@@ -202,7 +202,7 @@ do_migration ()
-mon chardev=mon,mode=control -incoming unix:${dst_incoming} \
< <(cat ${dst_infifo}) > ${dst_outfifo} &
incoming_pid=$!
- cat ${dst_outfifo} | tee ${dst_out} &
+ cat ${dst_outfifo} | tee ${dst_out} | grep -v "Now migrate the VM (quiet)" &
# The test must prompt the user to migrate, so wait for the "migrate" keyword
while ! grep -q -i "Now migrate the VM" < ${src_out} ; do
--
2.42.0
next prev parent reply other threads:[~2024-02-02 6:59 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 6:57 [kvm-unit-tests PATCH v2 0/9] Multi-migration support Nicholas Piggin
2024-02-02 6:57 ` Nicholas Piggin
2024-02-02 6:57 ` [kvm-unit-tests PATCH v2 1/9] (arm|powerpc|s390x): Makefile: Fix .aux.o generation Nicholas Piggin
2024-02-02 6:57 ` Nicholas Piggin
2024-02-02 9:30 ` Andrew Jones
2024-02-02 9:30 ` Andrew Jones
2024-02-05 11:28 ` Thomas Huth
2024-02-05 11:28 ` Thomas Huth
2024-02-05 14:20 ` Marc Hartmayer
2024-02-05 14:20 ` Marc Hartmayer
2024-02-02 6:57 ` [kvm-unit-tests PATCH v2 2/9] arch-run: Clean up temporary files properly Nicholas Piggin
2024-02-02 6:57 ` Nicholas Piggin
2024-02-07 7:58 ` Thomas Huth
2024-02-07 7:58 ` Thomas Huth
2024-02-09 5:01 ` Nicholas Piggin
2024-02-09 5:01 ` Nicholas Piggin
2024-02-02 6:57 ` [kvm-unit-tests PATCH v2 3/9] arch-run: Clean up initrd cleanup Nicholas Piggin
2024-02-02 6:57 ` Nicholas Piggin
2024-02-05 12:04 ` Thomas Huth
2024-02-05 12:04 ` Thomas Huth
2024-02-06 5:20 ` Nicholas Piggin
2024-02-06 5:20 ` Nicholas Piggin
2024-02-02 6:57 ` [kvm-unit-tests PATCH v2 4/9] migration: use a more robust way to wait for background job Nicholas Piggin
2024-02-02 6:57 ` Nicholas Piggin
2024-02-05 14:58 ` Marc Hartmayer
2024-02-05 14:58 ` Marc Hartmayer
2024-02-06 6:50 ` Nicholas Piggin
2024-02-06 6:50 ` Nicholas Piggin
2024-02-02 6:57 ` [kvm-unit-tests PATCH v2 5/9] migration: Support multiple migrations Nicholas Piggin
2024-02-02 6:57 ` Nicholas Piggin
2024-02-02 6:57 ` [kvm-unit-tests PATCH v2 6/9] arch-run: rename migration variables Nicholas Piggin
2024-02-02 6:57 ` Nicholas Piggin
2024-02-02 6:57 ` Nicholas Piggin [this message]
2024-02-02 6:57 ` [kvm-unit-tests PATCH v2 7/9] migration: Add quiet migration support Nicholas Piggin
2024-02-02 6:57 ` [kvm-unit-tests PATCH v2 8/9] Add common/ directory for architecture-independent tests Nicholas Piggin
2024-02-02 6:57 ` Nicholas Piggin
2024-02-02 6:57 ` [kvm-unit-tests PATCH v2 9/9] migration: add a migration selftest Nicholas Piggin
2024-02-02 6:57 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240202065740.68643-8-npiggin@gmail.com \
--to=npiggin@gmail.com \
--cc=alexandru.elisei@arm.com \
--cc=andrew.jones@linux.dev \
--cc=david@redhat.com \
--cc=eric.auger@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lvivier@redhat.com \
--cc=mhartmay@linux.ibm.com \
--cc=nrb@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=shahuang@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.