From: "Theodore Ts'o" <tytso@mit.edu>
To: Gabriel Krisman Bertazi <krisman@suse.de>
Cc: ebiggers@kernel.org, viro@zeniv.linux.org.uk, jaegeuk@kernel.org,
amir73il@gmail.com, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v5 09/12] ext4: Configure dentry operations at dentry-creation time
Date: Fri, 2 Feb 2024 10:56:46 -0500 [thread overview]
Message-ID: <20240202155646.GB119530@mit.edu> (raw)
In-Reply-To: <20240129204330.32346-10-krisman@suse.de>
On Mon, Jan 29, 2024 at 05:43:27PM -0300, Gabriel Krisman Bertazi wrote:
> This was already the case for case-insensitive before commit
> bb9cd9106b22 ("fscrypt: Have filesystems handle their d_ops"), but it
> was changed to set at lookup-time to facilitate the integration with
> fscrypt. But it's a problem because dentries that don't get created
> through ->lookup() won't have any visibility of the operations.
>
> Since fscrypt now also supports configuring dentry operations at
> creation-time, do it for any encrypted and/or casefold volume,
> simplifying the implementation across these features.
>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@suse.de>
Acked-by: Theodore Ts'o <tytso@mit.edu>
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Ts'o" <tytso@mit.edu>
To: Gabriel Krisman Bertazi <krisman@suse.de>
Cc: amir73il@gmail.com, linux-f2fs-devel@lists.sourceforge.net,
ebiggers@kernel.org, viro@zeniv.linux.org.uk,
linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org,
linux-ext4@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v5 09/12] ext4: Configure dentry operations at dentry-creation time
Date: Fri, 2 Feb 2024 10:56:46 -0500 [thread overview]
Message-ID: <20240202155646.GB119530@mit.edu> (raw)
In-Reply-To: <20240129204330.32346-10-krisman@suse.de>
On Mon, Jan 29, 2024 at 05:43:27PM -0300, Gabriel Krisman Bertazi wrote:
> This was already the case for case-insensitive before commit
> bb9cd9106b22 ("fscrypt: Have filesystems handle their d_ops"), but it
> was changed to set at lookup-time to facilitate the integration with
> fscrypt. But it's a problem because dentries that don't get created
> through ->lookup() won't have any visibility of the operations.
>
> Since fscrypt now also supports configuring dentry operations at
> creation-time, do it for any encrypted and/or casefold volume,
> simplifying the implementation across these features.
>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@suse.de>
Acked-by: Theodore Ts'o <tytso@mit.edu>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2024-02-02 15:57 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 20:43 [PATCH v5 00/12] Set casefold/fscrypt dentry operations through sb->s_d_op Gabriel Krisman Bertazi
2024-01-29 20:43 ` [f2fs-dev] " Gabriel Krisman Bertazi
2024-01-29 20:43 ` [PATCH v5 01/12] ovl: Reject mounting over case-insensitive directories Gabriel Krisman Bertazi
2024-01-29 20:43 ` [f2fs-dev] " Gabriel Krisman Bertazi
2024-01-31 0:22 ` Eric Biggers
2024-01-31 0:22 ` [f2fs-dev] " Eric Biggers
2024-01-31 0:31 ` Gabriel Krisman Bertazi
2024-01-31 0:31 ` [f2fs-dev] " Gabriel Krisman Bertazi
2024-01-29 20:43 ` [PATCH v5 02/12] fscrypt: Factor out a helper to configure the lookup dentry Gabriel Krisman Bertazi
2024-01-29 20:43 ` [f2fs-dev] " Gabriel Krisman Bertazi
2024-01-31 0:29 ` Eric Biggers
2024-01-31 0:29 ` [f2fs-dev] " Eric Biggers
2024-01-29 20:43 ` [PATCH v5 03/12] fscrypt: Call fscrypt_prepare_lookup_dentry on unencrypted dentries Gabriel Krisman Bertazi
2024-01-29 20:43 ` [f2fs-dev] " Gabriel Krisman Bertazi
2024-01-29 20:43 ` [PATCH v5 04/12] fscrypt: Drop d_revalidate for valid dentries during lookup Gabriel Krisman Bertazi
2024-01-29 20:43 ` [f2fs-dev] " Gabriel Krisman Bertazi
2024-01-31 0:47 ` Eric Biggers
2024-01-31 0:47 ` [f2fs-dev] " Eric Biggers
2024-01-31 18:35 ` Gabriel Krisman Bertazi
2024-01-31 18:35 ` [f2fs-dev] " Gabriel Krisman Bertazi
2024-02-01 3:24 ` Eric Biggers
2024-02-01 3:24 ` [f2fs-dev] " Eric Biggers
2024-02-02 14:50 ` Gabriel Krisman Bertazi
2024-02-02 14:50 ` [f2fs-dev] " Gabriel Krisman Bertazi
2024-02-09 14:03 ` Christian Brauner
2024-02-09 14:03 ` [f2fs-dev] " Christian Brauner
2024-02-09 14:46 ` Gabriel Krisman Bertazi
2024-02-09 14:46 ` [f2fs-dev] " Gabriel Krisman Bertazi
2024-01-29 20:43 ` [PATCH v5 05/12] fscrypt: Drop d_revalidate once the key is added Gabriel Krisman Bertazi
2024-01-29 20:43 ` [f2fs-dev] " Gabriel Krisman Bertazi
2024-01-29 20:43 ` [PATCH v5 06/12] fscrypt: Ignore plaintext dentries during d_move Gabriel Krisman Bertazi
2024-01-29 20:43 ` [f2fs-dev] " Gabriel Krisman Bertazi
2024-01-31 0:55 ` Eric Biggers
2024-01-31 0:55 ` [f2fs-dev] " Eric Biggers
2024-01-29 20:43 ` [PATCH v5 07/12] libfs: Merge encrypted_ci_dentry_ops and ci_dentry_ops Gabriel Krisman Bertazi
2024-01-29 20:43 ` [f2fs-dev] " Gabriel Krisman Bertazi
2024-01-31 1:00 ` Eric Biggers
2024-01-31 1:00 ` [f2fs-dev] " Eric Biggers
2024-01-29 20:43 ` [PATCH v5 08/12] libfs: Add helper to choose dentry operations at mount-time Gabriel Krisman Bertazi
2024-01-29 20:43 ` [f2fs-dev] " Gabriel Krisman Bertazi
2024-01-29 20:43 ` [PATCH v5 09/12] ext4: Configure dentry operations at dentry-creation time Gabriel Krisman Bertazi
2024-01-29 20:43 ` [f2fs-dev] " Gabriel Krisman Bertazi
2024-02-02 15:56 ` Theodore Ts'o [this message]
2024-02-02 15:56 ` Theodore Ts'o
2024-01-29 20:43 ` [PATCH v5 10/12] f2fs: " Gabriel Krisman Bertazi
2024-01-29 20:43 ` [f2fs-dev] " Gabriel Krisman Bertazi
2024-01-29 20:43 ` [PATCH v5 11/12] ubifs: " Gabriel Krisman Bertazi
2024-01-29 20:43 ` [f2fs-dev] " Gabriel Krisman Bertazi
2024-01-29 20:43 ` [PATCH v5 12/12] libfs: Drop generic_set_encrypted_ci_d_ops Gabriel Krisman Bertazi
2024-01-29 20:43 ` [f2fs-dev] " Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240202155646.GB119530@mit.edu \
--to=tytso@mit.edu \
--cc=amir73il@gmail.com \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=krisman@suse.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.