All of lore.kernel.org
 help / color / mirror / Atom feed
* [dhowells-fs:rxrpc-iothread 23/24] net/rxrpc/output.c:270:60: error: 'empty_zero_page' undeclared; did you mean 'memzero_page'?
@ 2024-02-02 16:05 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-02-02 16:05 UTC (permalink / raw)
  To: David Howells; +Cc: oe-kbuild-all

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-iothread
head:   975bd4732a7b88c6ec05685c43b639000f888fbe
commit: 83f863dfba3ae06a4b4f5369c46e9a39594d6da9 [23/24] rxrpc: Implement path-MTU probing using padded PING ACKs (RFC8899)
config: sparc-allmodconfig (https://download.01.org/0day-ci/archive/20240202/202402022326.jwuMkYNM-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240202/202402022326.jwuMkYNM-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402022326.jwuMkYNM-lkp@intel.com/

All errors (new ones prefixed by >>):

   net/rxrpc/output.c: In function 'rxrpc_send_ACK':
>> net/rxrpc/output.c:270:60: error: 'empty_zero_page' undeclared (first use in this function); did you mean 'memzero_page'?
     270 |                         txb->kvec[txb->nr_kvec].iov_base = empty_zero_page;
         |                                                            ^~~~~~~~~~~~~~~
         |                                                            memzero_page
   net/rxrpc/output.c:270:60: note: each undeclared identifier is reported only once for each function it appears in
--
   net/rxrpc/txbuf.c: In function 'rxrpc_free_txbuf':
>> net/rxrpc/txbuf.c:183:46: error: 'empty_zero_page' undeclared (first use in this function); did you mean 'memzero_page'?
     183 |                     txb->kvec[i].iov_base != empty_zero_page)
         |                                              ^~~~~~~~~~~~~~~
         |                                              memzero_page
   net/rxrpc/txbuf.c:183:46: note: each undeclared identifier is reported only once for each function it appears in


vim +270 net/rxrpc/output.c

   237	
   238	/*
   239	 * Queue an ACK for immediate transmission.
   240	 */
   241	void rxrpc_send_ACK(struct rxrpc_call *call, u8 ack_reason,
   242			    rxrpc_serial_t serial, enum rxrpc_propose_ack_trace why)
   243	{
   244		struct rxrpc_txbuf *txb;
   245	
   246		if (test_bit(RXRPC_CALL_DISCONNECTED, &call->flags))
   247			return;
   248	
   249		rxrpc_inc_stat(call->rxnet, stat_tx_acks[ack_reason]);
   250	
   251		txb = rxrpc_alloc_ack_txbuf(call, call->ackr_wtop - call->ackr_window);
   252		if (!txb) {
   253			kleave(" = -ENOMEM");
   254			return;
   255		}
   256	
   257		txb->ack_why = why;
   258	
   259		rxrpc_fill_out_ack(call, txb, ack_reason, serial);
   260	
   261		/* Extend a path MTU probe ACK. */
   262		if (why == rxrpc_propose_ack_ping_for_mtu_probe) {
   263			size_t probe_mtu = call->peer->pmtud_trial + sizeof(struct rxrpc_wire_header);
   264	
   265			if (txb->len > probe_mtu)
   266				goto skip;
   267			while (txb->len < probe_mtu) {
   268				size_t part = min_t(size_t, probe_mtu - txb->len, PAGE_SIZE);
   269	
 > 270				txb->kvec[txb->nr_kvec].iov_base = empty_zero_page;
   271				txb->kvec[txb->nr_kvec].iov_len = part;
   272				txb->len += part;
   273				txb->nr_kvec++;
   274			}
   275		}
   276	
   277		call->ackr_nr_unacked = 0;
   278		atomic_set(&call->ackr_nr_consumed, 0);
   279		clear_bit(RXRPC_CALL_RX_IS_IDLE, &call->flags);
   280	
   281		trace_rxrpc_send_ack(call, why, ack_reason, serial);
   282		rxrpc_send_ack_packet(call, txb, why);
   283	skip:
   284		rxrpc_put_txbuf(txb, rxrpc_txbuf_put_ack_tx);
   285	}
   286	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-02-02 16:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-02 16:05 [dhowells-fs:rxrpc-iothread 23/24] net/rxrpc/output.c:270:60: error: 'empty_zero_page' undeclared; did you mean 'memzero_page'? kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.