* [qais-yousef:improve-sched-cpufreq-interaction 1/1] kernel/sched/core.c:5129:36: error: 'cpufreq_update_enabled' undeclared; did you mean 'cpufreq_boost_enabled'?
@ 2024-02-03 11:07 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-02-03 11:07 UTC (permalink / raw)
To: Qais Yousef; +Cc: oe-kbuild-all
tree: https://github.com/qais-yousef/linux improve-sched-cpufreq-interaction
head: 787874f453b03230a3fcde689b1c6b68355e2f40
commit: 787874f453b03230a3fcde689b1c6b68355e2f40 [1/1] sched: Consolidate cpufreq updates
config: alpha-allnoconfig (https://download.01.org/0day-ci/archive/20240203/202402031907.7fDaITAG-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240203/202402031907.7fDaITAG-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402031907.7fDaITAG-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/linux/export.h:5,
from include/linux/linkage.h:7,
from include/linux/fs.h:5,
from include/linux/highmem.h:5,
from kernel/sched/core.c:9:
kernel/sched/core.c: In function 'update_cpufreq_ctx_switch':
>> kernel/sched/core.c:5129:36: error: 'cpufreq_update_enabled' undeclared (first use in this function); did you mean 'cpufreq_boost_enabled'?
5129 | if (!static_branch_likely(&cpufreq_update_enabled))
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/compiler.h:76:45: note: in definition of macro 'likely'
76 | # define likely(x) __builtin_expect(!!(x), 1)
| ^
include/linux/jump_label.h:508:41: note: in expansion of macro 'likely_notrace'
508 | #define static_branch_likely(x) likely_notrace(static_key_enabled(&(x)->key))
| ^~~~~~~~~~~~~~
include/linux/jump_label.h:508:56: note: in expansion of macro 'static_key_enabled'
508 | #define static_branch_likely(x) likely_notrace(static_key_enabled(&(x)->key))
| ^~~~~~~~~~~~~~~~~~
kernel/sched/core.c:5129:14: note: in expansion of macro 'static_branch_likely'
5129 | if (!static_branch_likely(&cpufreq_update_enabled))
| ^~~~~~~~~~~~~~~~~~~~
kernel/sched/core.c:5129:36: note: each undeclared identifier is reported only once for each function it appears in
5129 | if (!static_branch_likely(&cpufreq_update_enabled))
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/compiler.h:76:45: note: in definition of macro 'likely'
76 | # define likely(x) __builtin_expect(!!(x), 1)
| ^
include/linux/jump_label.h:508:41: note: in expansion of macro 'likely_notrace'
508 | #define static_branch_likely(x) likely_notrace(static_key_enabled(&(x)->key))
| ^~~~~~~~~~~~~~
include/linux/jump_label.h:508:56: note: in expansion of macro 'static_key_enabled'
508 | #define static_branch_likely(x) likely_notrace(static_key_enabled(&(x)->key))
| ^~~~~~~~~~~~~~~~~~
kernel/sched/core.c:5129:14: note: in expansion of macro 'static_branch_likely'
5129 | if (!static_branch_likely(&cpufreq_update_enabled))
| ^~~~~~~~~~~~~~~~~~~~
kernel/sched/core.c:5146:37: error: 'struct cfs_rq' has no member named 'decayed'
5146 | if (unlikely(rq->cfs.decayed)) {
| ^
include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
77 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
kernel/sched/core.c:5147:32: error: 'struct cfs_rq' has no member named 'decayed'
5147 | rq->cfs.decayed = false;
| ^
vim +5129 kernel/sched/core.c
5126
5127 static inline void update_cpufreq_ctx_switch(struct rq *rq)
5128 {
> 5129 if (!static_branch_likely(&cpufreq_update_enabled))
5130 return;
5131
5132 if (unlikely(current->sched_class == &stop_sched_class))
5133 return;
5134
5135 if (unlikely(current->sched_class == &idle_sched_class))
5136 return;
5137
5138 if (unlikely(task_has_idle_policy(current)))
5139 return;
5140
5141 if (likely(fair_policy(current->policy))) {
5142
5143 /*
5144 * Allow cpufreq updates once for every update_load_avg() decay.
5145 */
5146 if (unlikely(rq->cfs.decayed)) {
5147 rq->cfs.decayed = false;
5148 goto force_update;
5149 }
5150
5151 if (unlikely(current->in_iowait))
5152 goto force_update;
5153
5154 return;
5155 }
5156
5157 /* RT and DL should always send a freq update */
5158
5159 /* XXX ignore updates for sugov worker thread */
5160
5161 force_update:
5162
5163 /*
5164 * Request freq update after __balance_callbacks to take into account
5165 * any changes to rq.
5166 */
5167 cpufreq_update_util(rq, current->in_iowait ? SCHED_CPUFREQ_IOWAIT : 0);
5168 }
5169
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-02-03 11:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-03 11:07 [qais-yousef:improve-sched-cpufreq-interaction 1/1] kernel/sched/core.c:5129:36: error: 'cpufreq_update_enabled' undeclared; did you mean 'cpufreq_boost_enabled'? kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.