trailers update and bots

trailers update and bots

[Lucas De Marchi]

It looks like there is an incompatibility with b4's updating the
trailers and bots sending "found a bug in your patch, if you fix please
include Reported-by: ..."

Example: https://lore.kernel.org/all/202209160835.MMBeObmU-lkp@intel.com/

Now if I update the trailers, it will look like the patch itself was
done because it was reported by kernel test robot, which is not true:
there was something wrong in patch that needed an update.

Should lkp (and bots in general) escape the line "Reported-by: " that
looks like a trailer, or should/could b4 deal with it in a better way?

Lucas De Marchi

Re: trailers update and bots

[Konstantin Ryabitsev]

On Fri, Sep 16, 2022 at 09:18:35AM -0700, Lucas De Marchi wrote:
> It looks like there is an incompatibility with b4's updating the
> trailers and bots sending "found a bug in your patch, if you fix please
> include Reported-by: ..."
> 
> Example: https://lore.kernel.org/all/202209160835.MMBeObmU-lkp@intel.com/
> 
> Now if I update the trailers, it will look like the patch itself was
> done because it was reported by kernel test robot, which is not true:
> there was something wrong in patch that needed an update.
> 
> Should lkp (and bots in general) escape the line "Reported-by: " that
> looks like a trailer, or should/could b4 deal with it in a better way?

I'm not sure there's a universally "better way". One thing I considered is
adding an "trailers-ignore-from" setting that would allow you to keep a list
of trailers that should not be automatically inserted, e.g.:

    [b4] 
      trailers-ignore-from = lkp@intel.com

Would that be a suitable solution?

-K

Re: trailers update and bots

[Lucas De Marchi]

On Fri, Sep 16, 2022 at 12:24:18PM -0400, Konstantin Ryabitsev wrote:
>On Fri, Sep 16, 2022 at 09:18:35AM -0700, Lucas De Marchi wrote:
>> It looks like there is an incompatibility with b4's updating the
>> trailers and bots sending "found a bug in your patch, if you fix please
>> include Reported-by: ..."
>>
>> Example: https://lore.kernel.org/all/202209160835.MMBeObmU-lkp@intel.com/
>>
>> Now if I update the trailers, it will look like the patch itself was
>> done because it was reported by kernel test robot, which is not true:
>> there was something wrong in patch that needed an update.
>>
>> Should lkp (and bots in general) escape the line "Reported-by: " that
>> looks like a trailer, or should/could b4 deal with it in a better way?
>
>I'm not sure there's a universally "better way". One thing I considered is
>adding an "trailers-ignore-from" setting that would allow you to keep a list
>of trailers that should not be automatically inserted, e.g.:
>
>    [b4]
>      trailers-ignore-from = lkp@intel.com
>
>Would that be a suitable solution?

yeah, I think that would be something good to have. Maybe we should also
communicate a way for people writing these bots how to prevent it to be
considered a trailer? Would it be sufficient not being in a line by
itself? That could be a change done on the lkp side I think (Cc'ed
here).

Then people giving "conditional acks", i.e. it's acked if something
changes, may also have a way to avoid b4 auto-inserting the ack.

thanks
Lucas De Marchi

>
>-K

Re: trailers update and bots

[Konstantin Ryabitsev]

On Fri, Sep 16, 2022 at 09:31:01AM -0700, Lucas De Marchi wrote:
> > I'm not sure there's a universally "better way". One thing I considered is
> > adding an "trailers-ignore-from" setting that would allow you to keep a list
> > of trailers that should not be automatically inserted, e.g.:
> > 
> >    [b4]
> >      trailers-ignore-from = lkp@intel.com
> > 
> > Would that be a suitable solution?
> 
> yeah, I think that would be something good to have. 

The option is now in master and should be out later today as part of 0.10
release.

> Maybe we should also communicate a way for people writing these bots how to
> prevent it to be considered a trailer? Would it be sufficient not being in a
> line by itself? That could be a change done on the lkp side I think (Cc'ed
> here).

I've suggested it before. Any non-space character in front of the trailer will
make b4 ignore it, so something like this would work:

    If you fix the issue, kindly add following tag where applicable

    | Reported-by: kernel test robot <lkp@intel.com>

> Then people giving "conditional acks", i.e. it's acked if something
> changes, may also have a way to avoid b4 auto-inserting the ack.

I'm not sure people can be fixed quite as easily as bots. :) The same
principle would work, though -- ask them to provide some kind of non-space
character to prevent automation from pulling the trailer in, e.g.:

    If you fix this, please feel free to add the following:

    ? Acked-by: Alice Developer <alice.developer@example.com>

However, knowing that changing people is hard, I expect this is just something
you have to watch out for.

-K

Re: trailers update and bots

[Lucas De Marchi]

On Fri, Sep 16, 2022 at 12:59:51PM -0400, Konstantin Ryabitsev wrote:
>On Fri, Sep 16, 2022 at 09:31:01AM -0700, Lucas De Marchi wrote:
>> > I'm not sure there's a universally "better way". One thing I considered is
>> > adding an "trailers-ignore-from" setting that would allow you to keep a list
>> > of trailers that should not be automatically inserted, e.g.:
>> >
>> >    [b4]
>> >      trailers-ignore-from = lkp@intel.com
>> >
>> > Would that be a suitable solution?
>>
>> yeah, I think that would be something good to have.
>
>The option is now in master and should be out later today as part of 0.10
>release.

Reviving this thread as a similar issue occurred and I remembered of
this. Besides ignoring trailers from certain addresses, would it be
possible to ignore any email at all from certain addresses? Maybe a
b4.ignore-from to complement the above?

Current issue is for CI replies like this:
https://lore.kernel.org/all/170675203150.878359.3527977174668216260@5338d5abeb45/

It replies on the cover-letter and then if we use
--apply-cover-trailers, it will apply trailers that were
not intended to be used.

More details at https://gitlab.freedesktop.org/drm/maintainer-tools/-/merge_requests/27

>
>> Maybe we should also communicate a way for people writing these bots how to
>> prevent it to be considered a trailer? Would it be sufficient not being in a
>> line by itself? That could be a change done on the lkp side I think (Cc'ed
>> here).
>
>I've suggested it before. Any non-space character in front of the trailer will
>make b4 ignore it, so something like this would work:
>
>    If you fix the issue, kindly add following tag where applicable
>
>    | Reported-by: kernel test robot <lkp@intel.com>

I'm working with the people owning that CI to check if they can prefix
everything with a "|"  or so, but it would be good not to depend on any
possible bot replying. Another alternative I was thinking: use an email
header like is done with patchwork: at least the fdo fork uses
'X-Patchwork-Hint: ignore'  to completely ignore parsing the email.

thanks
Lucas De Marchi


>
>> Then people giving "conditional acks", i.e. it's acked if something
>> changes, may also have a way to avoid b4 auto-inserting the ack.
>
>I'm not sure people can be fixed quite as easily as bots. :) The same
>principle would work, though -- ask them to provide some kind of non-space
>character to prevent automation from pulling the trailer in, e.g.:
>
>    If you fix this, please feel free to add the following:
>
>    ? Acked-by: Alice Developer <alice.developer@example.com>
>
>However, knowing that changing people is hard, I expect this is just something
>you have to watch out for.
>
>-K

Re: trailers update and bots

[Konstantin Ryabitsev]

On Fri, Feb 02, 2024 at 07:33:42AM -0600, Lucas De Marchi wrote:
> Reviving this thread as a similar issue occurred and I remembered of
> this. Besides ignoring trailers from certain addresses, would it be
> possible to ignore any email at all from certain addresses? Maybe a
> b4.ignore-from to complement the above?

I think we'll just expand trailers-ignore-from to also match the From: field,
not just the address in the trailer itself.

-K

bugbot assign to me

Re: trailers update and bots

[Kernel.org Bugbot]

Hello:

This conversation is now tracked by Kernel.org Bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=218463

There is no need to do anything else, just keep talking.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)

Re: trailers update and bots

[Kernel.org Bugbot]

Konstantin Ryabitsev writes in commit 2578d5b6f45390dce631033b20b698438455cc9f:

am: extend trailers-ignore-from to match From: header as well

When trailers-ignore-from is defined, match not just the address
specified in the trailer itself, but also the From: header of the
message where the trailer comes from. This allows us to blanket-ignore
all trailers from certain addresses, not just person-trailers that
mention that address in the trailer content itself.

Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218463
Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

(via https://git.kernel.org/pub/scm/utils/b4/b4.git/commit/?id=2578d5b6f453)
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)