All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
	Kent Gibson <warthog618@gmail.com>, Alex Elder <elder@linaro.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Wolfram Sang <wsa@the-dreams.de>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH v2 15/23] gpio: cdev: don't access gdev->chip if it's not needed
Date: Mon,  5 Feb 2024 10:34:10 +0100	[thread overview]
Message-ID: <20240205093418.39755-16-brgl@bgdev.pl> (raw)
In-Reply-To: <20240205093418.39755-1-brgl@bgdev.pl>

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

The variable holding the number of GPIO lines is duplicated in GPIO
device so read it instead of unnecessarily dereferencing the chip
pointer.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/gpio/gpiolib-cdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
index 8e37e3befa08..e993c6a7215a 100644
--- a/drivers/gpio/gpiolib-cdev.c
+++ b/drivers/gpio/gpiolib-cdev.c
@@ -2701,7 +2701,7 @@ static int gpio_chrdev_open(struct inode *inode, struct file *file)
 	if (!cdev)
 		return -ENODEV;
 
-	cdev->watched_lines = bitmap_zalloc(gdev->chip->ngpio, GFP_KERNEL);
+	cdev->watched_lines = bitmap_zalloc(gdev->ngpio, GFP_KERNEL);
 	if (!cdev->watched_lines)
 		goto out_free_cdev;
 
-- 
2.40.1


  parent reply	other threads:[~2024-02-05  9:34 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-05  9:33 [PATCH v2 00/23] gpio: rework locking and object life-time control Bartosz Golaszewski
2024-02-05  9:33 ` [PATCH v2 01/23] gpio: protect the list of GPIO devices with SRCU Bartosz Golaszewski
2024-02-05  9:33 ` [PATCH v2 02/23] gpio: of: assign and read the hog pointer atomically Bartosz Golaszewski
2024-02-05  9:33 ` [PATCH v2 03/23] gpio: remove unused logging helpers Bartosz Golaszewski
2024-02-05  9:33 ` [PATCH v2 04/23] gpio: provide and use gpiod_get_label() Bartosz Golaszewski
2024-02-05  9:34 ` [PATCH v2 05/23] gpio: don't set label from irq helpers Bartosz Golaszewski
2024-02-05  9:34 ` [PATCH v2 06/23] gpio: add SRCU infrastructure to struct gpio_desc Bartosz Golaszewski
2024-02-05 12:16   ` Andy Shevchenko
2024-02-05 13:54     ` Bartosz Golaszewski
2024-02-05 13:57       ` Andy Shevchenko
2024-02-05 14:04         ` Bartosz Golaszewski
2024-02-05 14:06           ` Andy Shevchenko
2024-02-05 14:07             ` Bartosz Golaszewski
2024-02-05  9:34 ` [PATCH v2 07/23] gpio: protect the descriptor label with SRCU Bartosz Golaszewski
2024-02-05  9:34 ` [PATCH v2 08/23] gpio: sysfs: use gpio_device_find() to iterate over existing devices Bartosz Golaszewski
2024-02-05 12:18   ` Andy Shevchenko
2024-02-05 13:19     ` Bartosz Golaszewski
2024-02-05 13:38       ` Andy Shevchenko
2024-02-05 13:39         ` Bartosz Golaszewski
2024-02-05 13:47           ` Andy Shevchenko
2024-02-05 13:50             ` Bartosz Golaszewski
2024-02-05 13:58               ` Andy Shevchenko
2024-02-05 14:04                 ` Bartosz Golaszewski
2024-02-05  9:34 ` [PATCH v2 09/23] gpio: remove gpio_lock Bartosz Golaszewski
2024-02-05  9:34 ` [PATCH v2 10/23] gpio: reinforce desc->flags handling Bartosz Golaszewski
2024-02-05  9:34 ` [PATCH v2 11/23] gpio: remove unneeded code from gpio_device_get_desc() Bartosz Golaszewski
2024-02-05  9:34 ` [PATCH v2 12/23] gpio: sysfs: extend the critical section for unregistering sysfs devices Bartosz Golaszewski
2024-02-05  9:34 ` [PATCH v2 13/23] gpio: sysfs: pass the GPIO device - not chip - to sysfs callbacks Bartosz Golaszewski
2024-02-05  9:34 ` [PATCH v2 14/23] gpio: cdev: replace gpiochip_get_desc() with gpio_device_get_desc() Bartosz Golaszewski
2024-02-05  9:34 ` Bartosz Golaszewski [this message]
2024-02-05  9:34 ` [PATCH v2 16/23] gpio: don't dereference gdev->chip in gpiochip_setup_dev() Bartosz Golaszewski
2024-02-05  9:34 ` [PATCH v2 17/23] gpio: reduce the functionality of validate_desc() Bartosz Golaszewski
2024-02-05 12:22   ` Andy Shevchenko
2024-02-05 19:22     ` Bartosz Golaszewski
2024-02-06 12:30       ` Andy Shevchenko
2024-02-05  9:34 ` [PATCH v2 18/23] gpio: remove unnecessary checks from gpiod_to_chip() Bartosz Golaszewski
2024-02-05  9:34 ` [PATCH v2 19/23] gpio: add the can_sleep flag to struct gpio_device Bartosz Golaszewski
2024-02-05  9:34 ` [PATCH v2 20/23] gpio: add SRCU infrastructure " Bartosz Golaszewski
2024-02-05  9:34 ` [PATCH v2 21/23] gpio: protect the pointer to gpio_chip in gpio_device with SRCU Bartosz Golaszewski
2024-02-05 12:31   ` Andy Shevchenko
2024-02-05 13:30     ` Bartosz Golaszewski
2024-02-05 19:32     ` Bartosz Golaszewski
2024-02-05 19:36     ` Bartosz Golaszewski
2024-02-06 12:24       ` Andy Shevchenko
2024-02-06 12:57         ` Bartosz Golaszewski
2024-02-06 13:13           ` Andy Shevchenko
2024-02-06 13:23             ` Bartosz Golaszewski
2024-02-06 13:43               ` Andy Shevchenko
2024-02-05  9:34 ` [PATCH v2 22/23] gpio: remove the RW semaphore from the GPIO device Bartosz Golaszewski
2024-02-05  9:34 ` [PATCH v2 23/23] gpio: mark unsafe gpio_chip manipulators as deprecated Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240205093418.39755-16-brgl@bgdev.pl \
    --to=brgl@bgdev.pl \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=elder@linaro.org \
    --cc=geert+renesas@glider.be \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@kernel.org \
    --cc=warthog618@gmail.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.