From: Simon Horman <horms@kernel.org>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com,
intel-wired-lan@lists.osuosl.org, magnus.karlsson@intel.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-net 1/2] i40e: avoid double calling i40e_pf_rxq_wait()
Date: Mon, 5 Feb 2024 11:13:32 +0000 [thread overview]
Message-ID: <20240205111332.GH960600@kernel.org> (raw)
In-Reply-To: <20240201154219.607338-2-maciej.fijalkowski@intel.com>
On Thu, Feb 01, 2024 at 04:42:18PM +0100, Maciej Fijalkowski wrote:
> Currently, when interface is being brought down and
> i40e_vsi_stop_rings() is called, i40e_pf_rxq_wait() is called two times,
> which is wrong. To showcase this scenario, simplified call stack looks
> as follows:
>
> i40e_vsi_stop_rings()
> i40e_control wait rx_q()
> i40e_control_rx_q()
> i40e_pf_rxq_wait()
> i40e_vsi_wait_queues_disabled()
> i40e_pf_rxq_wait() // redundant call
>
> To fix this, let us s/i40e_control_wait_rx_q/i40e_control_rx_q within
> i40e_vsi_stop_rings().
>
> Fixes: 65662a8dcdd0 ("i40e: Fix logic of disabling queues")
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
anthony.l.nguyen@intel.com, magnus.karlsson@intel.com
Subject: Re: [PATCH iwl-net 1/2] i40e: avoid double calling i40e_pf_rxq_wait()
Date: Mon, 5 Feb 2024 11:13:32 +0000 [thread overview]
Message-ID: <20240205111332.GH960600@kernel.org> (raw)
In-Reply-To: <20240201154219.607338-2-maciej.fijalkowski@intel.com>
On Thu, Feb 01, 2024 at 04:42:18PM +0100, Maciej Fijalkowski wrote:
> Currently, when interface is being brought down and
> i40e_vsi_stop_rings() is called, i40e_pf_rxq_wait() is called two times,
> which is wrong. To showcase this scenario, simplified call stack looks
> as follows:
>
> i40e_vsi_stop_rings()
> i40e_control wait rx_q()
> i40e_control_rx_q()
> i40e_pf_rxq_wait()
> i40e_vsi_wait_queues_disabled()
> i40e_pf_rxq_wait() // redundant call
>
> To fix this, let us s/i40e_control_wait_rx_q/i40e_control_rx_q within
> i40e_vsi_stop_rings().
>
> Fixes: 65662a8dcdd0 ("i40e: Fix logic of disabling queues")
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-02-05 11:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 15:42 [Intel-wired-lan] [PATCH iwl-net 0/2] i40e: disable XDP Tx queues on ifdown Maciej Fijalkowski
2024-02-01 15:42 ` Maciej Fijalkowski
2024-02-01 15:42 ` [Intel-wired-lan] [PATCH iwl-net 1/2] i40e: avoid double calling i40e_pf_rxq_wait() Maciej Fijalkowski
2024-02-01 15:42 ` Maciej Fijalkowski
2024-02-05 11:13 ` Simon Horman [this message]
2024-02-05 11:13 ` Simon Horman
2024-02-01 15:42 ` [Intel-wired-lan] [PATCH iwl-net 2/2] i40e: take into account XDP Tx queues when stopping rings Maciej Fijalkowski
2024-02-01 15:42 ` Maciej Fijalkowski
2024-02-01 18:40 ` [Intel-wired-lan] " Seth Forshee
2024-02-01 18:40 ` Seth Forshee
2024-02-06 12:08 ` [Intel-wired-lan] " Maciej Fijalkowski
2024-02-06 12:08 ` Maciej Fijalkowski
2024-02-05 11:13 ` [Intel-wired-lan] " Simon Horman
2024-02-05 11:13 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240205111332.GH960600@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.