From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: Stanislav Fomichev <sdf@google.com>,
sridhar.samudrala@intel.com, Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
chuck.lever@oracle.com, jlayton@kernel.org,
linux-api@vger.kernel.org, brauner@kernel.org,
davem@davemloft.net, alexander.duyck@gmail.com,
Wei Wang <weiwan@google.com>,
Amritha Nambiar <amritha.nambiar@intel.com>
Subject: Re: [net-next 0/3] Per epoll context busy poll support
Date: Mon, 5 Feb 2024 11:48:21 -0800 [thread overview]
Message-ID: <20240205114821.4601ea5b@kernel.org> (raw)
In-Reply-To: <20240205185217.GC10463@fastly.com>
On Mon, 5 Feb 2024 10:52:18 -0800 Joe Damato wrote:
> > Should we also add prefer_busy_poll parameter to EPIOCSPARAMS?
> > napi_busy_loop in ep_busy_loop has its prefer_busy_poll argument
> > hard-coded as false.
Good catch! We only plumbed it thru to socket read busy poll.
> I think making this configurable is a good idea. I can add that in the v6
> in addition to fixing the incorrect commit message in patch 1/3.
>
> What do you think, Jakub?
SGTM (with the caveat that I'm not epoll expert)
next prev parent reply other threads:[~2024-02-05 19:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 2:53 [net-next 0/3] Per epoll context busy poll support Joe Damato
2024-01-24 2:53 ` [net-next 1/3] eventpoll: support busy poll per epoll instance Joe Damato
2024-01-24 2:53 ` [net-next 2/3] eventpoll: Add per-epoll busy poll packet budget Joe Damato
2024-01-24 2:53 ` [net-next 3/3] eventpoll: Add epoll ioctl for epoll_params Joe Damato
2024-01-24 15:37 ` Joe Damato
2024-01-24 8:20 ` [net-next 0/3] Per epoll context busy poll support Eric Dumazet
2024-01-24 14:20 ` Joe Damato
2024-01-24 14:38 ` Eric Dumazet
2024-01-24 15:19 ` Joe Damato
2024-01-30 18:54 ` Samudrala, Sridhar
2024-02-02 3:28 ` Joe Damato
2024-02-02 17:23 ` Samudrala, Sridhar
2024-02-02 18:22 ` Jakub Kicinski
2024-02-02 19:33 ` Joe Damato
2024-02-02 19:58 ` Jakub Kicinski
2024-02-02 20:23 ` Joe Damato
2024-02-02 20:50 ` Samudrala, Sridhar
2024-02-02 20:55 ` Joe Damato
2024-02-03 1:15 ` Jakub Kicinski
2024-02-05 18:17 ` Stanislav Fomichev
2024-02-05 18:52 ` Joe Damato
2024-02-05 19:48 ` Jakub Kicinski [this message]
2024-02-05 18:51 ` Joe Damato
2024-02-05 19:59 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240205114821.4601ea5b@kernel.org \
--to=kuba@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=amritha.nambiar@intel.com \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=jlayton@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
--cc=sridhar.samudrala@intel.com \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.