From: Bjorn Helgaas <helgaas@kernel.org>
To: Onkarnarth <onkarnath.1@samsung.com>
Cc: rafael@kernel.org, lenb@kernel.org, bhelgaas@google.com,
viresh.kumar@linaro.org, mingo@redhat.com, peterz@infradead.org,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-pci@vger.kernel.org, r.thapliyal@samsung.com,
maninder1.s@samsung.com
Subject: Re: [PATCH 1/2] drivers: acpi: use %pe for better readability of errors while printing
Date: Tue, 6 Feb 2024 09:32:04 -0600 [thread overview]
Message-ID: <20240206153204.GA866166@bhelgaas> (raw)
In-Reply-To: <20240206051120.4173475-1-onkarnath.1@samsung.com>
On Tue, Feb 06, 2024 at 10:41:19AM +0530, Onkarnarth wrote:
> From: Onkarnath <onkarnath.1@samsung.com>
>
> As %pe is already introduced, its better to use it inplace of (%ld) for
> printing errors in logs. It would enhance redability of logs.
s/its/it's/
s/inplace/in place/
s/redability/readability/
In the subject line, run "git log --oneline drivers/acpi" and pick
something that fits with the history instead of just encoding the file
path. Same for the sched patch.
Bjorn
prev parent reply other threads:[~2024-02-06 15:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240206051218epcas5p3fddd971ec73f6ee6a2b0a5ec2709c0f7@epcas5p3.samsung.com>
2024-02-06 5:11 ` [PATCH 1/2] drivers: acpi: use %pe for better readability of errors while printing Onkarnarth
2024-02-06 5:11 ` [PATCH 2/2] kernel: sched: print errors with %pe for better readability of logs Onkarnarth
2024-02-06 9:23 ` Stanislaw Gruszka
2024-02-06 9:48 ` Valentin Schneider
2024-02-06 9:22 ` [PATCH 1/2] drivers: acpi: use %pe for better readability of errors while printing Stanislaw Gruszka
2024-02-06 15:32 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240206153204.GA866166@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=onkarnath.1@samsung.com \
--cc=peterz@infradead.org \
--cc=r.thapliyal@samsung.com \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.