All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
To: Onkarnarth <onkarnath.1@samsung.com>
Cc: rafael@kernel.org, lenb@kernel.org, bhelgaas@google.com,
	viresh.kumar@linaro.org, mingo@redhat.com, peterz@infradead.org,
	juri.lelli@redhat.com, vincent.guittot@linaro.org,
	dietmar.eggemann@arm.com, rostedt@goodmis.org,
	bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
	vschneid@redhat.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-pci@vger.kernel.org, r.thapliyal@samsung.com,
	maninder1.s@samsung.com
Subject: Re: [PATCH 2/2] kernel: sched: print errors with %pe for better readability of logs
Date: Tue, 6 Feb 2024 10:23:17 +0100	[thread overview]
Message-ID: <ZcH6hR+QnjKsv7+4@linux.intel.com> (raw)
In-Reply-To: <20240206051120.4173475-2-onkarnath.1@samsung.com>

On Tue, Feb 06, 2024 at 10:41:20AM +0530, Onkarnarth wrote:
> From: Onkarnath <onkarnath.1@samsung.com>
> 
> instead of printing errros as a number(%ld), it's better to print in string
> format for better readability of logs.
> 
> Signed-off-by: Onkarnath <onkarnath.1@samsung.com>
Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>

> ---
>  kernel/sched/cpufreq_schedutil.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
> index eece6244f9d2..2c42eaa56fa3 100644
> --- a/kernel/sched/cpufreq_schedutil.c
> +++ b/kernel/sched/cpufreq_schedutil.c
> @@ -671,7 +671,7 @@ static int sugov_kthread_create(struct sugov_policy *sg_policy)
>  				"sugov:%d",
>  				cpumask_first(policy->related_cpus));
>  	if (IS_ERR(thread)) {
> -		pr_err("failed to create sugov thread: %ld\n", PTR_ERR(thread));
> +		pr_err("failed to create sugov thread: %pe\n", thread);
>  		return PTR_ERR(thread);
>  	}
>  
> -- 
> 2.25.1
> 
> 

  reply	other threads:[~2024-02-06  9:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240206051218epcas5p3fddd971ec73f6ee6a2b0a5ec2709c0f7@epcas5p3.samsung.com>
2024-02-06  5:11 ` [PATCH 1/2] drivers: acpi: use %pe for better readability of errors while printing Onkarnarth
2024-02-06  5:11   ` [PATCH 2/2] kernel: sched: print errors with %pe for better readability of logs Onkarnarth
2024-02-06  9:23     ` Stanislaw Gruszka [this message]
2024-02-06  9:48     ` Valentin Schneider
2024-02-06  9:22   ` [PATCH 1/2] drivers: acpi: use %pe for better readability of errors while printing Stanislaw Gruszka
2024-02-06 15:32   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZcH6hR+QnjKsv7+4@linux.intel.com \
    --to=stanislaw.gruszka@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=maninder1.s@samsung.com \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=onkarnath.1@samsung.com \
    --cc=peterz@infradead.org \
    --cc=r.thapliyal@samsung.com \
    --cc=rafael@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.