* Re: [revert commit 83b3836bf83f09beea5f592b126cfdd1bc921e48] [mainline] [6.8.0-rc3]kernel BUG at arch/powerpc/platforms/pseries/iommu.c:100!
[not found] <798229fe-906e-441b-b7a3-44c475cf1e9f@linux.vnet.ibm.com>
@ 2024-02-07 16:32 ` Jason Gunthorpe
2024-02-13 16:16 ` Shivaprasad G Bhat
0 siblings, 1 reply; 5+ messages in thread
From: Jason Gunthorpe @ 2024-02-07 16:32 UTC (permalink / raw)
To: Venkat Rao Bagalkote, Shivaprasad G Bhat, Ovidiu Panait
Cc: iommu, sbhat, robin.murphy, will
On Wed, Feb 07, 2024 at 09:53:30PM +0530, Venkat Rao Bagalkote wrote:
> Greetings!!!
>
> [revert commit 83b3836bf83f09beea5f592b126cfdd1bc921e48] [mainline]
> [6.8.0-rc3]kernel BUG at arch/powerpc/platforms/pseries/iommu.c:100!
>
> Reverting below commit id issue is not seen.
> 83b3836bf83f09beea5f592b126cfdd1bc921e48
> iommu: Allow ops->default_domain to work when !CONFIG_IOMMU_DMA
Well, you'll get probing failures if you revert it, so this seems like
a false bisection.. Though no doubt it will land on one of the earlier
iommu patches.
> [ 7843.149112] NIP [c0000000000ff4d4] iommu_reconfig_notifier+0x94/0x200
> [ 7843.149123] LR [c0000000000ff4cc] iommu_reconfig_notifier+0x8c/0x200
> [ 7843.149129] Call Trace:
> [ 7843.149131] [c0000013aed5fae0] [c0000000000ff4cc] iommu_reconfig_notifier+0x8
> c/0x200 (unreliable)
> [ 7843.149138] [c0000013aed5fb10] [c0000000001a27b0] notifier_call_chain+0xb8/0x
> 19c
> [ 7843.149146] [c0000013aed5fb70] [c0000000001a2a78] blocking_notifier_call_chai
> n+0x64/0x98
> [ 7843.149152] [c0000013aed5fbb0] [c000000000c4a898] of_reconfig_notify+0x44/0xd
> c
> [ 7843.149160] [c0000013aed5fc20] [c000000000c4add4] of_detach_node+0x78/0xb0
> [ 7843.149165] [c0000013aed5fc70] [c0000000000f96a8] ofdt_write.part.0+0x86c/0xb
> b8
> [ 7843.149171] [c0000013aed5fce0] [c00000000069b4bc] proc_reg_write+0xf4/0x150
> [ 7843.149178] [c0000013aed5fd10] [c0000000005bfeb4] vfs_write+0xf8/0x488
> [ 7843.149184] [c0000013aed5fdc0] [c0000000005c0570] ksys_write+0x84/0x140
> [ 7843.149189] [c0000013aed5fe10] [c000000000033358] system_call_exception+0x138
> /0x330
> [ 7843.149196] [c0000013aed5fe50] [c00000000000d05c] system_call_vectored_common
> +0x15c/0x2ec
What is all this?
Why is it reaching into the iommu space and messing it up from a
notifier and then crashing when it is not in the state it expects?
If a DT property is being removed shouldn't that be achieved by
removing the device first and letting the normal iommu driver release
flow run?
I have no idea what this is doing, but it looks sketchy :\
Shivaprasad/Ovidiu can you look at this? It looks like some case with
hot device removal?
Thanks,
Jason
^ permalink raw reply [flat|nested] 5+ messages in thread
* [revert commit 83b3836bf83f09beea5f592b126cfdd1bc921e48] [mainline] [6.8.0-rc3]kernel BUG at arch/powerpc/platforms/pseries/iommu.c:100!
[not found] <8d75ebd3-85c2-4a05-8eca-08f66f9411dc@linux.vnet.ibm.com>
@ 2024-02-08 2:56 ` Venkat Rao Bagalkote
2024-02-08 5:53 ` Venkat Rao Bagalkote
0 siblings, 1 reply; 5+ messages in thread
From: Venkat Rao Bagalkote @ 2024-02-08 2:56 UTC (permalink / raw)
To: iommu, jgg; +Cc: sbhat, robin.murphy, will
Resending as earlier one bounced.
Greetings!!!
[revert commit 83b3836bf83f09beea5f592b126cfdd1bc921e48] [mainline]
[6.8.0-rc3]kernel BUG at arch/powerpc/platforms/pseries/iommu.c:100!
By Reverting below commit id, issue is not seen.
83b3836bf83f09beea5f592b126cfdd1bc921e48
iommu: Allow ops->default_domain to work when !CONFIG_IOMMU_DMA
--- Traces ---
KernelBug: Kernel bug in state 'None': kernel BUG at
arch/powerpc/platforms/pseries/iommu.c:100!
[ 7843.148980] Oops: Exception in kernel mode, sig: 5 [#1]
[ 7843.148984] LE PAGE_SIZE=64K MMU=Radix SMP NR_CPUS=8192 NUMA pSeries
[ 7843.148988] Modules linked in: nft_compat nf_tables libcrc32c
nfnetlink bridge stp llc tls sit tunnel4 ip_tunnel nvram rpadlpar_io
rpaphp xsk_diag rfkill binfmt_misc mlx5_ib ib_uverbs ib_core pseries_rng
drm drm_panel_orientation_quirks ext4 mbcache jbd2 dm_service_time
sd_mod t10_pi crc64_rocksoft_generic crc64_rocksoft crc64 sg ibmvfc
scsi_transport_fc ibmveth mlx5_core mlxfw vmx_crypto psample
dm_multipath dm_mirror dm_region_hash dm_log dm_mod fuse [last unloaded:
tls]
[ 7843.149041] CPU: 17 PID: 218444 Comm: drmgr Kdump: loaded Tainted:
G I 6.8.0-rc3-autotest-g99bd3cb0d12e #1
[ 7843.149047] Hardware name: IBM,9080-HEX POWER10 (raw) 0x800200
0xf000006 of:IBM,FW1060.00 (NH1060_016) hv:phyp pSeries
[ 7843.149051] NIP: c0000000000ff4d4 LR: c0000000000ff4cc CTR:
0000000000000000
[ 7843.149055] REGS: c0000013aed5f840 TRAP: 0700 Tainted: G
I (6.8.0-rc3-autotest-g99bd3cb0d12e)
[ 7843.149060] MSR: 8000000000029033 <SF,EE,ME,IR,DR,RI,LE> CR:
44002402 XER: 20040000
[ 7843.149069] CFAR: c000000000a0d170 IRQMASK: 0
[ 7843.149069] GPR00: c0000000000ff4cc c0000013aed5fae0 c000000001512700
c0000013aa362138
[ 7843.149069] GPR04: 0000000000000000 0000000000000000 0000000000000000
0000000119c8afd0
[ 7843.149069] GPR08: 0000000000000000 c000001284442b00 0000000000000001
0000000000001003
[ 7843.149069] GPR12: 0000000300000000 c0000018ffff2f00 0000000000000000
0000000000000000
[ 7843.149069] GPR16: 0000000000000000 0000000000000000 0000000000000000
0000000000000000
[ 7843.149069] GPR20: 0000000000000000 0000000000000000 0000000000000000
0000000000000000
[ 7843.149069] GPR24: c0000013aed5fc40 0000000000000002 0000000000000000
c000000002757d90
[ 7843.149069] GPR28: c0000000000ff440 c000000002757cb8 c00000183799c1a0
c0000013aa362b00
[ 7843.149112] NIP [c0000000000ff4d4] iommu_reconfig_notifier+0x94/0x200
[ 7843.149123] LR [c0000000000ff4cc] iommu_reconfig_notifier+0x8c/0x200
[ 7843.149129] Call Trace:
[ 7843.149131] [c0000013aed5fae0] [c0000000000ff4cc]
iommu_reconfig_notifier+0x8c/0x200 (unreliable)
[ 7843.149138] [c0000013aed5fb10] [c0000000001a27b0]
notifier_call_chain+0xb8/0x19c
[ 7843.149146] [c0000013aed5fb70] [c0000000001a2a78]
blocking_notifier_call_chain+0x64/0x98
[ 7843.149152] [c0000013aed5fbb0] [c000000000c4a898]
of_reconfig_notify+0x44/0xdc
[ 7843.149160] [c0000013aed5fc20] [c000000000c4add4]
of_detach_node+0x78/0xb0
[ 7843.149165] [c0000013aed5fc70] [c0000000000f96a8]
ofdt_write.part.0+0x86c/0xbb8
[ 7843.149171] [c0000013aed5fce0] [c00000000069b4bc]
proc_reg_write+0xf4/0x150
[ 7843.149178] [c0000013aed5fd10] [c0000000005bfeb4] vfs_write+0xf8/0x488
[ 7843.149184] [c0000013aed5fdc0] [c0000000005c0570] ksys_write+0x84/0x140
[ 7843.149189] [c0000013aed5fe10] [c000000000033358]
system_call_exception+0x138/0x330
[ 7843.149196] [c0000013aed5fe50] [c00000000000d05c]
system_call_vectored_common+0x15c/0x2ec
[ 7843.149203] --- interrupt: 3000 at 0x20000433acb4
[ 7843.149208] NIP: 000020000433acb4 LR: 0000000000000000 CTR:
0000000000000000
[ 7843.149212] REGS: c0000013aed5fe80 TRAP: 3000 Tainted: G
I (6.8.0-rc3-autotest-g99bd3cb0d12e)
[ 7843.149217] MSR: 800000000280f033
<SF,VEC,VSX,EE,PR,FP,ME,IR,DR,RI,LE> CR: 42002408 XER: 00000000
[ 7843.149227] IRQMASK: 0
[ 7843.149227] GPR00: 0000000000000004 00007fffcde2d2c0 000000013a707f00
0000000000000006
[ 7843.149227] GPR04: 00007fffcde2d368 0000000000000020 0000000000000000
0000000000000001
[ 7843.149227] GPR08: 0000000000000020 0000000000000000 0000000000000000
0000000000000000
[ 7843.149227] GPR12: 0000000000000000 000020000403b1e0 000000013a6df668
0000000000000006
[ 7843.149227] GPR16: 0000000000000000 0000000000000002 0000000000000004
0000000000000005
[ 7843.149227] GPR20: 000000013a700018 000000013a6df360 000000013a6dcb20
000000013a6dd918
[ 7843.149227] GPR24: 000000013a6db178 00000001722028c8 00007fffcde2d7f8
00000001722028c8
[ 7843.149227] GPR28: 000000013a6dc340 00007fffcde2d368 0000000000000006
0000000000000020
[ 7843.149268] NIP [000020000433acb4] 0x20000433acb4
[ 7843.149271] LR [0000000000000000] 0x0
[ 7843.149274] --- interrupt: 3000
[ 7843.149277] Code: 4082016c 2c3f0000 41820060 ebff0028 2c3f0000
41820054 e87f0018 2c230000 41820014 4890dc75 60000000 e93f0018
<0b090000> e87f0020 2c230000 4182000c
[ 7843.149292] ---[ end trace 0000000000000000 ]---
Regards,
Venkat.
> Greetings!!!
>
>
> [revert commit 83b3836bf83f09beea5f592b126cfdd1bc921e48] [mainline]
> [6.8.0-rc3]kernel BUG at arch/powerpc/platforms/pseries/iommu.c:100!
>
>
> Reverting below commit id issue is not seen.
>
> 83b3836bf83f09beea5f592b126cfdd1bc921e48
> iommu: Allow ops->default_domain to work when !CONFIG_IOMMU_DMA
>
>
> Traces:
>
>
> KernelBug: Kernel bug in state 'None': kernel BUG at arch/powerpc/platforms/pseries/iommu.c:100!
> [ 7843.148980] Oops: Exception in kernel mode, sig: 5 [#1]
> [ 7843.148984] LE PAGE_SIZE=64K MMU=Radix SMP NR_CPUS=8192 NUMA pSeries
> [ 7843.148988] Modules linked in: nft_compat nf_tables libcrc32c nfnetlink bridge stp llc tls sit tunnel4 ip_tunnel nvram rpadlpar_io rpaphp xsk_diag rfkill binfmt_misc mlx5_ib ib_uverbs ib_core pseries_rng drm drm_panel_orientation_quirks ext4 mbcache jbd2 dm_service_time sd_mod t10_pi crc64_rocksoft_generic crc64_rocksoft crc64 sg ibmvfc scsi_transport_fc ibmveth mlx5_core mlxfw vmx_crypto psample dm_multipath dm_mirror dm_region_hash dm_log dm_mod fuse [last unloaded: tls]
> [ 7843.149041] CPU: 17 PID: 218444 Comm: drmgr Kdump: loaded Tainted: G I 6.8.0-rc3-autotest-g99bd3cb0d12e #1
> [ 7843.149047] Hardware name: IBM,9080-HEX POWER10 (raw) 0x800200 0xf000006 of:IBM,FW1060.00 (NH1060_016) hv:phyp pSeries
> [ 7843.149051] NIP: c0000000000ff4d4 LR: c0000000000ff4cc CTR: 0000000000000000
> [ 7843.149055] REGS: c0000013aed5f840 TRAP: 0700 Tainted: G I (6.8.0-rc3-autotest-g99bd3cb0d12e)
> [ 7843.149060] MSR: 8000000000029033 <SF,EE,ME,IR,DR,RI,LE> CR: 44002402 XER: 20040000
> [ 7843.149069] CFAR: c000000000a0d170 IRQMASK: 0
> [ 7843.149069] GPR00: c0000000000ff4cc c0000013aed5fae0 c000000001512700 c0000013aa362138
> [ 7843.149069] GPR04: 0000000000000000 0000000000000000 0000000000000000 0000000119c8afd0
> [ 7843.149069] GPR08: 0000000000000000 c000001284442b00 0000000000000001 0000000000001003
> [ 7843.149069] GPR12: 0000000300000000 c0000018ffff2f00 0000000000000000 0000000000000000
> [ 7843.149069] GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> [ 7843.149069] GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> [ 7843.149069] GPR24: c0000013aed5fc40 0000000000000002 0000000000000000 c000000002757d90
> [ 7843.149069] GPR28: c0000000000ff440 c000000002757cb8 c00000183799c1a0 c0000013aa362b00
> [ 7843.149112] NIP [c0000000000ff4d4] iommu_reconfig_notifier+0x94/0x200
> [ 7843.149123] LR [c0000000000ff4cc] iommu_reconfig_notifier+0x8c/0x200
> [ 7843.149129] Call Trace:
> [ 7843.149131] [c0000013aed5fae0] [c0000000000ff4cc] iommu_reconfig_notifier+0x8c/0x200 (unreliable)
> [ 7843.149138] [c0000013aed5fb10] [c0000000001a27b0] notifier_call_chain+0xb8/0x19c
> [ 7843.149146] [c0000013aed5fb70] [c0000000001a2a78] blocking_notifier_call_chain+0x64/0x98
> [ 7843.149152] [c0000013aed5fbb0] [c000000000c4a898] of_reconfig_notify+0x44/0xdc
> [ 7843.149160] [c0000013aed5fc20] [c000000000c4add4] of_detach_node+0x78/0xb0
> [ 7843.149165] [c0000013aed5fc70] [c0000000000f96a8] ofdt_write.part.0+0x86c/0xbb8
> [ 7843.149171] [c0000013aed5fce0] [c00000000069b4bc] proc_reg_write+0xf4/0x150
> [ 7843.149178] [c0000013aed5fd10] [c0000000005bfeb4] vfs_write+0xf8/0x488
> [ 7843.149184] [c0000013aed5fdc0] [c0000000005c0570] ksys_write+0x84/0x140
> [ 7843.149189] [c0000013aed5fe10] [c000000000033358] system_call_exception+0x138/0x330
> [ 7843.149196] [c0000013aed5fe50] [c00000000000d05c] system_call_vectored_common+0x15c/0x2ec
> [ 7843.149203] --- interrupt: 3000 at 0x20000433acb4
> [ 7843.149208] NIP: 000020000433acb4 LR: 0000000000000000 CTR: 0000000000000000
> [ 7843.149212] REGS: c0000013aed5fe80 TRAP: 3000 Tainted: G I (6.8.0-rc3-autotest-g99bd3cb0d12e)
> [ 7843.149217] MSR: 800000000280f033 <SF,VEC,VSX,EE,PR,FP,ME,IR,DR,RI,LE> CR: 42002408 XER: 00000000
> [ 7843.149227] IRQMASK: 0
> [ 7843.149227] GPR00: 0000000000000004 00007fffcde2d2c0 000000013a707f00 0000000000000006
> [ 7843.149227] GPR04: 00007fffcde2d368 0000000000000020 0000000000000000 0000000000000001
> [ 7843.149227] GPR08: 0000000000000020 0000000000000000 0000000000000000 0000000000000000
> [ 7843.149227] GPR12: 0000000000000000 000020000403b1e0 000000013a6df668 0000000000000006
> [ 7843.149227] GPR16: 0000000000000000 0000000000000002 0000000000000004 0000000000000005
> [ 7843.149227] GPR20: 000000013a700018 000000013a6df360 000000013a6dcb20 000000013a6dd918
> [ 7843.149227] GPR24: 000000013a6db178 00000001722028c8 00007fffcde2d7f8 00000001722028c8
> [ 7843.149227] GPR28: 000000013a6dc340 00007fffcde2d368 0000000000000006 0000000000000020
> [ 7843.149268] NIP [000020000433acb4] 0x20000433acb4
> [ 7843.149271] LR [0000000000000000] 0x0
> [ 7843.149274] --- interrupt: 3000
> [ 7843.149277] Code: 4082016c 2c3f0000 41820060 ebff0028 2c3f0000 41820054 e87f0018 2c230000 41820014 4890dc75 60000000 e93f0018 <0b090000> e87f0020 2c230000 4182000c
> [ 7843.149292] ---[ end trace 0000000000000000 ]---
>
>
> Regards,
> Venkat.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [revert commit 83b3836bf83f09beea5f592b126cfdd1bc921e48] [mainline] [6.8.0-rc3]kernel BUG at arch/powerpc/platforms/pseries/iommu.c:100!
2024-02-08 2:56 ` Venkat Rao Bagalkote
@ 2024-02-08 5:53 ` Venkat Rao Bagalkote
0 siblings, 0 replies; 5+ messages in thread
From: Venkat Rao Bagalkote @ 2024-02-08 5:53 UTC (permalink / raw)
To: iommu, jgg, linuxppc-dev, linux-kernel
Cc: sbhat, robin.murphy, will, sachinp, mputtash, abdhalee, tasmiya
Adding more people
On 08/02/24 8:26 am, Venkat Rao Bagalkote wrote:
>
> Resending as earlier one bounced.
>
> Greetings!!!
>
>
> [revert commit 83b3836bf83f09beea5f592b126cfdd1bc921e48] [mainline]
> [6.8.0-rc3]kernel BUG at arch/powerpc/platforms/pseries/iommu.c:100!
>
>
> By Reverting below commit id, issue is not seen.
>
>
> 83b3836bf83f09beea5f592b126cfdd1bc921e48
> iommu: Allow ops->default_domain to work when !CONFIG_IOMMU_DMA
>
>
> --- Traces ---
>
> KernelBug: Kernel bug in state 'None': kernel BUG at
> arch/powerpc/platforms/pseries/iommu.c:100!
> [ 7843.148980] Oops: Exception in kernel mode, sig: 5 [#1]
> [ 7843.148984] LE PAGE_SIZE=64K MMU=Radix SMP NR_CPUS=8192 NUMA pSeries
> [ 7843.148988] Modules linked in: nft_compat nf_tables libcrc32c
> nfnetlink bridge stp llc tls sit tunnel4 ip_tunnel nvram rpadlpar_io
> rpaphp xsk_diag rfkill binfmt_misc mlx5_ib ib_uverbs ib_core
> pseries_rng drm drm_panel_orientation_quirks ext4 mbcache jbd2
> dm_service_time sd_mod t10_pi crc64_rocksoft_generic crc64_rocksoft
> crc64 sg ibmvfc scsi_transport_fc ibmveth mlx5_core mlxfw vmx_crypto
> psample dm_multipath dm_mirror dm_region_hash dm_log dm_mod fuse [last
> unloaded: tls]
> [ 7843.149041] CPU: 17 PID: 218444 Comm: drmgr Kdump: loaded Tainted:
> G I 6.8.0-rc3-autotest-g99bd3cb0d12e #1
> [ 7843.149047] Hardware name: IBM,9080-HEX POWER10 (raw) 0x800200
> 0xf000006 of:IBM,FW1060.00 (NH1060_016) hv:phyp pSeries
> [ 7843.149051] NIP: c0000000000ff4d4 LR: c0000000000ff4cc CTR:
> 0000000000000000
> [ 7843.149055] REGS: c0000013aed5f840 TRAP: 0700 Tainted: G
> I (6.8.0-rc3-autotest-g99bd3cb0d12e)
> [ 7843.149060] MSR: 8000000000029033 <SF,EE,ME,IR,DR,RI,LE> CR:
> 44002402 XER: 20040000
> [ 7843.149069] CFAR: c000000000a0d170 IRQMASK: 0
> [ 7843.149069] GPR00: c0000000000ff4cc c0000013aed5fae0
> c000000001512700 c0000013aa362138
> [ 7843.149069] GPR04: 0000000000000000 0000000000000000
> 0000000000000000 0000000119c8afd0
> [ 7843.149069] GPR08: 0000000000000000 c000001284442b00
> 0000000000000001 0000000000001003
> [ 7843.149069] GPR12: 0000000300000000 c0000018ffff2f00
> 0000000000000000 0000000000000000
> [ 7843.149069] GPR16: 0000000000000000 0000000000000000
> 0000000000000000 0000000000000000
> [ 7843.149069] GPR20: 0000000000000000 0000000000000000
> 0000000000000000 0000000000000000
> [ 7843.149069] GPR24: c0000013aed5fc40 0000000000000002
> 0000000000000000 c000000002757d90
> [ 7843.149069] GPR28: c0000000000ff440 c000000002757cb8
> c00000183799c1a0 c0000013aa362b00
> [ 7843.149112] NIP [c0000000000ff4d4] iommu_reconfig_notifier+0x94/0x200
> [ 7843.149123] LR [c0000000000ff4cc] iommu_reconfig_notifier+0x8c/0x200
> [ 7843.149129] Call Trace:
> [ 7843.149131] [c0000013aed5fae0] [c0000000000ff4cc]
> iommu_reconfig_notifier+0x8c/0x200 (unreliable)
> [ 7843.149138] [c0000013aed5fb10] [c0000000001a27b0]
> notifier_call_chain+0xb8/0x19c
> [ 7843.149146] [c0000013aed5fb70] [c0000000001a2a78]
> blocking_notifier_call_chain+0x64/0x98
> [ 7843.149152] [c0000013aed5fbb0] [c000000000c4a898]
> of_reconfig_notify+0x44/0xdc
> [ 7843.149160] [c0000013aed5fc20] [c000000000c4add4]
> of_detach_node+0x78/0xb0
> [ 7843.149165] [c0000013aed5fc70] [c0000000000f96a8]
> ofdt_write.part.0+0x86c/0xbb8
> [ 7843.149171] [c0000013aed5fce0] [c00000000069b4bc]
> proc_reg_write+0xf4/0x150
> [ 7843.149178] [c0000013aed5fd10] [c0000000005bfeb4] vfs_write+0xf8/0x488
> [ 7843.149184] [c0000013aed5fdc0] [c0000000005c0570]
> ksys_write+0x84/0x140
> [ 7843.149189] [c0000013aed5fe10] [c000000000033358]
> system_call_exception+0x138/0x330
> [ 7843.149196] [c0000013aed5fe50] [c00000000000d05c]
> system_call_vectored_common+0x15c/0x2ec
> [ 7843.149203] --- interrupt: 3000 at 0x20000433acb4
> [ 7843.149208] NIP: 000020000433acb4 LR: 0000000000000000 CTR:
> 0000000000000000
> [ 7843.149212] REGS: c0000013aed5fe80 TRAP: 3000 Tainted: G
> I (6.8.0-rc3-autotest-g99bd3cb0d12e)
> [ 7843.149217] MSR: 800000000280f033
> <SF,VEC,VSX,EE,PR,FP,ME,IR,DR,RI,LE> CR: 42002408 XER: 00000000
> [ 7843.149227] IRQMASK: 0
> [ 7843.149227] GPR00: 0000000000000004 00007fffcde2d2c0
> 000000013a707f00 0000000000000006
> [ 7843.149227] GPR04: 00007fffcde2d368 0000000000000020
> 0000000000000000 0000000000000001
> [ 7843.149227] GPR08: 0000000000000020 0000000000000000
> 0000000000000000 0000000000000000
> [ 7843.149227] GPR12: 0000000000000000 000020000403b1e0
> 000000013a6df668 0000000000000006
> [ 7843.149227] GPR16: 0000000000000000 0000000000000002
> 0000000000000004 0000000000000005
> [ 7843.149227] GPR20: 000000013a700018 000000013a6df360
> 000000013a6dcb20 000000013a6dd918
> [ 7843.149227] GPR24: 000000013a6db178 00000001722028c8
> 00007fffcde2d7f8 00000001722028c8
> [ 7843.149227] GPR28: 000000013a6dc340 00007fffcde2d368
> 0000000000000006 0000000000000020
> [ 7843.149268] NIP [000020000433acb4] 0x20000433acb4
> [ 7843.149271] LR [0000000000000000] 0x0
> [ 7843.149274] --- interrupt: 3000
> [ 7843.149277] Code: 4082016c 2c3f0000 41820060 ebff0028 2c3f0000
> 41820054 e87f0018 2c230000 41820014 4890dc75 60000000 e93f0018
> <0b090000> e87f0020 2c230000 4182000c
> [ 7843.149292] ---[ end trace 0000000000000000 ]---
>
>
> Regards,
>
> Venkat.
>
>
>> Greetings!!!
>>
>>
>> [revert commit 83b3836bf83f09beea5f592b126cfdd1bc921e48] [mainline]
>> [6.8.0-rc3]kernel BUG at arch/powerpc/platforms/pseries/iommu.c:100!
>>
>>
>> Reverting below commit id issue is not seen.
>>
>> 83b3836bf83f09beea5f592b126cfdd1bc921e48
>> iommu: Allow ops->default_domain to work when !CONFIG_IOMMU_DMA
>>
>>
>> Traces:
>>
>>
>> KernelBug: Kernel bug in state 'None': kernel BUG at
>> arch/powerpc/platforms/pseries/iommu.c:100!
>> [ 7843.148980] Oops: Exception in kernel mode, sig: 5 [#1]
>> [ 7843.148984] LE PAGE_SIZE=64K MMU=Radix SMP NR_CPUS=8192 NUMA pSeries
>> [ 7843.148988] Modules linked in: nft_compat nf_tables libcrc32c
>> nfnetlink bridge stp llc tls sit tunnel4 ip_tunnel nvram rpadlpar_io
>> rpaphp xsk_diag rfkill binfmt_misc mlx5_ib ib_uverbs ib_core
>> pseries_rng drm drm_panel_orientation_quirks ext4 mbcache jbd2
>> dm_service_time sd_mod t10_pi crc64_rocksoft_generic crc64_rocksoft
>> crc64 sg ibmvfc scsi_transport_fc ibmveth mlx5_core mlxfw vmx_crypto
>> psample dm_multipath dm_mirror dm_region_hash dm_log dm_mod fuse
>> [last unloaded: tls]
>> [ 7843.149041] CPU: 17 PID: 218444 Comm: drmgr Kdump: loaded Tainted:
>> G I 6.8.0-rc3-autotest-g99bd3cb0d12e #1
>> [ 7843.149047] Hardware name: IBM,9080-HEX POWER10 (raw) 0x800200
>> 0xf000006 of:IBM,FW1060.00 (NH1060_016) hv:phyp pSeries
>> [ 7843.149051] NIP: c0000000000ff4d4 LR: c0000000000ff4cc CTR:
>> 0000000000000000
>> [ 7843.149055] REGS: c0000013aed5f840 TRAP: 0700 Tainted:
>> G I (6.8.0-rc3-autotest-g99bd3cb0d12e)
>> [ 7843.149060] MSR: 8000000000029033 <SF,EE,ME,IR,DR,RI,LE> CR:
>> 44002402 XER: 20040000
>> [ 7843.149069] CFAR: c000000000a0d170 IRQMASK: 0
>> [ 7843.149069] GPR00: c0000000000ff4cc c0000013aed5fae0
>> c000000001512700 c0000013aa362138
>> [ 7843.149069] GPR04: 0000000000000000 0000000000000000
>> 0000000000000000 0000000119c8afd0
>> [ 7843.149069] GPR08: 0000000000000000 c000001284442b00
>> 0000000000000001 0000000000001003
>> [ 7843.149069] GPR12: 0000000300000000 c0000018ffff2f00
>> 0000000000000000 0000000000000000
>> [ 7843.149069] GPR16: 0000000000000000 0000000000000000
>> 0000000000000000 0000000000000000
>> [ 7843.149069] GPR20: 0000000000000000 0000000000000000
>> 0000000000000000 0000000000000000
>> [ 7843.149069] GPR24: c0000013aed5fc40 0000000000000002
>> 0000000000000000 c000000002757d90
>> [ 7843.149069] GPR28: c0000000000ff440 c000000002757cb8
>> c00000183799c1a0 c0000013aa362b00
>> [ 7843.149112] NIP [c0000000000ff4d4] iommu_reconfig_notifier+0x94/0x200
>> [ 7843.149123] LR [c0000000000ff4cc] iommu_reconfig_notifier+0x8c/0x200
>> [ 7843.149129] Call Trace:
>> [ 7843.149131] [c0000013aed5fae0] [c0000000000ff4cc]
>> iommu_reconfig_notifier+0x8c/0x200 (unreliable)
>> [ 7843.149138] [c0000013aed5fb10] [c0000000001a27b0]
>> notifier_call_chain+0xb8/0x19c
>> [ 7843.149146] [c0000013aed5fb70] [c0000000001a2a78]
>> blocking_notifier_call_chain+0x64/0x98
>> [ 7843.149152] [c0000013aed5fbb0] [c000000000c4a898]
>> of_reconfig_notify+0x44/0xdc
>> [ 7843.149160] [c0000013aed5fc20] [c000000000c4add4]
>> of_detach_node+0x78/0xb0
>> [ 7843.149165] [c0000013aed5fc70] [c0000000000f96a8]
>> ofdt_write.part.0+0x86c/0xbb8
>> [ 7843.149171] [c0000013aed5fce0] [c00000000069b4bc]
>> proc_reg_write+0xf4/0x150
>> [ 7843.149178] [c0000013aed5fd10] [c0000000005bfeb4]
>> vfs_write+0xf8/0x488
>> [ 7843.149184] [c0000013aed5fdc0] [c0000000005c0570]
>> ksys_write+0x84/0x140
>> [ 7843.149189] [c0000013aed5fe10] [c000000000033358]
>> system_call_exception+0x138/0x330
>> [ 7843.149196] [c0000013aed5fe50] [c00000000000d05c]
>> system_call_vectored_common+0x15c/0x2ec
>> [ 7843.149203] --- interrupt: 3000 at 0x20000433acb4
>> [ 7843.149208] NIP: 000020000433acb4 LR: 0000000000000000 CTR:
>> 0000000000000000
>> [ 7843.149212] REGS: c0000013aed5fe80 TRAP: 3000 Tainted:
>> G I (6.8.0-rc3-autotest-g99bd3cb0d12e)
>> [ 7843.149217] MSR: 800000000280f033
>> <SF,VEC,VSX,EE,PR,FP,ME,IR,DR,RI,LE> CR: 42002408 XER: 00000000
>> [ 7843.149227] IRQMASK: 0
>> [ 7843.149227] GPR00: 0000000000000004 00007fffcde2d2c0
>> 000000013a707f00 0000000000000006
>> [ 7843.149227] GPR04: 00007fffcde2d368 0000000000000020
>> 0000000000000000 0000000000000001
>> [ 7843.149227] GPR08: 0000000000000020 0000000000000000
>> 0000000000000000 0000000000000000
>> [ 7843.149227] GPR12: 0000000000000000 000020000403b1e0
>> 000000013a6df668 0000000000000006
>> [ 7843.149227] GPR16: 0000000000000000 0000000000000002
>> 0000000000000004 0000000000000005
>> [ 7843.149227] GPR20: 000000013a700018 000000013a6df360
>> 000000013a6dcb20 000000013a6dd918
>> [ 7843.149227] GPR24: 000000013a6db178 00000001722028c8
>> 00007fffcde2d7f8 00000001722028c8
>> [ 7843.149227] GPR28: 000000013a6dc340 00007fffcde2d368
>> 0000000000000006 0000000000000020
>> [ 7843.149268] NIP [000020000433acb4] 0x20000433acb4
>> [ 7843.149271] LR [0000000000000000] 0x0
>> [ 7843.149274] --- interrupt: 3000
>> [ 7843.149277] Code: 4082016c 2c3f0000 41820060 ebff0028 2c3f0000
>> 41820054 e87f0018 2c230000 41820014 4890dc75 60000000 e93f0018
>> <0b090000> e87f0020 2c230000 4182000c
>> [ 7843.149292] ---[ end trace 0000000000000000 ]---
>>
>>
>> Regards,
>> Venkat.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [revert commit 83b3836bf83f09beea5f592b126cfdd1bc921e48] [mainline] [6.8.0-rc3]kernel BUG at arch/powerpc/platforms/pseries/iommu.c:100!
@ 2024-02-08 5:53 ` Venkat Rao Bagalkote
0 siblings, 0 replies; 5+ messages in thread
From: Venkat Rao Bagalkote @ 2024-02-08 5:53 UTC (permalink / raw)
To: iommu, jgg, linuxppc-dev, linux-kernel
Cc: sbhat, robin.murphy, tasmiya, sachinp, abdhalee, mputtash, will
Adding more people
On 08/02/24 8:26 am, Venkat Rao Bagalkote wrote:
>
> Resending as earlier one bounced.
>
> Greetings!!!
>
>
> [revert commit 83b3836bf83f09beea5f592b126cfdd1bc921e48] [mainline]
> [6.8.0-rc3]kernel BUG at arch/powerpc/platforms/pseries/iommu.c:100!
>
>
> By Reverting below commit id, issue is not seen.
>
>
> 83b3836bf83f09beea5f592b126cfdd1bc921e48
> iommu: Allow ops->default_domain to work when !CONFIG_IOMMU_DMA
>
>
> --- Traces ---
>
> KernelBug: Kernel bug in state 'None': kernel BUG at
> arch/powerpc/platforms/pseries/iommu.c:100!
> [ 7843.148980] Oops: Exception in kernel mode, sig: 5 [#1]
> [ 7843.148984] LE PAGE_SIZE=64K MMU=Radix SMP NR_CPUS=8192 NUMA pSeries
> [ 7843.148988] Modules linked in: nft_compat nf_tables libcrc32c
> nfnetlink bridge stp llc tls sit tunnel4 ip_tunnel nvram rpadlpar_io
> rpaphp xsk_diag rfkill binfmt_misc mlx5_ib ib_uverbs ib_core
> pseries_rng drm drm_panel_orientation_quirks ext4 mbcache jbd2
> dm_service_time sd_mod t10_pi crc64_rocksoft_generic crc64_rocksoft
> crc64 sg ibmvfc scsi_transport_fc ibmveth mlx5_core mlxfw vmx_crypto
> psample dm_multipath dm_mirror dm_region_hash dm_log dm_mod fuse [last
> unloaded: tls]
> [ 7843.149041] CPU: 17 PID: 218444 Comm: drmgr Kdump: loaded Tainted:
> G I 6.8.0-rc3-autotest-g99bd3cb0d12e #1
> [ 7843.149047] Hardware name: IBM,9080-HEX POWER10 (raw) 0x800200
> 0xf000006 of:IBM,FW1060.00 (NH1060_016) hv:phyp pSeries
> [ 7843.149051] NIP: c0000000000ff4d4 LR: c0000000000ff4cc CTR:
> 0000000000000000
> [ 7843.149055] REGS: c0000013aed5f840 TRAP: 0700 Tainted: G
> I (6.8.0-rc3-autotest-g99bd3cb0d12e)
> [ 7843.149060] MSR: 8000000000029033 <SF,EE,ME,IR,DR,RI,LE> CR:
> 44002402 XER: 20040000
> [ 7843.149069] CFAR: c000000000a0d170 IRQMASK: 0
> [ 7843.149069] GPR00: c0000000000ff4cc c0000013aed5fae0
> c000000001512700 c0000013aa362138
> [ 7843.149069] GPR04: 0000000000000000 0000000000000000
> 0000000000000000 0000000119c8afd0
> [ 7843.149069] GPR08: 0000000000000000 c000001284442b00
> 0000000000000001 0000000000001003
> [ 7843.149069] GPR12: 0000000300000000 c0000018ffff2f00
> 0000000000000000 0000000000000000
> [ 7843.149069] GPR16: 0000000000000000 0000000000000000
> 0000000000000000 0000000000000000
> [ 7843.149069] GPR20: 0000000000000000 0000000000000000
> 0000000000000000 0000000000000000
> [ 7843.149069] GPR24: c0000013aed5fc40 0000000000000002
> 0000000000000000 c000000002757d90
> [ 7843.149069] GPR28: c0000000000ff440 c000000002757cb8
> c00000183799c1a0 c0000013aa362b00
> [ 7843.149112] NIP [c0000000000ff4d4] iommu_reconfig_notifier+0x94/0x200
> [ 7843.149123] LR [c0000000000ff4cc] iommu_reconfig_notifier+0x8c/0x200
> [ 7843.149129] Call Trace:
> [ 7843.149131] [c0000013aed5fae0] [c0000000000ff4cc]
> iommu_reconfig_notifier+0x8c/0x200 (unreliable)
> [ 7843.149138] [c0000013aed5fb10] [c0000000001a27b0]
> notifier_call_chain+0xb8/0x19c
> [ 7843.149146] [c0000013aed5fb70] [c0000000001a2a78]
> blocking_notifier_call_chain+0x64/0x98
> [ 7843.149152] [c0000013aed5fbb0] [c000000000c4a898]
> of_reconfig_notify+0x44/0xdc
> [ 7843.149160] [c0000013aed5fc20] [c000000000c4add4]
> of_detach_node+0x78/0xb0
> [ 7843.149165] [c0000013aed5fc70] [c0000000000f96a8]
> ofdt_write.part.0+0x86c/0xbb8
> [ 7843.149171] [c0000013aed5fce0] [c00000000069b4bc]
> proc_reg_write+0xf4/0x150
> [ 7843.149178] [c0000013aed5fd10] [c0000000005bfeb4] vfs_write+0xf8/0x488
> [ 7843.149184] [c0000013aed5fdc0] [c0000000005c0570]
> ksys_write+0x84/0x140
> [ 7843.149189] [c0000013aed5fe10] [c000000000033358]
> system_call_exception+0x138/0x330
> [ 7843.149196] [c0000013aed5fe50] [c00000000000d05c]
> system_call_vectored_common+0x15c/0x2ec
> [ 7843.149203] --- interrupt: 3000 at 0x20000433acb4
> [ 7843.149208] NIP: 000020000433acb4 LR: 0000000000000000 CTR:
> 0000000000000000
> [ 7843.149212] REGS: c0000013aed5fe80 TRAP: 3000 Tainted: G
> I (6.8.0-rc3-autotest-g99bd3cb0d12e)
> [ 7843.149217] MSR: 800000000280f033
> <SF,VEC,VSX,EE,PR,FP,ME,IR,DR,RI,LE> CR: 42002408 XER: 00000000
> [ 7843.149227] IRQMASK: 0
> [ 7843.149227] GPR00: 0000000000000004 00007fffcde2d2c0
> 000000013a707f00 0000000000000006
> [ 7843.149227] GPR04: 00007fffcde2d368 0000000000000020
> 0000000000000000 0000000000000001
> [ 7843.149227] GPR08: 0000000000000020 0000000000000000
> 0000000000000000 0000000000000000
> [ 7843.149227] GPR12: 0000000000000000 000020000403b1e0
> 000000013a6df668 0000000000000006
> [ 7843.149227] GPR16: 0000000000000000 0000000000000002
> 0000000000000004 0000000000000005
> [ 7843.149227] GPR20: 000000013a700018 000000013a6df360
> 000000013a6dcb20 000000013a6dd918
> [ 7843.149227] GPR24: 000000013a6db178 00000001722028c8
> 00007fffcde2d7f8 00000001722028c8
> [ 7843.149227] GPR28: 000000013a6dc340 00007fffcde2d368
> 0000000000000006 0000000000000020
> [ 7843.149268] NIP [000020000433acb4] 0x20000433acb4
> [ 7843.149271] LR [0000000000000000] 0x0
> [ 7843.149274] --- interrupt: 3000
> [ 7843.149277] Code: 4082016c 2c3f0000 41820060 ebff0028 2c3f0000
> 41820054 e87f0018 2c230000 41820014 4890dc75 60000000 e93f0018
> <0b090000> e87f0020 2c230000 4182000c
> [ 7843.149292] ---[ end trace 0000000000000000 ]---
>
>
> Regards,
>
> Venkat.
>
>
>> Greetings!!!
>>
>>
>> [revert commit 83b3836bf83f09beea5f592b126cfdd1bc921e48] [mainline]
>> [6.8.0-rc3]kernel BUG at arch/powerpc/platforms/pseries/iommu.c:100!
>>
>>
>> Reverting below commit id issue is not seen.
>>
>> 83b3836bf83f09beea5f592b126cfdd1bc921e48
>> iommu: Allow ops->default_domain to work when !CONFIG_IOMMU_DMA
>>
>>
>> Traces:
>>
>>
>> KernelBug: Kernel bug in state 'None': kernel BUG at
>> arch/powerpc/platforms/pseries/iommu.c:100!
>> [ 7843.148980] Oops: Exception in kernel mode, sig: 5 [#1]
>> [ 7843.148984] LE PAGE_SIZE=64K MMU=Radix SMP NR_CPUS=8192 NUMA pSeries
>> [ 7843.148988] Modules linked in: nft_compat nf_tables libcrc32c
>> nfnetlink bridge stp llc tls sit tunnel4 ip_tunnel nvram rpadlpar_io
>> rpaphp xsk_diag rfkill binfmt_misc mlx5_ib ib_uverbs ib_core
>> pseries_rng drm drm_panel_orientation_quirks ext4 mbcache jbd2
>> dm_service_time sd_mod t10_pi crc64_rocksoft_generic crc64_rocksoft
>> crc64 sg ibmvfc scsi_transport_fc ibmveth mlx5_core mlxfw vmx_crypto
>> psample dm_multipath dm_mirror dm_region_hash dm_log dm_mod fuse
>> [last unloaded: tls]
>> [ 7843.149041] CPU: 17 PID: 218444 Comm: drmgr Kdump: loaded Tainted:
>> G I 6.8.0-rc3-autotest-g99bd3cb0d12e #1
>> [ 7843.149047] Hardware name: IBM,9080-HEX POWER10 (raw) 0x800200
>> 0xf000006 of:IBM,FW1060.00 (NH1060_016) hv:phyp pSeries
>> [ 7843.149051] NIP: c0000000000ff4d4 LR: c0000000000ff4cc CTR:
>> 0000000000000000
>> [ 7843.149055] REGS: c0000013aed5f840 TRAP: 0700 Tainted:
>> G I (6.8.0-rc3-autotest-g99bd3cb0d12e)
>> [ 7843.149060] MSR: 8000000000029033 <SF,EE,ME,IR,DR,RI,LE> CR:
>> 44002402 XER: 20040000
>> [ 7843.149069] CFAR: c000000000a0d170 IRQMASK: 0
>> [ 7843.149069] GPR00: c0000000000ff4cc c0000013aed5fae0
>> c000000001512700 c0000013aa362138
>> [ 7843.149069] GPR04: 0000000000000000 0000000000000000
>> 0000000000000000 0000000119c8afd0
>> [ 7843.149069] GPR08: 0000000000000000 c000001284442b00
>> 0000000000000001 0000000000001003
>> [ 7843.149069] GPR12: 0000000300000000 c0000018ffff2f00
>> 0000000000000000 0000000000000000
>> [ 7843.149069] GPR16: 0000000000000000 0000000000000000
>> 0000000000000000 0000000000000000
>> [ 7843.149069] GPR20: 0000000000000000 0000000000000000
>> 0000000000000000 0000000000000000
>> [ 7843.149069] GPR24: c0000013aed5fc40 0000000000000002
>> 0000000000000000 c000000002757d90
>> [ 7843.149069] GPR28: c0000000000ff440 c000000002757cb8
>> c00000183799c1a0 c0000013aa362b00
>> [ 7843.149112] NIP [c0000000000ff4d4] iommu_reconfig_notifier+0x94/0x200
>> [ 7843.149123] LR [c0000000000ff4cc] iommu_reconfig_notifier+0x8c/0x200
>> [ 7843.149129] Call Trace:
>> [ 7843.149131] [c0000013aed5fae0] [c0000000000ff4cc]
>> iommu_reconfig_notifier+0x8c/0x200 (unreliable)
>> [ 7843.149138] [c0000013aed5fb10] [c0000000001a27b0]
>> notifier_call_chain+0xb8/0x19c
>> [ 7843.149146] [c0000013aed5fb70] [c0000000001a2a78]
>> blocking_notifier_call_chain+0x64/0x98
>> [ 7843.149152] [c0000013aed5fbb0] [c000000000c4a898]
>> of_reconfig_notify+0x44/0xdc
>> [ 7843.149160] [c0000013aed5fc20] [c000000000c4add4]
>> of_detach_node+0x78/0xb0
>> [ 7843.149165] [c0000013aed5fc70] [c0000000000f96a8]
>> ofdt_write.part.0+0x86c/0xbb8
>> [ 7843.149171] [c0000013aed5fce0] [c00000000069b4bc]
>> proc_reg_write+0xf4/0x150
>> [ 7843.149178] [c0000013aed5fd10] [c0000000005bfeb4]
>> vfs_write+0xf8/0x488
>> [ 7843.149184] [c0000013aed5fdc0] [c0000000005c0570]
>> ksys_write+0x84/0x140
>> [ 7843.149189] [c0000013aed5fe10] [c000000000033358]
>> system_call_exception+0x138/0x330
>> [ 7843.149196] [c0000013aed5fe50] [c00000000000d05c]
>> system_call_vectored_common+0x15c/0x2ec
>> [ 7843.149203] --- interrupt: 3000 at 0x20000433acb4
>> [ 7843.149208] NIP: 000020000433acb4 LR: 0000000000000000 CTR:
>> 0000000000000000
>> [ 7843.149212] REGS: c0000013aed5fe80 TRAP: 3000 Tainted:
>> G I (6.8.0-rc3-autotest-g99bd3cb0d12e)
>> [ 7843.149217] MSR: 800000000280f033
>> <SF,VEC,VSX,EE,PR,FP,ME,IR,DR,RI,LE> CR: 42002408 XER: 00000000
>> [ 7843.149227] IRQMASK: 0
>> [ 7843.149227] GPR00: 0000000000000004 00007fffcde2d2c0
>> 000000013a707f00 0000000000000006
>> [ 7843.149227] GPR04: 00007fffcde2d368 0000000000000020
>> 0000000000000000 0000000000000001
>> [ 7843.149227] GPR08: 0000000000000020 0000000000000000
>> 0000000000000000 0000000000000000
>> [ 7843.149227] GPR12: 0000000000000000 000020000403b1e0
>> 000000013a6df668 0000000000000006
>> [ 7843.149227] GPR16: 0000000000000000 0000000000000002
>> 0000000000000004 0000000000000005
>> [ 7843.149227] GPR20: 000000013a700018 000000013a6df360
>> 000000013a6dcb20 000000013a6dd918
>> [ 7843.149227] GPR24: 000000013a6db178 00000001722028c8
>> 00007fffcde2d7f8 00000001722028c8
>> [ 7843.149227] GPR28: 000000013a6dc340 00007fffcde2d368
>> 0000000000000006 0000000000000020
>> [ 7843.149268] NIP [000020000433acb4] 0x20000433acb4
>> [ 7843.149271] LR [0000000000000000] 0x0
>> [ 7843.149274] --- interrupt: 3000
>> [ 7843.149277] Code: 4082016c 2c3f0000 41820060 ebff0028 2c3f0000
>> 41820054 e87f0018 2c230000 41820014 4890dc75 60000000 e93f0018
>> <0b090000> e87f0020 2c230000 4182000c
>> [ 7843.149292] ---[ end trace 0000000000000000 ]---
>>
>>
>> Regards,
>> Venkat.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [revert commit 83b3836bf83f09beea5f592b126cfdd1bc921e48] [mainline] [6.8.0-rc3]kernel BUG at arch/powerpc/platforms/pseries/iommu.c:100!
2024-02-07 16:32 ` [revert commit 83b3836bf83f09beea5f592b126cfdd1bc921e48] [mainline] [6.8.0-rc3]kernel BUG at arch/powerpc/platforms/pseries/iommu.c:100! Jason Gunthorpe
@ 2024-02-13 16:16 ` Shivaprasad G Bhat
0 siblings, 0 replies; 5+ messages in thread
From: Shivaprasad G Bhat @ 2024-02-13 16:16 UTC (permalink / raw)
To: Jason Gunthorpe, Venkat Rao Bagalkote, Ovidiu Panait
Cc: iommu, robin.murphy, will
On 2/7/24 22:02, Jason Gunthorpe wrote:
> On Wed, Feb 07, 2024 at 09:53:30PM +0530, Venkat Rao Bagalkote wrote:
>> Greetings!!!
>>
>> [revert commit 83b3836bf83f09beea5f592b126cfdd1bc921e48] [mainline]
>> [6.8.0-rc3]kernel BUG at arch/powerpc/platforms/pseries/iommu.c:100!
>>
>> Reverting below commit id issue is not seen.
>> 83b3836bf83f09beea5f592b126cfdd1bc921e48
>> iommu: Allow ops->default_domain to work when !CONFIG_IOMMU_DMA
> Well, you'll get probing failures if you revert it, so this seems like
> a false bisection.. Though no doubt it will land on one of the earlier
> iommu patches.
I did bisect the issue. The issue is with the commit
a8ca9fc9134c ("powerpc/iommu: Do not do platform domain attach atctions
after probe")
>> [ 7843.149112] NIP [c0000000000ff4d4] iommu_reconfig_notifier+0x94/0x200
>> [ 7843.149123] LR [c0000000000ff4cc] iommu_reconfig_notifier+0x8c/0x200
>> [ 7843.149129] Call Trace:
>> [ 7843.149131] [c0000013aed5fae0] [c0000000000ff4cc] iommu_reconfig_notifier+0x8
>> c/0x200 (unreliable)
>> [ 7843.149138] [c0000013aed5fb10] [c0000000001a27b0] notifier_call_chain+0xb8/0x
>> 19c
>> [ 7843.149146] [c0000013aed5fb70] [c0000000001a2a78] blocking_notifier_call_chai
>> n+0x64/0x98
>> [ 7843.149152] [c0000013aed5fbb0] [c000000000c4a898] of_reconfig_notify+0x44/0xd
>> c
>> [ 7843.149160] [c0000013aed5fc20] [c000000000c4add4] of_detach_node+0x78/0xb0
>> [ 7843.149165] [c0000013aed5fc70] [c0000000000f96a8] ofdt_write.part.0+0x86c/0xb
>> b8
>> [ 7843.149171] [c0000013aed5fce0] [c00000000069b4bc] proc_reg_write+0xf4/0x150
>> [ 7843.149178] [c0000013aed5fd10] [c0000000005bfeb4] vfs_write+0xf8/0x488
>> [ 7843.149184] [c0000013aed5fdc0] [c0000000005c0570] ksys_write+0x84/0x140
>> [ 7843.149189] [c0000013aed5fe10] [c000000000033358] system_call_exception+0x138
>> /0x330
>> [ 7843.149196] [c0000013aed5fe50] [c00000000000d05c] system_call_vectored_common
>> +0x15c/0x2ec
> What is all this?
>
> Why is it reaching into the iommu space and messing it up from a
> notifier and then crashing when it is not in the state it expects?
>
> If a DT property is being removed shouldn't that be achieved by
> removing the device first and letting the normal iommu driver release
> flow run?
I see this is initiated from the drmgr tool from powerpc-utils. Its actually
operating on the device tree first.
> I have no idea what this is doing, but it looks sketchy :\
>
> Shivaprasad/Ovidiu can you look at this? It looks like some case with
> hot device removal?
Yes. This is happening with hot unplug case. The issue here is a missing
iommu_group_put() call in spapr_tce_platform_iommu_attach_dev() leading
to the leak.
I have posted the fix here -
https://lore.kernel.org/all/170784021983.6249.10039296655906636112.stgit@linux.ibm.com/
Thanks,
Shivaprasad
> Thanks,
> Jason
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-02-13 16:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <798229fe-906e-441b-b7a3-44c475cf1e9f@linux.vnet.ibm.com>
2024-02-07 16:32 ` [revert commit 83b3836bf83f09beea5f592b126cfdd1bc921e48] [mainline] [6.8.0-rc3]kernel BUG at arch/powerpc/platforms/pseries/iommu.c:100! Jason Gunthorpe
2024-02-13 16:16 ` Shivaprasad G Bhat
[not found] <8d75ebd3-85c2-4a05-8eca-08f66f9411dc@linux.vnet.ibm.com>
2024-02-08 2:56 ` Venkat Rao Bagalkote
2024-02-08 5:53 ` Venkat Rao Bagalkote
2024-02-08 5:53 ` Venkat Rao Bagalkote
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.