From: Simon Horman <horms@kernel.org>
To: Diogo Ivo <diogo.ivo@siemens.com>
Cc: danishanwar@ti.com, rogerq@kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
andrew@lunn.ch, vigneshr@ti.com, jan.kiszka@siemens.com,
dan.carpenter@linaro.org, robh@kernel.org,
grygorii.strashko@ti.com, linux-arm-kernel@lists.infradead.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net] net: ti: icssg-prueth: Remove duplicate cleanup calls in emac_ndo_stop()
Date: Thu, 8 Feb 2024 10:47:00 +0000 [thread overview]
Message-ID: <20240208104700.GF1435458@kernel.org> (raw)
In-Reply-To: <20240206152052.98217-1-diogo.ivo@siemens.com>
On Tue, Feb 06, 2024 at 03:20:51PM +0000, Diogo Ivo wrote:
> Remove the duplicate calls to prueth_emac_stop() and
> prueth_cleanup_tx_chns() in emac_ndo_stop().
>
> Fixes: 128d5874c082 ("net: ti: icssg-prueth: Add ICSSG ethernet driver")
> Fixes: 186734c15886 ("net: ti: icssg-prueth: add packet timestamping and ptp support")
> Signed-off-by: Diogo Ivo <diogo.ivo@siemens.com>
Hi Doigo,
I see that there are indeed duplicate calls,
but I do wonder if this is a cleanup rather than a bug:
is there a user-visible problem that this addresses?
If so, I think it would be good to spell this out in the commit message.
...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Diogo Ivo <diogo.ivo@siemens.com>
Cc: danishanwar@ti.com, rogerq@kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
andrew@lunn.ch, vigneshr@ti.com, jan.kiszka@siemens.com,
dan.carpenter@linaro.org, robh@kernel.org,
grygorii.strashko@ti.com, linux-arm-kernel@lists.infradead.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net] net: ti: icssg-prueth: Remove duplicate cleanup calls in emac_ndo_stop()
Date: Thu, 8 Feb 2024 10:47:00 +0000 [thread overview]
Message-ID: <20240208104700.GF1435458@kernel.org> (raw)
In-Reply-To: <20240206152052.98217-1-diogo.ivo@siemens.com>
On Tue, Feb 06, 2024 at 03:20:51PM +0000, Diogo Ivo wrote:
> Remove the duplicate calls to prueth_emac_stop() and
> prueth_cleanup_tx_chns() in emac_ndo_stop().
>
> Fixes: 128d5874c082 ("net: ti: icssg-prueth: Add ICSSG ethernet driver")
> Fixes: 186734c15886 ("net: ti: icssg-prueth: add packet timestamping and ptp support")
> Signed-off-by: Diogo Ivo <diogo.ivo@siemens.com>
Hi Doigo,
I see that there are indeed duplicate calls,
but I do wonder if this is a cleanup rather than a bug:
is there a user-visible problem that this addresses?
If so, I think it would be good to spell this out in the commit message.
...
next prev parent reply other threads:[~2024-02-08 10:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 15:20 [PATCH net] net: ti: icssg-prueth: Remove duplicate cleanup calls in emac_ndo_stop() Diogo Ivo
2024-02-06 15:20 ` Diogo Ivo
2024-02-08 10:47 ` Simon Horman [this message]
2024-02-08 10:47 ` Simon Horman
2024-02-08 13:33 ` Dan Carpenter
2024-02-08 13:33 ` Dan Carpenter
2024-02-08 14:11 ` Diogo Ivo
2024-02-08 14:11 ` Diogo Ivo
2024-02-08 11:52 ` Roger Quadros
2024-02-08 11:52 ` Roger Quadros
2024-02-08 14:53 ` Anwar, Md Danish
2024-02-08 14:53 ` Anwar, Md Danish
2024-02-15 12:44 ` Diogo Ivo
2024-02-15 12:44 ` Diogo Ivo
2024-02-15 14:53 ` Andrew Lunn
2024-02-15 14:53 ` Andrew Lunn
2024-02-15 15:10 ` Diogo Ivo
2024-02-15 15:10 ` Diogo Ivo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240208104700.GF1435458@kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=dan.carpenter@linaro.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=diogo.ivo@siemens.com \
--cc=edumazet@google.com \
--cc=grygorii.strashko@ti.com \
--cc=jan.kiszka@siemens.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.