[chrome-os:chromeos-5.15 17/17] drivers/gpu/drm/drm_privacy_screen_x86.c:166:6: warning: no previous prototype for 'privacy_screen_present'

[chrome-os:chromeos-5.15 17/17] drivers/gpu/drm/drm_privacy_screen_x86.c:166:6: warning: no previous prototype for 'privacy_screen_present'

[kernel test robot]

tree:   https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.15
head:   663560d82c0a34a6b0a807e99ae307a0856c05dc
commit: 48cd81f48b5b21913f796d27b1a43b8dc04e6f2f [17/17] CHROMIUM: drm: privacy screen for drallion hack
config: x86_64-randconfig-161-20240207 (https://download.01.org/0day-ci/archive/20240208/202402081759.DreefTIL-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240208/202402081759.DreefTIL-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402081759.DreefTIL-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/drm_privacy_screen_x86.c:166:6: warning: no previous prototype for 'privacy_screen_present' [-Wmissing-prototypes]
     166 | bool privacy_screen_present(struct device *privacy_screen)
         |      ^~~~~~~~~~~~~~~~~~~~~~
   In file included from include/linux/device.h:15,
                    from include/linux/acpi.h:15,
                    from drivers/gpu/drm/drm_privacy_screen_x86.c:9:
   drivers/gpu/drm/drm_privacy_screen_x86.c: In function 'drm_drallion_privacy_screen_register':
>> drivers/gpu/drm/drm_privacy_screen_x86.c:200:37: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long int' [-Wformat=]
     200 |                 dev_err(&adev->dev, "Error registering privacy-screen: %d\n",
         |                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
     110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
         |                              ^~~
   include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
     144 |         dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                                                        ^~~~~~~
   drivers/gpu/drm/drm_privacy_screen_x86.c:200:17: note: in expansion of macro 'dev_err'
     200 |                 dev_err(&adev->dev, "Error registering privacy-screen: %d\n",
         |                 ^~~~~~~
   drivers/gpu/drm/drm_privacy_screen_x86.c:200:73: note: format string is defined here
     200 |                 dev_err(&adev->dev, "Error registering privacy-screen: %d\n",
         |                                                                        ~^
         |                                                                         |
         |                                                                         int
         |                                                                        %ld


vim +/privacy_screen_present +166 drivers/gpu/drm/drm_privacy_screen_x86.c

   165	
 > 166	bool privacy_screen_present(struct device *privacy_screen)
   167	{
   168		acpi_handle handle = acpi_device_handle(to_acpi_device(privacy_screen));
   169	
   170		if (!handle)
   171			return false;
   172	
   173		if (!acpi_check_dsm(handle, &chromeos_privacy_screen_dsm_guid, 1,
   174				    BIT(PRIV_SCRN_DSM_FN_GET_STATUS) |
   175					BIT(PRIV_SCRN_DSM_FN_ENABLE) |
   176					BIT(PRIV_SCRN_DSM_FN_DISABLE)))
   177			return false;
   178	
   179		return true;
   180	}
   181	
   182	static bool drm_drallion_privacy_screen_register(struct device *dev)
   183	{
   184	
   185		struct acpi_device *adev = to_acpi_device(dev);
   186	
   187		struct drm_privacy_screen *drm_privacy_screen;
   188	
   189		if (strcmp(dev_name(&adev->dev), "device:05") != 0) {
   190			dev_err(&adev->dev, "Unexpected device name for privacy screen: %s\n",
   191					dev_name(&adev->dev));
   192	
   193			return false;
   194		}
   195	
   196		drm_privacy_screen = drm_privacy_screen_register(
   197			&adev->dev, &chromeos_privacy_screen_ops, &adev->dev);
   198	
   199		if (IS_ERR(drm_privacy_screen)) {
 > 200			dev_err(&adev->dev, "Error registering privacy-screen: %d\n",
   201					PTR_ERR(drm_privacy_screen));
   202			return false;
   203		}
   204	
   205		adev->driver_data = drm_privacy_screen;
   206		dev_info(&adev->dev, "registered privacy-screen '%s'\n",
   207			 dev_name(&drm_privacy_screen->dev));
   208	
   209		return true;
   210	}
   211	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki