From: Rob Herring <robh@kernel.org>
To: Dharma.B@microchip.com
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
alexandre.belloni@bootlin.com, conor@kernel.org,
linux-kernel@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
claudiu.beznea@tuxon.dev, tglx@linutronix.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: interrupt-controller: Convert Atmel AIC to json-schema
Date: Fri, 9 Feb 2024 09:10:54 +0000 [thread overview]
Message-ID: <20240209091054.GA3291998-robh@kernel.org> (raw)
In-Reply-To: <8dcae60c-1aba-4e76-99cd-de78c2c4ba6a@microchip.com>
On Fri, Feb 09, 2024 at 06:31:15AM +0000, Dharma.B@microchip.com wrote:
> Hi Conor,
>
> On 09/02/24 12:19 am, Conor Dooley wrote:
> > Hey Dharma,
> >
> > On Thu, Feb 08, 2024 at 03:51:31PM +0000, Rob Herring wrote:
> >> On Thu, 08 Feb 2024 14:50:15 +0530, Dharma Balasubiramani wrote:
> >>> Convert the Atmel AIC binding document to DT schema format using
> >>> json-schema.
> >>>
> >>> Signed-off-by: Dharma Balasubiramani<dharma.b@microchip.com>
> >>> ---
> >>> Note: I get the following warnings on latest kernel but not in 6.7.
> >>> Should I be worried?
> >>> usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA] [--list-files] [-f {parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v] [FILE_OR_DIR [FILE_OR_DIR ...]]
> >>> yamllint: error: one of the arguments FILE_OR_DIR - is required
> > Hard to say, how were you envoking the command? There were some issues
> > recently with dt_binding_check, but I thought those had been fixed.
>
> I use this command to validate
>
> make ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml
Humm, not sure. Will have to investigate.
> and also dtbs_check.
>
> version = yamllint 1.32.0
> >
> >> dtschema/dtc warnings/errors:
> >> Documentation/devicetree/bindings/interrupt-controller/atmel,aic.example.dtb: /example-1/dma-controller@ffffec00: failed to match any schema with compatible: ['atmel,at91sam9g45-dma']
> > But you didn't see this warning?
>
> No I didn't see this warning when applied on tag:6.7. Don't know why.
That's because it just got enabled by default.
>
> > I think you can resolve it by just dropping the "user" example from the
> > binding entirely. I don't think it adds anything at all.
>
> I intentionally checked the generated example dts file and found that
> both the examples look correct.
Maybe so, but how do we know with no schema? Your choices are drop from
the example or add a schema for the DMA controller.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Dharma.B@microchip.com
Cc: conor@kernel.org, alexandre.belloni@bootlin.com,
conor+dt@kernel.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de, Nicolas.Ferre@microchip.com,
linux-arm-kernel@lists.infradead.org, claudiu.beznea@tuxon.dev,
devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH] dt-bindings: interrupt-controller: Convert Atmel AIC to json-schema
Date: Fri, 9 Feb 2024 09:10:54 +0000 [thread overview]
Message-ID: <20240209091054.GA3291998-robh@kernel.org> (raw)
In-Reply-To: <8dcae60c-1aba-4e76-99cd-de78c2c4ba6a@microchip.com>
On Fri, Feb 09, 2024 at 06:31:15AM +0000, Dharma.B@microchip.com wrote:
> Hi Conor,
>
> On 09/02/24 12:19 am, Conor Dooley wrote:
> > Hey Dharma,
> >
> > On Thu, Feb 08, 2024 at 03:51:31PM +0000, Rob Herring wrote:
> >> On Thu, 08 Feb 2024 14:50:15 +0530, Dharma Balasubiramani wrote:
> >>> Convert the Atmel AIC binding document to DT schema format using
> >>> json-schema.
> >>>
> >>> Signed-off-by: Dharma Balasubiramani<dharma.b@microchip.com>
> >>> ---
> >>> Note: I get the following warnings on latest kernel but not in 6.7.
> >>> Should I be worried?
> >>> usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA] [--list-files] [-f {parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v] [FILE_OR_DIR [FILE_OR_DIR ...]]
> >>> yamllint: error: one of the arguments FILE_OR_DIR - is required
> > Hard to say, how were you envoking the command? There were some issues
> > recently with dt_binding_check, but I thought those had been fixed.
>
> I use this command to validate
>
> make ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml
Humm, not sure. Will have to investigate.
> and also dtbs_check.
>
> version = yamllint 1.32.0
> >
> >> dtschema/dtc warnings/errors:
> >> Documentation/devicetree/bindings/interrupt-controller/atmel,aic.example.dtb: /example-1/dma-controller@ffffec00: failed to match any schema with compatible: ['atmel,at91sam9g45-dma']
> > But you didn't see this warning?
>
> No I didn't see this warning when applied on tag:6.7. Don't know why.
That's because it just got enabled by default.
>
> > I think you can resolve it by just dropping the "user" example from the
> > binding entirely. I don't think it adds anything at all.
>
> I intentionally checked the generated example dts file and found that
> both the examples look correct.
Maybe so, but how do we know with no schema? Your choices are drop from
the example or add a schema for the DMA controller.
Rob
next prev parent reply other threads:[~2024-02-09 9:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 9:20 [PATCH] dt-bindings: interrupt-controller: Convert Atmel AIC to json-schema Dharma Balasubiramani
2024-02-08 9:20 ` Dharma Balasubiramani
2024-02-08 15:51 ` Rob Herring
2024-02-08 15:51 ` Rob Herring
2024-02-08 18:49 ` Conor Dooley
2024-02-08 18:49 ` Conor Dooley
2024-02-09 6:31 ` Dharma.B
2024-02-09 6:31 ` Dharma.B
2024-02-09 9:10 ` Rob Herring [this message]
2024-02-09 9:10 ` Rob Herring
2024-02-09 9:16 ` Dharma.B
2024-02-09 9:16 ` Dharma.B
2024-02-08 23:10 ` Conor Dooley
2024-02-08 23:10 ` Conor Dooley
2024-02-09 9:41 ` Conor Dooley
2024-02-09 9:41 ` Conor Dooley
2024-02-09 9:44 ` Dharma.B
2024-02-09 9:44 ` Dharma.B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240209091054.GA3291998-robh@kernel.org \
--to=robh@kernel.org \
--cc=Dharma.B@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.