All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: kvm-riscv@lists.infradead.org
Subject: [kvm-unit-tests PATCH v4 2/8] arch-run: Clean up initrd cleanup
Date: Fri,  9 Feb 2024 19:11:28 +1000	[thread overview]
Message-ID: <20240209091134.600228-3-npiggin@gmail.com> (raw)
In-Reply-To: <20240209091134.600228-1-npiggin@gmail.com>

Rather than put a big script into the trap handler, have it call
a function.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 scripts/arch-run.bash | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash
index 11d47a85..c1dd67ab 100644
--- a/scripts/arch-run.bash
+++ b/scripts/arch-run.bash
@@ -269,10 +269,21 @@ search_qemu_binary ()
 	export PATH=$save_path
 }
 
+initrd_cleanup ()
+{
+	rm -f $KVM_UNIT_TESTS_ENV
+	if [ "$KVM_UNIT_TESTS_ENV_OLD" ]; then
+		export KVM_UNIT_TESTS_ENV="$KVM_UNIT_TESTS_ENV_OLD"
+	else
+		unset KVM_UNIT_TESTS_ENV
+	fi
+	unset KVM_UNIT_TESTS_ENV_OLD
+}
+
 initrd_create ()
 {
 	if [ "$ENVIRON_DEFAULT" = "yes" ]; then
-		trap_exit_push 'rm -f $KVM_UNIT_TESTS_ENV; [ "$KVM_UNIT_TESTS_ENV_OLD" ] && export KVM_UNIT_TESTS_ENV="$KVM_UNIT_TESTS_ENV_OLD" || unset KVM_UNIT_TESTS_ENV; unset KVM_UNIT_TESTS_ENV_OLD'
+		trap_exit_push 'initrd_cleanup'
 		[ -f "$KVM_UNIT_TESTS_ENV" ] && export KVM_UNIT_TESTS_ENV_OLD="$KVM_UNIT_TESTS_ENV"
 		export KVM_UNIT_TESTS_ENV=$(mktemp)
 		env_params
-- 
2.42.0



WARNING: multiple messages have this Message-ID (diff)
From: Nicholas Piggin <npiggin@gmail.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Nicholas Piggin <npiggin@gmail.com>,
	kvm@vger.kernel.org, Laurent Vivier <lvivier@redhat.com>,
	"Shaoqin Huang" <shahuang@redhat.com>,
	Andrew Jones <andrew.jones@linux.dev>,
	Nico Boehr <nrb@linux.ibm.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	Eric Auger <eric.auger@redhat.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	David Hildenbrand <david@redhat.com>,
	Marc Hartmayer <mhartmay@linux.ibm.com>,
	linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
	kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org
Subject: [kvm-unit-tests PATCH v4 2/8] arch-run: Clean up initrd cleanup
Date: Fri,  9 Feb 2024 19:11:28 +1000	[thread overview]
Message-ID: <20240209091134.600228-3-npiggin@gmail.com> (raw)
In-Reply-To: <20240209091134.600228-1-npiggin@gmail.com>

Rather than put a big script into the trap handler, have it call
a function.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 scripts/arch-run.bash | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash
index 11d47a85..c1dd67ab 100644
--- a/scripts/arch-run.bash
+++ b/scripts/arch-run.bash
@@ -269,10 +269,21 @@ search_qemu_binary ()
 	export PATH=$save_path
 }
 
+initrd_cleanup ()
+{
+	rm -f $KVM_UNIT_TESTS_ENV
+	if [ "$KVM_UNIT_TESTS_ENV_OLD" ]; then
+		export KVM_UNIT_TESTS_ENV="$KVM_UNIT_TESTS_ENV_OLD"
+	else
+		unset KVM_UNIT_TESTS_ENV
+	fi
+	unset KVM_UNIT_TESTS_ENV_OLD
+}
+
 initrd_create ()
 {
 	if [ "$ENVIRON_DEFAULT" = "yes" ]; then
-		trap_exit_push 'rm -f $KVM_UNIT_TESTS_ENV; [ "$KVM_UNIT_TESTS_ENV_OLD" ] && export KVM_UNIT_TESTS_ENV="$KVM_UNIT_TESTS_ENV_OLD" || unset KVM_UNIT_TESTS_ENV; unset KVM_UNIT_TESTS_ENV_OLD'
+		trap_exit_push 'initrd_cleanup'
 		[ -f "$KVM_UNIT_TESTS_ENV" ] && export KVM_UNIT_TESTS_ENV_OLD="$KVM_UNIT_TESTS_ENV"
 		export KVM_UNIT_TESTS_ENV=$(mktemp)
 		env_params
-- 
2.42.0


WARNING: multiple messages have this Message-ID (diff)
From: Nicholas Piggin <npiggin@gmail.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
	linux-s390@vger.kernel.org, Nico Boehr <nrb@linux.ibm.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	kvm@vger.kernel.org, David Hildenbrand <david@redhat.com>,
	linuxppc-dev@lists.ozlabs.org,
	Shaoqin Huang <shahuang@redhat.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Andrew Jones <andrew.jones@linux.dev>,
	Eric Auger <eric.auger@redhat.com>,
	Marc Hartmayer <mhartmay@linux.ibm.com>,
	kvm-riscv@lists.infradead.org, kvmarm@lists.linux.dev,
	Paolo Bonzini <pbonzini@redhat.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	Alexandru Elisei <alexandru.elisei@arm.com>
Subject: [kvm-unit-tests PATCH v4 2/8] arch-run: Clean up initrd cleanup
Date: Fri,  9 Feb 2024 19:11:28 +1000	[thread overview]
Message-ID: <20240209091134.600228-3-npiggin@gmail.com> (raw)
In-Reply-To: <20240209091134.600228-1-npiggin@gmail.com>

Rather than put a big script into the trap handler, have it call
a function.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 scripts/arch-run.bash | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash
index 11d47a85..c1dd67ab 100644
--- a/scripts/arch-run.bash
+++ b/scripts/arch-run.bash
@@ -269,10 +269,21 @@ search_qemu_binary ()
 	export PATH=$save_path
 }
 
+initrd_cleanup ()
+{
+	rm -f $KVM_UNIT_TESTS_ENV
+	if [ "$KVM_UNIT_TESTS_ENV_OLD" ]; then
+		export KVM_UNIT_TESTS_ENV="$KVM_UNIT_TESTS_ENV_OLD"
+	else
+		unset KVM_UNIT_TESTS_ENV
+	fi
+	unset KVM_UNIT_TESTS_ENV_OLD
+}
+
 initrd_create ()
 {
 	if [ "$ENVIRON_DEFAULT" = "yes" ]; then
-		trap_exit_push 'rm -f $KVM_UNIT_TESTS_ENV; [ "$KVM_UNIT_TESTS_ENV_OLD" ] && export KVM_UNIT_TESTS_ENV="$KVM_UNIT_TESTS_ENV_OLD" || unset KVM_UNIT_TESTS_ENV; unset KVM_UNIT_TESTS_ENV_OLD'
+		trap_exit_push 'initrd_cleanup'
 		[ -f "$KVM_UNIT_TESTS_ENV" ] && export KVM_UNIT_TESTS_ENV_OLD="$KVM_UNIT_TESTS_ENV"
 		export KVM_UNIT_TESTS_ENV=$(mktemp)
 		env_params
-- 
2.42.0


  parent reply	other threads:[~2024-02-09  9:11 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09  9:11 [kvm-unit-tests PATCH v4 0/8] Multi-migration support Nicholas Piggin
2024-02-09  9:11 ` Nicholas Piggin
2024-02-09  9:11 ` Nicholas Piggin
2024-02-09  9:11 ` [kvm-unit-tests PATCH v4 1/8] arch-run: Fix TRAP handler recursion to remove temporary files properly Nicholas Piggin
2024-02-09  9:11   ` Nicholas Piggin
2024-02-09  9:11   ` Nicholas Piggin
2024-02-09  9:11 ` Nicholas Piggin [this message]
2024-02-09  9:11   ` [kvm-unit-tests PATCH v4 2/8] arch-run: Clean up initrd cleanup Nicholas Piggin
2024-02-09  9:11   ` Nicholas Piggin
2024-02-09 15:44   ` Thomas Huth
2024-02-09 15:44     ` Thomas Huth
2024-02-09 15:44     ` Thomas Huth
2024-02-09  9:11 ` [kvm-unit-tests PATCH v4 3/8] migration: use a more robust way to wait for background job Nicholas Piggin
2024-02-09  9:11   ` Nicholas Piggin
2024-02-09  9:11   ` Nicholas Piggin
2024-02-09  9:11 ` [kvm-unit-tests PATCH v4 4/8] migration: Support multiple migrations Nicholas Piggin
2024-02-09  9:11   ` Nicholas Piggin
2024-02-09  9:11   ` Nicholas Piggin
2024-02-09 17:57   ` Thomas Huth
2024-02-09 17:57     ` Thomas Huth
2024-02-09 17:57     ` Thomas Huth
2024-02-09  9:11 ` [kvm-unit-tests PATCH v4 5/8] arch-run: rename migration variables Nicholas Piggin
2024-02-09  9:11   ` Nicholas Piggin
2024-02-09  9:11   ` Nicholas Piggin
2024-02-09  9:11 ` [kvm-unit-tests PATCH v4 6/8] migration: Add quiet migration support Nicholas Piggin
2024-02-09  9:11   ` Nicholas Piggin
2024-02-09  9:11   ` Nicholas Piggin
2024-02-09 18:09   ` Thomas Huth
2024-02-09 18:09     ` Thomas Huth
2024-02-09 18:09     ` Thomas Huth
2024-02-09  9:11 ` [kvm-unit-tests PATCH v4 7/8] Add common/ directory for architecture-independent tests Nicholas Piggin
2024-02-09  9:11   ` Nicholas Piggin
2024-02-09  9:11   ` Nicholas Piggin
2024-02-09  9:11 ` [kvm-unit-tests PATCH v4 8/8] migration: add a migration selftest Nicholas Piggin
2024-02-09  9:11   ` Nicholas Piggin
2024-02-09  9:11   ` Nicholas Piggin
2024-02-16 11:15   ` Thomas Huth
2024-02-16 11:15     ` Thomas Huth
2024-02-16 11:15     ` Thomas Huth
2024-02-17  7:19     ` Nicholas Piggin
2024-02-17  7:19       ` Nicholas Piggin
2024-02-17  7:19       ` Nicholas Piggin
2024-02-19  6:56       ` Thomas Huth
2024-02-19  6:56         ` Thomas Huth
2024-02-19  6:56         ` Thomas Huth
2024-02-19 12:02         ` Nicholas Piggin
2024-02-19 12:02           ` Nicholas Piggin
2024-02-19 12:02           ` Nicholas Piggin
2024-02-16 14:05   ` Thomas Huth
2024-02-16 14:05     ` Thomas Huth
2024-02-16 14:05     ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240209091134.600228-3-npiggin@gmail.com \
    --to=npiggin@gmail.com \
    --cc=kvm-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.