From: Simon Horman <horms@kernel.org>
To: Lukasz Plachno <lukasz.plachno@intel.com>
Cc: pmenzel@molgen.mpg.de, brett.creeley@amd.com,
netdev@vger.kernel.org,
Jakub Buchocki <jakubx.buchocki@intel.com>,
aleksander.lobakin@intel.com, intel-wired-lan@lists.osuosl.org,
Mateusz Pacuszka <mateuszx.pacuszka@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v6 2/2] ice: Implement 'flow-type ether' rules
Date: Fri, 9 Feb 2024 17:00:26 +0000 [thread overview]
Message-ID: <20240209170026.GB1533412@kernel.org> (raw)
In-Reply-To: <20240209101823.27922-3-lukasz.plachno@intel.com>
On Fri, Feb 09, 2024 at 11:18:23AM +0100, Lukasz Plachno wrote:
...
> diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.c b/drivers/net/ethernet/intel/ice/ice_fdir.c
> index 1f7b26f38818..ec8a84b80a73 100644
> --- a/drivers/net/ethernet/intel/ice/ice_fdir.c
> +++ b/drivers/net/ethernet/intel/ice/ice_fdir.c
> @@ -4,6 +4,8 @@
> #include "ice_common.h"
>
> /* These are training packet headers used to program flow director filters. */
> +static const u8 ice_fdir_eth_pkt[22] = {0};
> +
I think it was agreed to drop the "{0}" in the review of v5 as it is
unnecessary.
...
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Lukasz Plachno <lukasz.plachno@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
brett.creeley@amd.com, pmenzel@molgen.mpg.de,
aleksander.lobakin@intel.com,
Jakub Buchocki <jakubx.buchocki@intel.com>,
Mateusz Pacuszka <mateuszx.pacuszka@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH iwl-next v6 2/2] ice: Implement 'flow-type ether' rules
Date: Fri, 9 Feb 2024 17:00:26 +0000 [thread overview]
Message-ID: <20240209170026.GB1533412@kernel.org> (raw)
In-Reply-To: <20240209101823.27922-3-lukasz.plachno@intel.com>
On Fri, Feb 09, 2024 at 11:18:23AM +0100, Lukasz Plachno wrote:
...
> diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.c b/drivers/net/ethernet/intel/ice/ice_fdir.c
> index 1f7b26f38818..ec8a84b80a73 100644
> --- a/drivers/net/ethernet/intel/ice/ice_fdir.c
> +++ b/drivers/net/ethernet/intel/ice/ice_fdir.c
> @@ -4,6 +4,8 @@
> #include "ice_common.h"
>
> /* These are training packet headers used to program flow director filters. */
> +static const u8 ice_fdir_eth_pkt[22] = {0};
> +
I think it was agreed to drop the "{0}" in the review of v5 as it is
unnecessary.
...
next prev parent reply other threads:[~2024-02-09 17:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 10:18 [Intel-wired-lan] [PATCH iwl-next v6 0/2] ice: Support flow director ether type filters Lukasz Plachno
2024-02-09 10:18 ` Lukasz Plachno
2024-02-09 10:18 ` [Intel-wired-lan] [PATCH iwl-next v6 1/2] ice: Remove unnecessary argument from ice_fdir_comp_rules() Lukasz Plachno
2024-02-09 10:18 ` Lukasz Plachno
2024-02-09 10:18 ` [Intel-wired-lan] [PATCH iwl-next v6 2/2] ice: Implement 'flow-type ether' rules Lukasz Plachno
2024-02-09 10:18 ` Lukasz Plachno
2024-02-09 17:00 ` Simon Horman [this message]
2024-02-09 17:00 ` Simon Horman
2024-02-12 9:10 ` [Intel-wired-lan] " Plachno, Lukasz
2024-02-12 9:10 ` Plachno, Lukasz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240209170026.GB1533412@kernel.org \
--to=horms@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=brett.creeley@amd.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jakubx.buchocki@intel.com \
--cc=lukasz.plachno@intel.com \
--cc=mateuszx.pacuszka@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.