From: Simon Horman <horms@kernel.org>
To: Wojciech Drewek <wojciech.drewek@intel.com>
Cc: jiri@resnulli.us, netdev@vger.kernel.org, bcreeley@amd.com,
intel-wired-lan@lists.osuosl.org, paul.m.stillwell.jr@intel.com,
przemyslaw.kitszel@intel.com, vadim.fedorenko@linux.dev
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v5 2/2] ice: Fix debugfs with devlink reload
Date: Fri, 9 Feb 2024 17:25:39 +0000 [thread overview]
Message-ID: <20240209172539.GG1533412@kernel.org> (raw)
In-Reply-To: <20240205130357.106665-3-wojciech.drewek@intel.com>
On Mon, Feb 05, 2024 at 02:03:57PM +0100, Wojciech Drewek wrote:
> During devlink reload it is needed to remove debugfs entries
> correlated with only one PF. ice_debugfs_exit() removes all
> entries created by ice driver so we can't use it.
>
> Introduce ice_debugfs_pf_deinit() in order to release PF's
> debugfs entries. Move ice_debugfs_exit() call to ice_module_exit(),
> it makes more sense since ice_debugfs_init() is called in
> ice_module_init() and not in ice_probe().
>
> Signed-off-by: Wojciech Drewek <wojciech.drewek@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Wojciech Drewek <wojciech.drewek@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
jiri@resnulli.us, przemyslaw.kitszel@intel.com,
vadim.fedorenko@linux.dev, paul.m.stillwell.jr@intel.com,
bcreeley@amd.com
Subject: Re: [PATCH iwl-next v5 2/2] ice: Fix debugfs with devlink reload
Date: Fri, 9 Feb 2024 17:25:39 +0000 [thread overview]
Message-ID: <20240209172539.GG1533412@kernel.org> (raw)
In-Reply-To: <20240205130357.106665-3-wojciech.drewek@intel.com>
On Mon, Feb 05, 2024 at 02:03:57PM +0100, Wojciech Drewek wrote:
> During devlink reload it is needed to remove debugfs entries
> correlated with only one PF. ice_debugfs_exit() removes all
> entries created by ice driver so we can't use it.
>
> Introduce ice_debugfs_pf_deinit() in order to release PF's
> debugfs entries. Move ice_debugfs_exit() call to ice_module_exit(),
> it makes more sense since ice_debugfs_init() is called in
> ice_module_init() and not in ice_probe().
>
> Signed-off-by: Wojciech Drewek <wojciech.drewek@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-02-09 17:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 13:03 [Intel-wired-lan] [PATCH iwl-next v5 0/2] ice devlink reload refactor Wojciech Drewek
2024-02-05 13:03 ` Wojciech Drewek
2024-02-05 13:03 ` [Intel-wired-lan] [PATCH iwl-next v5 1/2] ice: Remove and readd netdev during devlink reload Wojciech Drewek
2024-02-05 13:03 ` Wojciech Drewek
2024-02-08 17:03 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-02-08 17:03 ` Pucha, HimasekharX Reddy
2024-02-05 13:03 ` [Intel-wired-lan] [PATCH iwl-next v5 2/2] ice: Fix debugfs with " Wojciech Drewek
2024-02-05 13:03 ` Wojciech Drewek
2024-02-08 17:06 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-02-08 17:06 ` Pucha, HimasekharX Reddy
2024-02-08 17:14 ` Brett Creeley
2024-02-08 17:14 ` Brett Creeley
2024-02-09 17:25 ` Simon Horman [this message]
2024-02-09 17:25 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240209172539.GG1533412@kernel.org \
--to=horms@kernel.org \
--cc=bcreeley@amd.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=paul.m.stillwell.jr@intel.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=vadim.fedorenko@linux.dev \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.