* [PATCH 1/4] rockchip: rk3328: Read cpuid and generate MAC address from efuse
2024-02-10 6:32 [PATCH 0/4] rockchip: Read cpuid and generate MAC address from efuse for RK3328 and RK3399 Chen-Yu Tsai
@ 2024-02-10 6:32 ` Chen-Yu Tsai
2024-02-10 6:32 ` [PATCH 2/4] rockchip: rk3399: " Chen-Yu Tsai
` (5 subsequent siblings)
6 siblings, 0 replies; 12+ messages in thread
From: Chen-Yu Tsai @ 2024-02-10 6:32 UTC (permalink / raw)
To: u-boot
Cc: Chen-Yu Tsai, Tom Rini, Simon Glass, Philipp Tomsich, Kever Yang,
Alper Nebi Yasak, Tianling Shen, David Bauer, Xiaobo Tian,
Peter Robinson, Quentin Schulz, Klaus Goger, Loic Devulder,
Jonas Karlman, Levin Du, Suniel Mahesh, FUKAUMI Naoki,
Christopher Obbard, Jagan Teki, Banglang Huang,
Matwey V. Kornilov, Manivannan Sadhasivam
From: Chen-Yu Tsai <wens@csie.org>
The rockchip-efuse driver supports the efuse found on RK3328. This
hardware block is part of the SoC and contains the CPUID, which can
be used to generate stable serial numbers and MAC addresses.
Enable the driver and reading cpuid by default for RK3328.
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
arch/arm/mach-rockchip/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
index 1bc7ee904275..20670fb57376 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip/Kconfig
@@ -189,6 +189,8 @@ config ROCKCHIP_RK3328
select ENABLE_ARM_SOC_BOOT0_HOOK
select DEBUG_UART_BOARD_INIT
select SYS_NS16550
+ imply ROCKCHIP_EFUSE
+ imply MISC_INIT_R
help
The Rockchip RK3328 is a ARM-based SoC with a quad-core Cortex-A53.
including NEON and GPU, 1MB L2 cache, Mali-T7 graphics, two
--
2.39.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/4] rockchip: rk3399: Read cpuid and generate MAC address from efuse
2024-02-10 6:32 [PATCH 0/4] rockchip: Read cpuid and generate MAC address from efuse for RK3328 and RK3399 Chen-Yu Tsai
2024-02-10 6:32 ` [PATCH 1/4] rockchip: rk3328: Read cpuid and generate MAC address from efuse Chen-Yu Tsai
@ 2024-02-10 6:32 ` Chen-Yu Tsai
2024-02-10 6:32 ` [PATCH 3/4] rockchip: rk3328: regenerate defconfigs Chen-Yu Tsai
` (4 subsequent siblings)
6 siblings, 0 replies; 12+ messages in thread
From: Chen-Yu Tsai @ 2024-02-10 6:32 UTC (permalink / raw)
To: u-boot
Cc: Chen-Yu Tsai, Tom Rini, Simon Glass, Philipp Tomsich, Kever Yang,
Alper Nebi Yasak, Tianling Shen, David Bauer, Xiaobo Tian,
Peter Robinson, Quentin Schulz, Klaus Goger, Loic Devulder,
Jonas Karlman, Levin Du, Suniel Mahesh, FUKAUMI Naoki,
Christopher Obbard, Jagan Teki, Banglang Huang,
Matwey V. Kornilov, Manivannan Sadhasivam
From: Chen-Yu Tsai <wens@csie.org>
The rockchip-efuse driver supports the efuse found on RK3399. This
hardware block is part of the SoC and contains the CPUID, which can
be used to generate stable serial numbers and MAC addresses.
Enable the driver and reading cpuid by default for RK3399.
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
arch/arm/mach-rockchip/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
index 20670fb57376..2558d956b8c6 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip/Kconfig
@@ -269,6 +269,8 @@ config ROCKCHIP_RK3399
imply SYS_BOOTCOUNT_SINGLEWORD if BOOTCOUNT_LIMIT
imply BOOTSTD_FULL
imply CMD_BOOTCOUNT if BOOTCOUNT_LIMIT
+ imply ROCKCHIP_EFUSE
+ imply MISC_INIT_R
help
The Rockchip RK3399 is a ARM-based SoC with a dual-core Cortex-A72
and quad-core Cortex-A53.
--
2.39.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 3/4] rockchip: rk3328: regenerate defconfigs
2024-02-10 6:32 [PATCH 0/4] rockchip: Read cpuid and generate MAC address from efuse for RK3328 and RK3399 Chen-Yu Tsai
2024-02-10 6:32 ` [PATCH 1/4] rockchip: rk3328: Read cpuid and generate MAC address from efuse Chen-Yu Tsai
2024-02-10 6:32 ` [PATCH 2/4] rockchip: rk3399: " Chen-Yu Tsai
@ 2024-02-10 6:32 ` Chen-Yu Tsai
2024-02-10 6:32 ` [PATCH 4/4] rockchip: rk3399: " Chen-Yu Tsai
` (3 subsequent siblings)
6 siblings, 0 replies; 12+ messages in thread
From: Chen-Yu Tsai @ 2024-02-10 6:32 UTC (permalink / raw)
To: u-boot
Cc: Chen-Yu Tsai, Tom Rini, Simon Glass, Philipp Tomsich, Kever Yang,
Alper Nebi Yasak, Tianling Shen, David Bauer, Xiaobo Tian,
Peter Robinson, Quentin Schulz, Klaus Goger, Loic Devulder,
Jonas Karlman, Levin Du, Suniel Mahesh, FUKAUMI Naoki,
Christopher Obbard, Jagan Teki, Banglang Huang,
Matwey V. Kornilov, Manivannan Sadhasivam
From: Chen-Yu Tsai <wens@csie.org>
Regenerate RK3328 defconfigs after adding imply statements.
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
configs/evb-rk3328_defconfig | 2 --
configs/nanopi-r2c-plus-rk3328_defconfig | 2 --
configs/nanopi-r2c-rk3328_defconfig | 2 --
configs/nanopi-r2s-rk3328_defconfig | 2 --
configs/orangepi-r1-plus-lts-rk3328_defconfig | 2 --
configs/orangepi-r1-plus-rk3328_defconfig | 2 --
configs/roc-cc-rk3328_defconfig | 2 --
configs/rock-pi-e-rk3328_defconfig | 2 --
configs/rock64-rk3328_defconfig | 2 --
9 files changed, 18 deletions(-)
diff --git a/configs/evb-rk3328_defconfig b/configs/evb-rk3328_defconfig
index 995bfd0558b1..004cbd33e80a 100644
--- a/configs/evb-rk3328_defconfig
+++ b/configs/evb-rk3328_defconfig
@@ -30,7 +30,6 @@ CONFIG_LEGACY_IMAGE_FORMAT=y
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3328-evb.dtb"
# CONFIG_DISPLAY_CPUINFO is not set
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x40000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
@@ -71,7 +70,6 @@ CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
CONFIG_ROCKCHIP_GPIO=y
CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_PHY_MOTORCOMM=y
diff --git a/configs/nanopi-r2c-plus-rk3328_defconfig b/configs/nanopi-r2c-plus-rk3328_defconfig
index 1cb0ed855398..2f0d253b4b7c 100644
--- a/configs/nanopi-r2c-plus-rk3328_defconfig
+++ b/configs/nanopi-r2c-plus-rk3328_defconfig
@@ -31,7 +31,6 @@ CONFIG_LEGACY_IMAGE_FORMAT=y
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3328-nanopi-r2c-plus.dtb"
# CONFIG_DISPLAY_CPUINFO is not set
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x40000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
@@ -73,7 +72,6 @@ CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
CONFIG_ROCKCHIP_GPIO=y
CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_PHY_MOTORCOMM=y
diff --git a/configs/nanopi-r2c-rk3328_defconfig b/configs/nanopi-r2c-rk3328_defconfig
index 59801328deda..ca13eb873a72 100644
--- a/configs/nanopi-r2c-rk3328_defconfig
+++ b/configs/nanopi-r2c-rk3328_defconfig
@@ -31,7 +31,6 @@ CONFIG_LEGACY_IMAGE_FORMAT=y
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3328-nanopi-r2c.dtb"
# CONFIG_DISPLAY_CPUINFO is not set
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x40000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
@@ -73,7 +72,6 @@ CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
CONFIG_ROCKCHIP_GPIO=y
CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_PHY_MOTORCOMM=y
diff --git a/configs/nanopi-r2s-rk3328_defconfig b/configs/nanopi-r2s-rk3328_defconfig
index 61914b1650d2..619707436130 100644
--- a/configs/nanopi-r2s-rk3328_defconfig
+++ b/configs/nanopi-r2s-rk3328_defconfig
@@ -31,7 +31,6 @@ CONFIG_LEGACY_IMAGE_FORMAT=y
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3328-nanopi-r2s.dtb"
# CONFIG_DISPLAY_CPUINFO is not set
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x40000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
@@ -73,7 +72,6 @@ CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
CONFIG_ROCKCHIP_GPIO=y
CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_PHY_MOTORCOMM=y
diff --git a/configs/orangepi-r1-plus-lts-rk3328_defconfig b/configs/orangepi-r1-plus-lts-rk3328_defconfig
index 968110c8cd6f..8e9a9411a763 100644
--- a/configs/orangepi-r1-plus-lts-rk3328_defconfig
+++ b/configs/orangepi-r1-plus-lts-rk3328_defconfig
@@ -34,7 +34,6 @@ CONFIG_LEGACY_IMAGE_FORMAT=y
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3328-orangepi-r1-plus-lts.dtb"
# CONFIG_DISPLAY_CPUINFO is not set
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x40000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
@@ -78,7 +77,6 @@ CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
CONFIG_ROCKCHIP_GPIO=y
CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_SPI_FLASH_SFDP_SUPPORT=y
diff --git a/configs/orangepi-r1-plus-rk3328_defconfig b/configs/orangepi-r1-plus-rk3328_defconfig
index 7038f09f202c..240fcdeb221f 100644
--- a/configs/orangepi-r1-plus-rk3328_defconfig
+++ b/configs/orangepi-r1-plus-rk3328_defconfig
@@ -34,7 +34,6 @@ CONFIG_LEGACY_IMAGE_FORMAT=y
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3328-orangepi-r1-plus.dtb"
# CONFIG_DISPLAY_CPUINFO is not set
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x40000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
@@ -78,7 +77,6 @@ CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
CONFIG_ROCKCHIP_GPIO=y
CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_SPI_FLASH_SFDP_SUPPORT=y
diff --git a/configs/roc-cc-rk3328_defconfig b/configs/roc-cc-rk3328_defconfig
index 7d81a715ef25..f734116f847e 100644
--- a/configs/roc-cc-rk3328_defconfig
+++ b/configs/roc-cc-rk3328_defconfig
@@ -31,7 +31,6 @@ CONFIG_LEGACY_IMAGE_FORMAT=y
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3328-roc-cc.dtb"
# CONFIG_DISPLAY_CPUINFO is not set
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x40000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
@@ -74,7 +73,6 @@ CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
CONFIG_ROCKCHIP_GPIO=y
CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_PHY_REALTEK=y
diff --git a/configs/rock-pi-e-rk3328_defconfig b/configs/rock-pi-e-rk3328_defconfig
index ddd482dd0195..5ccdc02d4c86 100644
--- a/configs/rock-pi-e-rk3328_defconfig
+++ b/configs/rock-pi-e-rk3328_defconfig
@@ -32,7 +32,6 @@ CONFIG_LEGACY_IMAGE_FORMAT=y
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3328-rock-pi-e.dtb"
# CONFIG_DISPLAY_CPUINFO is not set
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x40000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
@@ -74,7 +73,6 @@ CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
CONFIG_ROCKCHIP_GPIO=y
CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_PHY_REALTEK=y
diff --git a/configs/rock64-rk3328_defconfig b/configs/rock64-rk3328_defconfig
index 01e447448513..81284c6697a5 100644
--- a/configs/rock64-rk3328_defconfig
+++ b/configs/rock64-rk3328_defconfig
@@ -34,7 +34,6 @@ CONFIG_LEGACY_IMAGE_FORMAT=y
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3328-rock64.dtb"
# CONFIG_DISPLAY_CPUINFO is not set
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x40000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
@@ -78,7 +77,6 @@ CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
CONFIG_ROCKCHIP_GPIO=y
CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_SPI_FLASH_SFDP_SUPPORT=y
--
2.39.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 4/4] rockchip: rk3399: regenerate defconfigs
2024-02-10 6:32 [PATCH 0/4] rockchip: Read cpuid and generate MAC address from efuse for RK3328 and RK3399 Chen-Yu Tsai
` (2 preceding siblings ...)
2024-02-10 6:32 ` [PATCH 3/4] rockchip: rk3328: regenerate defconfigs Chen-Yu Tsai
@ 2024-02-10 6:32 ` Chen-Yu Tsai
2024-02-10 19:18 ` Jonas Karlman
2024-02-12 9:38 ` Quentin Schulz
2024-02-10 9:06 ` [PATCH 0/4] rockchip: Read cpuid and generate MAC address from efuse for RK3328 and RK3399 Christopher Obbard
` (2 subsequent siblings)
6 siblings, 2 replies; 12+ messages in thread
From: Chen-Yu Tsai @ 2024-02-10 6:32 UTC (permalink / raw)
To: u-boot
Cc: Chen-Yu Tsai, Tom Rini, Simon Glass, Philipp Tomsich, Kever Yang,
Alper Nebi Yasak, Tianling Shen, David Bauer, Xiaobo Tian,
Peter Robinson, Quentin Schulz, Klaus Goger, Loic Devulder,
Jonas Karlman, Levin Du, Suniel Mahesh, FUKAUMI Naoki,
Christopher Obbard, Jagan Teki, Banglang Huang,
Matwey V. Kornilov, Manivannan Sadhasivam
From: Chen-Yu Tsai <wens@csie.org>
Regenerate RK3399 defconfigs after adding imply statements.
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
configs/chromebook_bob_defconfig | 2 --
configs/chromebook_kevin_defconfig | 2 --
configs/firefly-rk3399_defconfig | 2 --
configs/nanopi-r4s-rk3399_defconfig | 2 --
configs/pinebook-pro-rk3399_defconfig | 2 --
configs/pinephone-pro-rk3399_defconfig | 2 --
configs/puma-rk3399_defconfig | 2 --
configs/roc-pc-mezzanine-rk3399_defconfig | 2 --
configs/roc-pc-rk3399_defconfig | 2 --
configs/rock-4c-plus-rk3399_defconfig | 3 ---
configs/rock-4se-rk3399_defconfig | 3 ---
configs/rock-pi-4-rk3399_defconfig | 3 ---
configs/rock-pi-4c-rk3399_defconfig | 3 ---
configs/rock-pi-n10-rk3399pro_defconfig | 1 -
configs/rock960-rk3399_defconfig | 1 -
configs/rockpro64-rk3399_defconfig | 2 --
16 files changed, 34 deletions(-)
diff --git a/configs/chromebook_bob_defconfig b/configs/chromebook_bob_defconfig
index b5a5ae737e52..bffa0d33b75c 100644
--- a/configs/chromebook_bob_defconfig
+++ b/configs/chromebook_bob_defconfig
@@ -27,7 +27,6 @@ CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-gru-bob.dtb"
# CONFIG_DISPLAY_CPUINFO is not set
CONFIG_DISPLAY_BOARDINFO_LATE=y
CONFIG_BOARD_EARLY_INIT_R=y
-CONFIG_MISC_INIT_R=y
CONFIG_BLOBLIST=y
CONFIG_BLOBLIST_ADDR=0x100000
CONFIG_BLOBLIST_SIZE=0x1000
@@ -68,7 +67,6 @@ CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_I2C_MUX=y
CONFIG_CROS_EC_KEYB=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_CROS_EC=y
CONFIG_CROS_EC_SPI=y
CONFIG_PWRSEQ=y
diff --git a/configs/chromebook_kevin_defconfig b/configs/chromebook_kevin_defconfig
index 20913d2cf0fe..e14fc358c504 100644
--- a/configs/chromebook_kevin_defconfig
+++ b/configs/chromebook_kevin_defconfig
@@ -28,7 +28,6 @@ CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-gru-kevin.dtb"
# CONFIG_DISPLAY_CPUINFO is not set
CONFIG_DISPLAY_BOARDINFO_LATE=y
CONFIG_BOARD_EARLY_INIT_R=y
-CONFIG_MISC_INIT_R=y
CONFIG_BLOBLIST=y
CONFIG_BLOBLIST_ADDR=0x100000
CONFIG_BLOBLIST_SIZE=0x1000
@@ -69,7 +68,6 @@ CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_I2C_MUX=y
CONFIG_CROS_EC_KEYB=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_CROS_EC=y
CONFIG_CROS_EC_SPI=y
CONFIG_PWRSEQ=y
diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig
index b7c8e95b7b89..b01b1a327896 100644
--- a/configs/firefly-rk3399_defconfig
+++ b/configs/firefly-rk3399_defconfig
@@ -20,7 +20,6 @@ CONFIG_PCI=y
CONFIG_DEBUG_UART=y
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-firefly.dtb"
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x2e000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
@@ -46,7 +45,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
CONFIG_ROCKCHIP_GPIO=y
CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_MMC_SDHCI=y
diff --git a/configs/nanopi-r4s-rk3399_defconfig b/configs/nanopi-r4s-rk3399_defconfig
index cacaab14d21f..18a1e68aa049 100644
--- a/configs/nanopi-r4s-rk3399_defconfig
+++ b/configs/nanopi-r4s-rk3399_defconfig
@@ -17,7 +17,6 @@ CONFIG_SYS_LOAD_ADDR=0x800800
CONFIG_DEBUG_UART=y
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-nanopi-r4s.dtb"
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x2e000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
@@ -42,7 +41,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
CONFIG_ROCKCHIP_GPIO=y
CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_ROCKCHIP_OTP=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
diff --git a/configs/pinebook-pro-rk3399_defconfig b/configs/pinebook-pro-rk3399_defconfig
index de357415fbe4..6b83daf07945 100644
--- a/configs/pinebook-pro-rk3399_defconfig
+++ b/configs/pinebook-pro-rk3399_defconfig
@@ -26,7 +26,6 @@ CONFIG_BOOTDELAY=3
CONFIG_USE_PREBOOT=y
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-pinebook-pro.dtb"
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x40000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
@@ -61,7 +60,6 @@ CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_LED=y
CONFIG_LED_GPIO=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_MMC_IO_VOLTAGE=y
CONFIG_SPL_MMC_IO_VOLTAGE=y
CONFIG_MMC_UHS_SUPPORT=y
diff --git a/configs/pinephone-pro-rk3399_defconfig b/configs/pinephone-pro-rk3399_defconfig
index d08224fe536b..96316c4b303f 100644
--- a/configs/pinephone-pro-rk3399_defconfig
+++ b/configs/pinephone-pro-rk3399_defconfig
@@ -25,7 +25,6 @@ CONFIG_BOOTDELAY=3
CONFIG_USE_PREBOOT=y
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-pinephone-pro.dtb"
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x40000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
@@ -60,7 +59,6 @@ CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_LED=y
CONFIG_LED_GPIO=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_MMC_SDHCI=y
diff --git a/configs/puma-rk3399_defconfig b/configs/puma-rk3399_defconfig
index c2aa02ec74bd..f39d352c7890 100644
--- a/configs/puma-rk3399_defconfig
+++ b/configs/puma-rk3399_defconfig
@@ -25,7 +25,6 @@ CONFIG_SYS_LOAD_ADDR=0x800800
CONFIG_DEBUG_UART=y
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-puma-haikou.dtb"
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x2e000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
@@ -68,7 +67,6 @@ CONFIG_SPL_GPIO_HOG=y
CONFIG_ROCKCHIP_GPIO=y
CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_MMC_SDHCI=y
diff --git a/configs/roc-pc-mezzanine-rk3399_defconfig b/configs/roc-pc-mezzanine-rk3399_defconfig
index de6539bedf48..64103eada8cf 100644
--- a/configs/roc-pc-mezzanine-rk3399_defconfig
+++ b/configs/roc-pc-mezzanine-rk3399_defconfig
@@ -26,7 +26,6 @@ CONFIG_DEBUG_UART=y
# CONFIG_ANDROID_BOOT_IMAGE is not set
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-roc-pc-mezzanine.dtb"
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x40000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
@@ -56,7 +55,6 @@ CONFIG_SPL_DM_SEQ_ALIAS=y
CONFIG_ROCKCHIP_GPIO=y
CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_MMC_SDHCI=y
diff --git a/configs/roc-pc-rk3399_defconfig b/configs/roc-pc-rk3399_defconfig
index 7123a7a07299..61991e8868b3 100644
--- a/configs/roc-pc-rk3399_defconfig
+++ b/configs/roc-pc-rk3399_defconfig
@@ -27,7 +27,6 @@ CONFIG_DEBUG_UART=y
CONFIG_USE_PREBOOT=y
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-roc-pc.dtb"
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x40000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
@@ -56,7 +55,6 @@ CONFIG_SPL_DM_SEQ_ALIAS=y
CONFIG_ROCKCHIP_GPIO=y
CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_MMC_SDHCI=y
diff --git a/configs/rock-4c-plus-rk3399_defconfig b/configs/rock-4c-plus-rk3399_defconfig
index 18525c8bf504..12587b1eba10 100644
--- a/configs/rock-4c-plus-rk3399_defconfig
+++ b/configs/rock-4c-plus-rk3399_defconfig
@@ -8,7 +8,6 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x300000
CONFIG_ENV_OFFSET=0x3F8000
CONFIG_DEFAULT_DEVICE_TREE="rk3399-rock-4c-plus"
-CONFIG_OF_LIBFDT_OVERLAY=y
CONFIG_DM_RESET=y
CONFIG_ROCKCHIP_RK3399=y
CONFIG_TARGET_EVB_RK3399=y
@@ -21,7 +20,6 @@ CONFIG_DEBUG_UART=y
# CONFIG_ANDROID_BOOT_IMAGE is not set
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-rock-4c-plus.dtb"
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x2e000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
@@ -53,7 +51,6 @@ CONFIG_DFU_MMC=y
CONFIG_ROCKCHIP_GPIO=y
CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_MMC_SDHCI=y
diff --git a/configs/rock-4se-rk3399_defconfig b/configs/rock-4se-rk3399_defconfig
index 171de23ec8f6..16a58a10d7e3 100644
--- a/configs/rock-4se-rk3399_defconfig
+++ b/configs/rock-4se-rk3399_defconfig
@@ -8,7 +8,6 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x300000
CONFIG_ENV_OFFSET=0x3F8000
CONFIG_DEFAULT_DEVICE_TREE="rk3399-rock-4se"
-CONFIG_OF_LIBFDT_OVERLAY=y
CONFIG_DM_RESET=y
CONFIG_ROCKCHIP_RK3399=y
CONFIG_TARGET_EVB_RK3399=y
@@ -23,7 +22,6 @@ CONFIG_SPL_FIT_SIGNATURE=y
CONFIG_LEGACY_IMAGE_FORMAT=y
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-rock-4se.dtb"
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x2e000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
@@ -54,7 +52,6 @@ CONFIG_DFU_MMC=y
CONFIG_ROCKCHIP_GPIO=y
CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_MMC_SDHCI=y
diff --git a/configs/rock-pi-4-rk3399_defconfig b/configs/rock-pi-4-rk3399_defconfig
index 83fc4ad7dabc..fe3705e3672c 100644
--- a/configs/rock-pi-4-rk3399_defconfig
+++ b/configs/rock-pi-4-rk3399_defconfig
@@ -8,7 +8,6 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x300000
CONFIG_ENV_OFFSET=0x3F8000
CONFIG_DEFAULT_DEVICE_TREE="rk3399-rock-pi-4a"
-CONFIG_OF_LIBFDT_OVERLAY=y
CONFIG_DM_RESET=y
CONFIG_ROCKCHIP_RK3399=y
CONFIG_TARGET_EVB_RK3399=y
@@ -23,7 +22,6 @@ CONFIG_SPL_FIT_SIGNATURE=y
CONFIG_LEGACY_IMAGE_FORMAT=y
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-rock-pi-4a.dtb"
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x2e000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
@@ -55,7 +53,6 @@ CONFIG_DFU_MMC=y
CONFIG_ROCKCHIP_GPIO=y
CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_MMC_SDHCI=y
diff --git a/configs/rock-pi-4c-rk3399_defconfig b/configs/rock-pi-4c-rk3399_defconfig
index 089344097e0c..f37a09710b9e 100644
--- a/configs/rock-pi-4c-rk3399_defconfig
+++ b/configs/rock-pi-4c-rk3399_defconfig
@@ -8,7 +8,6 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x300000
CONFIG_ENV_OFFSET=0x3F8000
CONFIG_DEFAULT_DEVICE_TREE="rk3399-rock-pi-4c"
-CONFIG_OF_LIBFDT_OVERLAY=y
CONFIG_DM_RESET=y
CONFIG_ROCKCHIP_RK3399=y
CONFIG_TARGET_EVB_RK3399=y
@@ -21,7 +20,6 @@ CONFIG_DEBUG_UART=y
# CONFIG_ANDROID_BOOT_IMAGE is not set
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-rock-pi-4c.dtb"
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x2e000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
@@ -53,7 +51,6 @@ CONFIG_DFU_MMC=y
CONFIG_ROCKCHIP_GPIO=y
CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_MMC_SDHCI=y
diff --git a/configs/rock-pi-n10-rk3399pro_defconfig b/configs/rock-pi-n10-rk3399pro_defconfig
index dc4b3b40380a..9a8beaa81ddf 100644
--- a/configs/rock-pi-n10-rk3399pro_defconfig
+++ b/configs/rock-pi-n10-rk3399pro_defconfig
@@ -22,7 +22,6 @@ CONFIG_DEBUG_UART=y
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399pro-rock-pi-n10.dtb"
# CONFIG_CONSOLE_MUX is not set
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x2e000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
diff --git a/configs/rock960-rk3399_defconfig b/configs/rock960-rk3399_defconfig
index b93dda56593b..80b41b061bdb 100644
--- a/configs/rock960-rk3399_defconfig
+++ b/configs/rock960-rk3399_defconfig
@@ -20,7 +20,6 @@ CONFIG_USE_PREBOOT=y
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-rock960.dtb"
CONFIG_SYS_PBSIZE=1052
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x2e000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig
index 711541f84627..c37d858c2c66 100644
--- a/configs/rockpro64-rk3399_defconfig
+++ b/configs/rockpro64-rk3399_defconfig
@@ -28,7 +28,6 @@ CONFIG_BOOTSTAGE_REPORT=y
CONFIG_USE_PREBOOT=y
CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-rockpro64.dtb"
CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_MISC_INIT_R=y
CONFIG_SPL_MAX_SIZE=0x40000
CONFIG_SPL_PAD_TO=0x7f8000
CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
@@ -64,7 +63,6 @@ CONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_LED=y
CONFIG_LED_GPIO=y
CONFIG_MISC=y
-CONFIG_ROCKCHIP_EFUSE=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_MMC_SDHCI=y
--
2.39.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 4/4] rockchip: rk3399: regenerate defconfigs
2024-02-10 6:32 ` [PATCH 4/4] rockchip: rk3399: " Chen-Yu Tsai
@ 2024-02-10 19:18 ` Jonas Karlman
2024-02-11 1:18 ` Chen-Yu Tsai
2024-02-12 9:38 ` Quentin Schulz
1 sibling, 1 reply; 12+ messages in thread
From: Jonas Karlman @ 2024-02-10 19:18 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Chen-Yu Tsai, Tom Rini, Simon Glass, Philipp Tomsich, Kever Yang,
Alper Nebi Yasak, Tianling Shen, David Bauer, Xiaobo Tian,
Peter Robinson, Quentin Schulz, Klaus Goger, Loic Devulder,
Levin Du, Suniel Mahesh, FUKAUMI Naoki, Christopher Obbard,
Jagan Teki, Banglang Huang, Matwey V. Kornilov,
Manivannan Sadhasivam, u-boot
Hi Chen-Yu,
On 2024-02-10 07:32, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <wens@csie.org>
>
> Regenerate RK3399 defconfigs after adding imply statements.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
> configs/chromebook_bob_defconfig | 2 --
> configs/chromebook_kevin_defconfig | 2 --
> configs/firefly-rk3399_defconfig | 2 --
> configs/nanopi-r4s-rk3399_defconfig | 2 --
> configs/pinebook-pro-rk3399_defconfig | 2 --
> configs/pinephone-pro-rk3399_defconfig | 2 --
> configs/puma-rk3399_defconfig | 2 --
> configs/roc-pc-mezzanine-rk3399_defconfig | 2 --
> configs/roc-pc-rk3399_defconfig | 2 --
> configs/rock-4c-plus-rk3399_defconfig | 3 ---
> configs/rock-4se-rk3399_defconfig | 3 ---
> configs/rock-pi-4-rk3399_defconfig | 3 ---
> configs/rock-pi-4c-rk3399_defconfig | 3 ---
> configs/rock-pi-n10-rk3399pro_defconfig | 1 -
> configs/rock960-rk3399_defconfig | 1 -
> configs/rockpro64-rk3399_defconfig | 2 --
> 16 files changed, 34 deletions(-)
>
[snip]
> diff --git a/configs/rock-4c-plus-rk3399_defconfig b/configs/rock-4c-plus-rk3399_defconfig
> index 18525c8bf504..12587b1eba10 100644
> --- a/configs/rock-4c-plus-rk3399_defconfig
> +++ b/configs/rock-4c-plus-rk3399_defconfig
> @@ -8,7 +8,6 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
> CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x300000
> CONFIG_ENV_OFFSET=0x3F8000
> CONFIG_DEFAULT_DEVICE_TREE="rk3399-rock-4c-plus"
> -CONFIG_OF_LIBFDT_OVERLAY=y
This patch seems to also remove a few OF_LIBFDT_OVERLAY, guessing this
was unintentional?
If you are re-spinning this series, please also include change to:
- add CONFIG_MISC=y to ficus-rk3399_defconfig, its required for efuse
- drop CONFIG_ROCKCHIP_OTP=y from nanopi-r4s-rk3399_defconfig, soc have
efuse or otp and on rk3399 it is efuse
And possible also drop CONFIG_NET_RANDOM_ETHADDR=y from:
- evb-rk3399_defconfig
- ficus-rk3399_defconfig
- khadas-edge-captain-rk3399_defconfig
- khadas-edge-v-rk3399_defconfig
now that these boards will have proper ethaddr.
Regards,
Jonas
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 4/4] rockchip: rk3399: regenerate defconfigs
2024-02-10 19:18 ` Jonas Karlman
@ 2024-02-11 1:18 ` Chen-Yu Tsai
0 siblings, 0 replies; 12+ messages in thread
From: Chen-Yu Tsai @ 2024-02-11 1:18 UTC (permalink / raw)
To: Jonas Karlman
Cc: Tom Rini, Simon Glass, Philipp Tomsich, Kever Yang,
Alper Nebi Yasak, Tianling Shen, David Bauer, Xiaobo Tian,
Peter Robinson, Quentin Schulz, Klaus Goger, Loic Devulder,
Levin Du, Suniel Mahesh, FUKAUMI Naoki, Christopher Obbard,
Jagan Teki, Banglang Huang, Matwey V. Kornilov,
Manivannan Sadhasivam, u-boot
On Sun, Feb 11, 2024 at 3:49 AM Jonas Karlman <jonas@kwiboo.se> wrote:
>
> Hi Chen-Yu,
>
> On 2024-02-10 07:32, Chen-Yu Tsai wrote:
> > From: Chen-Yu Tsai <wens@csie.org>
> >
> > Regenerate RK3399 defconfigs after adding imply statements.
> >
> > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> > ---
> > configs/chromebook_bob_defconfig | 2 --
> > configs/chromebook_kevin_defconfig | 2 --
> > configs/firefly-rk3399_defconfig | 2 --
> > configs/nanopi-r4s-rk3399_defconfig | 2 --
> > configs/pinebook-pro-rk3399_defconfig | 2 --
> > configs/pinephone-pro-rk3399_defconfig | 2 --
> > configs/puma-rk3399_defconfig | 2 --
> > configs/roc-pc-mezzanine-rk3399_defconfig | 2 --
> > configs/roc-pc-rk3399_defconfig | 2 --
> > configs/rock-4c-plus-rk3399_defconfig | 3 ---
> > configs/rock-4se-rk3399_defconfig | 3 ---
> > configs/rock-pi-4-rk3399_defconfig | 3 ---
> > configs/rock-pi-4c-rk3399_defconfig | 3 ---
> > configs/rock-pi-n10-rk3399pro_defconfig | 1 -
> > configs/rock960-rk3399_defconfig | 1 -
> > configs/rockpro64-rk3399_defconfig | 2 --
> > 16 files changed, 34 deletions(-)
> >
>
> [snip]
>
> > diff --git a/configs/rock-4c-plus-rk3399_defconfig b/configs/rock-4c-plus-rk3399_defconfig
> > index 18525c8bf504..12587b1eba10 100644
> > --- a/configs/rock-4c-plus-rk3399_defconfig
> > +++ b/configs/rock-4c-plus-rk3399_defconfig
> > @@ -8,7 +8,6 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
> > CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x300000
> > CONFIG_ENV_OFFSET=0x3F8000
> > CONFIG_DEFAULT_DEVICE_TREE="rk3399-rock-4c-plus"
> > -CONFIG_OF_LIBFDT_OVERLAY=y
>
> This patch seems to also remove a few OF_LIBFDT_OVERLAY, guessing this
> was unintentional?
Yeah, that was unintentional. I have a local patch that enables
OF_LIBFDT_OVERLAY for ARCH_ROCKCHIP by default.
> If you are re-spinning this series, please also include change to:
> - add CONFIG_MISC=y to ficus-rk3399_defconfig, its required for efuse
I suppose we should just also imply CONFIG_MISC.
> - drop CONFIG_ROCKCHIP_OTP=y from nanopi-r4s-rk3399_defconfig, soc have
> efuse or otp and on rk3399 it is efuse
Will add a cleanup.
> And possible also drop CONFIG_NET_RANDOM_ETHADDR=y from:
> - evb-rk3399_defconfig
> - ficus-rk3399_defconfig
> - khadas-edge-captain-rk3399_defconfig
> - khadas-edge-v-rk3399_defconfig
> now that these boards will have proper ethaddr.
Will add a separate cleanup.
ChenYu
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 4/4] rockchip: rk3399: regenerate defconfigs
2024-02-10 6:32 ` [PATCH 4/4] rockchip: rk3399: " Chen-Yu Tsai
2024-02-10 19:18 ` Jonas Karlman
@ 2024-02-12 9:38 ` Quentin Schulz
1 sibling, 0 replies; 12+ messages in thread
From: Quentin Schulz @ 2024-02-12 9:38 UTC (permalink / raw)
To: Chen-Yu Tsai, u-boot
Cc: Chen-Yu Tsai, Tom Rini, Simon Glass, Philipp Tomsich, Kever Yang,
Alper Nebi Yasak, Tianling Shen, David Bauer, Xiaobo Tian,
Peter Robinson, Klaus Goger, Loic Devulder, Jonas Karlman,
Levin Du, Suniel Mahesh, FUKAUMI Naoki, Christopher Obbard,
Jagan Teki, Banglang Huang, Matwey V. Kornilov,
Manivannan Sadhasivam
Hi Chen-Yu,
On 2/10/24 07:32, Chen-Yu Tsai wrote:
> [Some people who received this message don't often get email from wens@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> From: Chen-Yu Tsai <wens@csie.org>
>
> Regenerate RK3399 defconfigs after adding imply statements.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
> configs/chromebook_bob_defconfig | 2 --
> configs/chromebook_kevin_defconfig | 2 --
> configs/firefly-rk3399_defconfig | 2 --
> configs/nanopi-r4s-rk3399_defconfig | 2 --
> configs/pinebook-pro-rk3399_defconfig | 2 --
> configs/pinephone-pro-rk3399_defconfig | 2 --
> configs/puma-rk3399_defconfig | 2 --
Reviewed-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Thanks,
Quentin
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/4] rockchip: Read cpuid and generate MAC address from efuse for RK3328 and RK3399
2024-02-10 6:32 [PATCH 0/4] rockchip: Read cpuid and generate MAC address from efuse for RK3328 and RK3399 Chen-Yu Tsai
` (3 preceding siblings ...)
2024-02-10 6:32 ` [PATCH 4/4] rockchip: rk3399: " Chen-Yu Tsai
@ 2024-02-10 9:06 ` Christopher Obbard
2024-02-10 16:37 ` Dragan Simic
2024-02-12 13:57 ` Peter Robinson
6 siblings, 0 replies; 12+ messages in thread
From: Christopher Obbard @ 2024-02-10 9:06 UTC (permalink / raw)
To: Chen-Yu Tsai, u-boot
Cc: Chen-Yu Tsai, Tom Rini, Simon Glass, Philipp Tomsich, Kever Yang,
Alper Nebi Yasak, Tianling Shen, David Bauer, Xiaobo Tian,
Peter Robinson, Quentin Schulz, Klaus Goger, Loic Devulder,
Jonas Karlman, Levin Du, Suniel Mahesh, FUKAUMI Naoki, Jagan Teki,
Banglang Huang, Matwey V. Kornilov, Manivannan Sadhasivam
Hi Chen-Yu,
For the entire series:
Reviewed-by: Christopher Obbard <chris.obbard@collabora.com>
On 10 February 2024 06:32:46 GMT, Chen-Yu Tsai <wens@kernel.org> wrote:
>From: Chen-Yu Tsai <wens@csie.org>
>
>Hi folks,
>
>This series enables ROCKCHIP_EFUSE and MISC_INIT_R by default for RK3328
>and RK3399 so that the cpuid is read from the efuse and used to generate
>a serial number and MAC addresses for all boards.
>
>This stacks on top of the recent defconfig update series [1] from Jonas.
>
>[1] https://lore.kernel.org/u-boot/20240207000301.3270722-1-jonas@kwiboo.se/
>
>
>Chen-Yu Tsai (4):
> rockchip: rk3328: Read cpuid and generate MAC address from efuse
> rockchip: rk3399: Read cpuid and generate MAC address from efuse
> rockchip: rk3328: regenerate defconfigs
> rockchip: rk3399: regenerate defconfigs
>
> arch/arm/mach-rockchip/Kconfig | 4 ++++
> configs/chromebook_bob_defconfig | 2 --
> configs/chromebook_kevin_defconfig | 2 --
> configs/evb-rk3328_defconfig | 2 --
> configs/firefly-rk3399_defconfig | 2 --
> configs/nanopi-r2c-plus-rk3328_defconfig | 2 --
> configs/nanopi-r2c-rk3328_defconfig | 2 --
> configs/nanopi-r2s-rk3328_defconfig | 2 --
> configs/nanopi-r4s-rk3399_defconfig | 2 --
> configs/orangepi-r1-plus-lts-rk3328_defconfig | 2 --
> configs/orangepi-r1-plus-rk3328_defconfig | 2 --
> configs/pinebook-pro-rk3399_defconfig | 2 --
> configs/pinephone-pro-rk3399_defconfig | 2 --
> configs/puma-rk3399_defconfig | 2 --
> configs/roc-cc-rk3328_defconfig | 2 --
> configs/roc-pc-mezzanine-rk3399_defconfig | 2 --
> configs/roc-pc-rk3399_defconfig | 2 --
> configs/rock-4c-plus-rk3399_defconfig | 3 ---
> configs/rock-4se-rk3399_defconfig | 3 ---
> configs/rock-pi-4-rk3399_defconfig | 3 ---
> configs/rock-pi-4c-rk3399_defconfig | 3 ---
> configs/rock-pi-e-rk3328_defconfig | 2 --
> configs/rock-pi-n10-rk3399pro_defconfig | 1 -
> configs/rock64-rk3328_defconfig | 2 --
> configs/rock960-rk3399_defconfig | 1 -
> configs/rockpro64-rk3399_defconfig | 2 --
> 26 files changed, 4 insertions(+), 52 deletions(-)
>
>--
>2.39.2
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/4] rockchip: Read cpuid and generate MAC address from efuse for RK3328 and RK3399
2024-02-10 6:32 [PATCH 0/4] rockchip: Read cpuid and generate MAC address from efuse for RK3328 and RK3399 Chen-Yu Tsai
` (4 preceding siblings ...)
2024-02-10 9:06 ` [PATCH 0/4] rockchip: Read cpuid and generate MAC address from efuse for RK3328 and RK3399 Christopher Obbard
@ 2024-02-10 16:37 ` Dragan Simic
2024-02-12 13:57 ` Peter Robinson
6 siblings, 0 replies; 12+ messages in thread
From: Dragan Simic @ 2024-02-10 16:37 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: u-boot, Chen-Yu Tsai, Tom Rini, Simon Glass, Philipp Tomsich,
Kever Yang, Alper Nebi Yasak, Tianling Shen, David Bauer,
Xiaobo Tian, Peter Robinson, Quentin Schulz, Klaus Goger,
Loic Devulder, Jonas Karlman, Levin Du, Suniel Mahesh,
FUKAUMI Naoki, Christopher Obbard, Jagan Teki, Banglang Huang,
Matwey V. Kornilov, Manivannan Sadhasivam
On 2024-02-10 07:32, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <wens@csie.org>
>
> This series enables ROCKCHIP_EFUSE and MISC_INIT_R by default for
> RK3328
> and RK3399 so that the cpuid is read from the efuse and used to
> generate
> a serial number and MAC addresses for all boards.
>
> This stacks on top of the recent defconfig update series [1] from
> Jonas.
The entire series is looking good to me!
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
> [1]
> https://lore.kernel.org/u-boot/20240207000301.3270722-1-jonas@kwiboo.se/
>
> Chen-Yu Tsai (4):
> rockchip: rk3328: Read cpuid and generate MAC address from efuse
> rockchip: rk3399: Read cpuid and generate MAC address from efuse
> rockchip: rk3328: regenerate defconfigs
> rockchip: rk3399: regenerate defconfigs
>
> arch/arm/mach-rockchip/Kconfig | 4 ++++
> configs/chromebook_bob_defconfig | 2 --
> configs/chromebook_kevin_defconfig | 2 --
> configs/evb-rk3328_defconfig | 2 --
> configs/firefly-rk3399_defconfig | 2 --
> configs/nanopi-r2c-plus-rk3328_defconfig | 2 --
> configs/nanopi-r2c-rk3328_defconfig | 2 --
> configs/nanopi-r2s-rk3328_defconfig | 2 --
> configs/nanopi-r4s-rk3399_defconfig | 2 --
> configs/orangepi-r1-plus-lts-rk3328_defconfig | 2 --
> configs/orangepi-r1-plus-rk3328_defconfig | 2 --
> configs/pinebook-pro-rk3399_defconfig | 2 --
> configs/pinephone-pro-rk3399_defconfig | 2 --
> configs/puma-rk3399_defconfig | 2 --
> configs/roc-cc-rk3328_defconfig | 2 --
> configs/roc-pc-mezzanine-rk3399_defconfig | 2 --
> configs/roc-pc-rk3399_defconfig | 2 --
> configs/rock-4c-plus-rk3399_defconfig | 3 ---
> configs/rock-4se-rk3399_defconfig | 3 ---
> configs/rock-pi-4-rk3399_defconfig | 3 ---
> configs/rock-pi-4c-rk3399_defconfig | 3 ---
> configs/rock-pi-e-rk3328_defconfig | 2 --
> configs/rock-pi-n10-rk3399pro_defconfig | 1 -
> configs/rock64-rk3328_defconfig | 2 --
> configs/rock960-rk3399_defconfig | 1 -
> configs/rockpro64-rk3399_defconfig | 2 --
> 26 files changed, 4 insertions(+), 52 deletions(-)
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/4] rockchip: Read cpuid and generate MAC address from efuse for RK3328 and RK3399
2024-02-10 6:32 [PATCH 0/4] rockchip: Read cpuid and generate MAC address from efuse for RK3328 and RK3399 Chen-Yu Tsai
` (5 preceding siblings ...)
2024-02-10 16:37 ` Dragan Simic
@ 2024-02-12 13:57 ` Peter Robinson
2024-02-12 14:05 ` Chen-Yu Tsai
6 siblings, 1 reply; 12+ messages in thread
From: Peter Robinson @ 2024-02-12 13:57 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: u-boot, Chen-Yu Tsai, Tom Rini, Simon Glass, Philipp Tomsich,
Kever Yang, Alper Nebi Yasak, Tianling Shen, David Bauer,
Xiaobo Tian, Quentin Schulz, Klaus Goger, Loic Devulder,
Jonas Karlman, Levin Du, Suniel Mahesh, FUKAUMI Naoki,
Christopher Obbard, Jagan Teki, Banglang Huang,
Matwey V. Kornilov, Manivannan Sadhasivam
On Sat, 10 Feb 2024 at 06:32, Chen-Yu Tsai <wens@kernel.org> wrote:
>
> From: Chen-Yu Tsai <wens@csie.org>
>
> Hi folks,
>
> This series enables ROCKCHIP_EFUSE and MISC_INIT_R by default for RK3328
> and RK3399 so that the cpuid is read from the efuse and used to generate
> a serial number and MAC addresses for all boards.
For the series:
Reviewed-by: Peter Robinson <pbrobinson@gmail.com>
> This stacks on top of the recent defconfig update series [1] from Jonas.
>
> [1] https://lore.kernel.org/u-boot/20240207000301.3270722-1-jonas@kwiboo.se/
>
>
> Chen-Yu Tsai (4):
> rockchip: rk3328: Read cpuid and generate MAC address from efuse
> rockchip: rk3399: Read cpuid and generate MAC address from efuse
> rockchip: rk3328: regenerate defconfigs
> rockchip: rk3399: regenerate defconfigs
>
> arch/arm/mach-rockchip/Kconfig | 4 ++++
> configs/chromebook_bob_defconfig | 2 --
> configs/chromebook_kevin_defconfig | 2 --
> configs/evb-rk3328_defconfig | 2 --
> configs/firefly-rk3399_defconfig | 2 --
> configs/nanopi-r2c-plus-rk3328_defconfig | 2 --
> configs/nanopi-r2c-rk3328_defconfig | 2 --
> configs/nanopi-r2s-rk3328_defconfig | 2 --
> configs/nanopi-r4s-rk3399_defconfig | 2 --
> configs/orangepi-r1-plus-lts-rk3328_defconfig | 2 --
> configs/orangepi-r1-plus-rk3328_defconfig | 2 --
> configs/pinebook-pro-rk3399_defconfig | 2 --
> configs/pinephone-pro-rk3399_defconfig | 2 --
> configs/puma-rk3399_defconfig | 2 --
> configs/roc-cc-rk3328_defconfig | 2 --
> configs/roc-pc-mezzanine-rk3399_defconfig | 2 --
> configs/roc-pc-rk3399_defconfig | 2 --
> configs/rock-4c-plus-rk3399_defconfig | 3 ---
> configs/rock-4se-rk3399_defconfig | 3 ---
> configs/rock-pi-4-rk3399_defconfig | 3 ---
> configs/rock-pi-4c-rk3399_defconfig | 3 ---
> configs/rock-pi-e-rk3328_defconfig | 2 --
> configs/rock-pi-n10-rk3399pro_defconfig | 1 -
> configs/rock64-rk3328_defconfig | 2 --
> configs/rock960-rk3399_defconfig | 1 -
> configs/rockpro64-rk3399_defconfig | 2 --
> 26 files changed, 4 insertions(+), 52 deletions(-)
>
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/4] rockchip: Read cpuid and generate MAC address from efuse for RK3328 and RK3399
2024-02-12 13:57 ` Peter Robinson
@ 2024-02-12 14:05 ` Chen-Yu Tsai
0 siblings, 0 replies; 12+ messages in thread
From: Chen-Yu Tsai @ 2024-02-12 14:05 UTC (permalink / raw)
To: Peter Robinson
Cc: u-boot, Tom Rini, Simon Glass, Philipp Tomsich, Kever Yang,
Alper Nebi Yasak, Tianling Shen, David Bauer, Xiaobo Tian,
Quentin Schulz, Klaus Goger, Loic Devulder, Jonas Karlman,
Levin Du, Suniel Mahesh, FUKAUMI Naoki, Christopher Obbard,
Jagan Teki, Banglang Huang, Matwey V. Kornilov,
Manivannan Sadhasivam
On Mon, Feb 12, 2024 at 9:57 PM Peter Robinson <pbrobinson@gmail.com> wrote:
>
> On Sat, 10 Feb 2024 at 06:32, Chen-Yu Tsai <wens@kernel.org> wrote:
> >
> > From: Chen-Yu Tsai <wens@csie.org>
> >
> > Hi folks,
> >
> > This series enables ROCKCHIP_EFUSE and MISC_INIT_R by default for RK3328
> > and RK3399 so that the cpuid is read from the efuse and used to generate
> > a serial number and MAC addresses for all boards.
>
> For the series:
> Reviewed-by: Peter Robinson <pbrobinson@gmail.com>
Thanks. I just sent out v2. Could you reply there as well?
^ permalink raw reply [flat|nested] 12+ messages in thread