[Buildroot] [PATCH 1/1] package/libqrtr-glib: fix static build

[Buildroot] [PATCH 1/1] package/libqrtr-glib: fix static build

[Fabrice Fontaine]

Fix the following static build failure raised since bump to version
1.2.2 in commit b50bb982208011841fe0a9a7e4309808085cf493:

[5/5] Linking target src/libqrtr-glib/libqrtr-glib.so.0.0.0
FAILED: src/libqrtr-glib/libqrtr-glib.so.0.0.0

Fixes:
 - http://autobuild.buildroot.org/results/e0442e97279a07f33a14ec52840f98b7ec0fe32d

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 ...rtr-lib-meson.build-fix-static-build.patch | 36 +++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 package/libqrtr-glib/0001-src-libqrtr-lib-meson.build-fix-static-build.patch

diff --git a/package/libqrtr-glib/0001-src-libqrtr-lib-meson.build-fix-static-build.patch b/package/libqrtr-glib/0001-src-libqrtr-lib-meson.build-fix-static-build.patch
new file mode 100644
index 0000000000..8c0db7bed5
--- /dev/null
+++ b/package/libqrtr-glib/0001-src-libqrtr-lib-meson.build-fix-static-build.patch
@@ -0,0 +1,36 @@
+From dd9d68259c1fb79bcf40fcdf6aa1e6026edec9b2 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Date: Fri, 9 Feb 2024 21:16:39 +0100
+Subject: [PATCH] src/libqrtr-lib/meson.build: fix static build
+
+Replace shared_library by library to avoid the following static build
+failure:
+
+[5/5] Linking target src/libqrtr-glib/libqrtr-glib.so.0.0.0
+FAILED: src/libqrtr-glib/libqrtr-glib.so.0.0.0
+
+Fixes:
+ - http://autobuild.buildroot.org/results/e0442e97279a07f33a14ec52840f98b7ec0fe32d
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Upstream: https://gitlab.freedesktop.org/mobile-broadband/libqrtr-glib/-/merge_requests/24
+---
+ src/libqrtr-glib/meson.build | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/libqrtr-glib/meson.build b/src/libqrtr-glib/meson.build
+index bbdd869..0cddcc7 100644
+--- a/src/libqrtr-glib/meson.build
++++ b/src/libqrtr-glib/meson.build
+@@ -39,7 +39,7 @@ c_flags = [
+   '-DLIBEXEC_PATH="@0@"'.format(qrtr_prefix / qrtr_libexecdir),
+ ]
+ 
+-libqrtr_glib = shared_library(
++libqrtr_glib = library(
+   libname,
+   version: qrtr_glib_version,
+   sources: sources + [version_header],
+-- 
+2.43.0
+
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libqrtr-glib: fix static build

[Petr Vorel]

Hi Fabrice,

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Thanks!

> Fix the following static build failure raised since bump to version
> 1.2.2 in commit b50bb982208011841fe0a9a7e4309808085cf493:

> [5/5] Linking target src/libqrtr-glib/libqrtr-glib.so.0.0.0
> FAILED: src/libqrtr-glib/libqrtr-glib.so.0.0.0

> Fixes:
>  - http://autobuild.buildroot.org/results/e0442e97279a07f33a14ec52840f98b7ec0fe32d

I would also add usual Fixes:, but Buildroot might not use it.

Fixes: b50bb98220 ("package/libqrtr-glib: bump version to 1.2.2")

Kind regards,
Petr
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libqrtr-glib: fix static build

[Thomas Petazzoni via buildroot]

On Fri,  9 Feb 2024 21:38:52 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fix the following static build failure raised since bump to version
> 1.2.2 in commit b50bb982208011841fe0a9a7e4309808085cf493:
> 
> [5/5] Linking target src/libqrtr-glib/libqrtr-glib.so.0.0.0
> FAILED: src/libqrtr-glib/libqrtr-glib.so.0.0.0
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/e0442e97279a07f33a14ec52840f98b7ec0fe32d
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  ...rtr-lib-meson.build-fix-static-build.patch | 36 +++++++++++++++++++
>  1 file changed, 36 insertions(+)
>  create mode 100644 package/libqrtr-glib/0001-src-libqrtr-lib-meson.build-fix-static-build.patch

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot