From: Jakub Kicinski <kuba@kernel.org>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Yannick Vignon <yannick.vignon@nxp.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next] net: stmmac: Simplify mtl IRQ status checking
Date: Mon, 12 Feb 2024 07:12:16 -0800 [thread overview]
Message-ID: <20240212071216.21e36c5c@kernel.org> (raw)
In-Reply-To: <87il2t98ri.fsf@kurt.kurt.home>
On Mon, 12 Feb 2024 13:17:37 +0100 Kurt Kanzenbach wrote:
> On Thu Feb 08 2024, Kurt Kanzenbach wrote:
> > Commit 8a7cb245cf28 ("net: stmmac: Do not enable RX FIFO overflow
> > interrupts") disabled the RX FIFO overflow interrupts. However, it left the
> > status variable around, but never checks it.
> >
> > As stmmac_host_mtl_irq_status() returns only 0 now, the code can be
> > simplified.
> >
> > Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
>
> why did this got marked as Changes Requested. What changes have to be
> made?
Sorry, restored!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Yannick Vignon <yannick.vignon@nxp.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next] net: stmmac: Simplify mtl IRQ status checking
Date: Mon, 12 Feb 2024 07:12:16 -0800 [thread overview]
Message-ID: <20240212071216.21e36c5c@kernel.org> (raw)
In-Reply-To: <87il2t98ri.fsf@kurt.kurt.home>
On Mon, 12 Feb 2024 13:17:37 +0100 Kurt Kanzenbach wrote:
> On Thu Feb 08 2024, Kurt Kanzenbach wrote:
> > Commit 8a7cb245cf28 ("net: stmmac: Do not enable RX FIFO overflow
> > interrupts") disabled the RX FIFO overflow interrupts. However, it left the
> > status variable around, but never checks it.
> >
> > As stmmac_host_mtl_irq_status() returns only 0 now, the code can be
> > simplified.
> >
> > Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
>
> why did this got marked as Changes Requested. What changes have to be
> made?
Sorry, restored!
next prev parent reply other threads:[~2024-02-12 15:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 10:35 [PATCH net-next] net: stmmac: Simplify mtl IRQ status checking Kurt Kanzenbach
2024-02-08 10:35 ` Kurt Kanzenbach
2024-02-08 12:46 ` Maciej Fijalkowski
2024-02-08 12:46 ` Maciej Fijalkowski
2024-02-08 14:32 ` Kurt Kanzenbach
2024-02-08 14:32 ` Kurt Kanzenbach
2024-02-08 14:52 ` Maciej Fijalkowski
2024-02-08 14:52 ` Maciej Fijalkowski
2024-02-08 15:08 ` Kurt Kanzenbach
2024-02-08 15:08 ` Kurt Kanzenbach
2024-02-12 12:17 ` Kurt Kanzenbach
2024-02-12 12:17 ` Kurt Kanzenbach
2024-02-12 15:12 ` Jakub Kicinski [this message]
2024-02-12 15:12 ` Jakub Kicinski
2024-02-13 9:30 ` patchwork-bot+netdevbpf
2024-02-13 9:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240212071216.21e36c5c@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kurt@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yannick.vignon@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.