All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux@ew.tq-group.com
Subject: Re: [PATCH 1/1] arm64: dts: freescale: tqma9352: Update I2C eeprom compatible
Date: Mon, 12 Feb 2024 16:35:01 -0600	[thread overview]
Message-ID: <20240212223501.GA2674720-robh@kernel.org> (raw)
In-Reply-To: <20240110100526.478771-1-alexander.stein@ew.tq-group.com>

On Wed, Jan 10, 2024 at 11:05:26AM +0100, Alexander Stein wrote:
> Now that there is a dedicated compatible for the idendification page use
> that instead. This also allows the removal the size and pagesize
> properties.

This commit message fails to answer Why? 

And fails to mention the ABI break.

> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
> index f6e422dc2663e..9d2328c185c90 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
> @@ -122,10 +122,8 @@ eeprom1: eeprom@57 {
>  
>  	/* protectable identification memory (part of M24C64-D @57) */
>  	eeprom@5f {
> -		compatible = "st,24c64", "atmel,24c64";
> +		compatible = "atmel,24c64d-wl";

This compatible is not documented. Please add it to schema.

>  		reg = <0x5f>;
> -		size = <32>;
> -		pagesize = <32>;
>  		vcc-supply = <&reg_v3v3>;
>  	};
>  
> -- 
> 2.34.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux@ew.tq-group.com
Subject: Re: [PATCH 1/1] arm64: dts: freescale: tqma9352: Update I2C eeprom compatible
Date: Mon, 12 Feb 2024 16:35:01 -0600	[thread overview]
Message-ID: <20240212223501.GA2674720-robh@kernel.org> (raw)
In-Reply-To: <20240110100526.478771-1-alexander.stein@ew.tq-group.com>

On Wed, Jan 10, 2024 at 11:05:26AM +0100, Alexander Stein wrote:
> Now that there is a dedicated compatible for the idendification page use
> that instead. This also allows the removal the size and pagesize
> properties.

This commit message fails to answer Why? 

And fails to mention the ABI break.

> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
> index f6e422dc2663e..9d2328c185c90 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
> @@ -122,10 +122,8 @@ eeprom1: eeprom@57 {
>  
>  	/* protectable identification memory (part of M24C64-D @57) */
>  	eeprom@5f {
> -		compatible = "st,24c64", "atmel,24c64";
> +		compatible = "atmel,24c64d-wl";

This compatible is not documented. Please add it to schema.

>  		reg = <0x5f>;
> -		size = <32>;
> -		pagesize = <32>;
>  		vcc-supply = <&reg_v3v3>;
>  	};
>  
> -- 
> 2.34.1
> 

  parent reply	other threads:[~2024-02-12 22:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-10 10:05 [PATCH 1/1] arm64: dts: freescale: tqma9352: Update I2C eeprom compatible Alexander Stein
2024-01-10 10:05 ` Alexander Stein
2024-02-05  9:19 ` Shawn Guo
2024-02-05  9:19   ` Shawn Guo
2024-02-12 22:35 ` Rob Herring [this message]
2024-02-12 22:35   ` Rob Herring
2024-02-14  9:56   ` Alexander Stein
2024-02-14  9:56     ` Alexander Stein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240212223501.GA2674720-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux@ew.tq-group.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.