From: Kees Cook <keescook@chromium.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org,
netdev@vger.kernel.org, jakub@cloudflare.com
Subject: Re: [PATCH net-next 3/4] selftests: kselftest_harness: support using xfail
Date: Tue, 13 Feb 2024 09:57:03 -0800 [thread overview]
Message-ID: <202402130956.E23884A5B@keescook> (raw)
In-Reply-To: <20240213154416.422739-4-kuba@kernel.org>
On Tue, Feb 13, 2024 at 07:44:15AM -0800, Jakub Kicinski wrote:
> Selftest summary includes XFAIL but there's no way to use
> it from within the harness. Support it in a similar way to skip.
>
> Currently tests report skip for things they expect to fail
> e.g. when given combination of parameters is known to be unsupported.
> This is confusing because in an ideal environment and fully featured
> kernel no tests should be skipped.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This is great -- I've been wanting an XFAIL for a while for harness
users but I didn't have the imagination to find a way to make it work.
:)
Acked-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2024-02-13 17:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 15:44 [PATCH net-next 0/4] selftests: kselftest_harness: support using xfail Jakub Kicinski
2024-02-13 15:44 ` [PATCH net-next 1/4] selftests: kselftest_harness: pass step via shared memory Jakub Kicinski
2024-02-13 17:54 ` Kees Cook
2024-02-19 2:21 ` kernel test robot
2024-02-13 15:44 ` [PATCH net-next 2/4] selftests: kselftest_harness: use KSFT_* exit codes Jakub Kicinski
2024-02-13 17:55 ` Kees Cook
2024-02-13 15:44 ` [PATCH net-next 3/4] selftests: kselftest_harness: support using xfail Jakub Kicinski
2024-02-13 17:57 ` Kees Cook [this message]
2024-02-14 19:40 ` Jakub Sitnicki
2024-02-14 21:46 ` Jakub Sitnicki
2024-02-15 0:25 ` Jakub Kicinski
2024-02-15 0:40 ` Kees Cook
2024-02-15 22:06 ` Kees Cook
2024-02-15 22:42 ` Jakub Kicinski
2024-02-13 15:44 ` [PATCH net-next 4/4] selftests: ip_local_port_range: use XFAIL instead of SKIP Jakub Kicinski
2024-02-13 17:57 ` Kees Cook
2024-02-13 18:00 ` [PATCH net-next 0/4] selftests: kselftest_harness: support using xfail Kees Cook
2024-02-14 10:09 ` Jakub Sitnicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202402130956.E23884A5B@keescook \
--to=keescook@chromium.org \
--cc=jakub@cloudflare.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.